SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"

[edk2] [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"

Star Zeng posted 1 patch 7 years, 6 months ago

Download mbox

Failed in applying to current master (apply log)

SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Expand all Fold all

[edk2] [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"

Posted by Star Zeng 7 years, 6 months ago

Current code for case "TPM not working properly" uses the predefined
macro __FILE__ in debug format string, but uses predefined macro
__LINE__ as parameter, and it also uses multiple pairs of "" in debug
format string.

To be simple and clear, this patch is to update the code to just use
"DriverEntry: TPM not working properly\n" as the debug message.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Amy Chan <amy.chan@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
index 5b7c5c3e165b..4a90c5ccef16 100644
--- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
+++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
@@ -1406,9 +1406,7 @@ DriverEntry (
   if (EFI_ERROR (Status)) {
     DEBUG ((
       EFI_D_ERROR,
-      "Line %d in file " __FILE__ ":\n    "
-      "DriverEntry: TPM not working properly\n",
-      __LINE__
+      "DriverEntry: TPM not working properly\n"
       ));
     return Status;
   }
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel