BaseTools: Fix the bug that warn() function with only 1 argument

[edk2] [Patch] BaseTools: Fix the bug that warn() function with only 1 argument

Posted by Yonghong Zhu 7 years, 5 months ago

In the definition, the warn() function takes at least 2 arguments.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/build/build.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 1e14fb4..f7634fa 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -888,11 +888,11 @@ class Build():
         ToolChainFamily = []
         ToolDefinition = self.ToolDef.ToolsDefTxtDatabase
         for Tool in self.ToolChainList:
             if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not in ToolDefinition[TAB_TOD_DEFINES_FAMILY] \
                or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]:
-                EdkLogger.warn("No tool chain family found in configuration for %s. Default to MSFT." % Tool)
+                EdkLogger.warn("build", "No tool chain family found in configuration for %s. Default to MSFT." % Tool)
                 ToolChainFamily.append("MSFT")
             else:
                 ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool])
         self.ToolChainFamily = ToolChainFamily
 
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Fix the bug that warn() function with only 1 argument

Posted by Gao, Liming 7 years, 5 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zhu, Yonghong
>Sent: Tuesday, July 25, 2017 1:39 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [Patch] BaseTools: Fix the bug that warn() function with only 1
>argument
>
>In the definition, the warn() function takes at least 2 arguments.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 1e14fb4..f7634fa 100644
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -888,11 +888,11 @@ class Build():
>         ToolChainFamily = []
>         ToolDefinition = self.ToolDef.ToolsDefTxtDatabase
>         for Tool in self.ToolChainList:
>             if TAB_TOD_DEFINES_FAMILY not in ToolDefinition or Tool not in
>ToolDefinition[TAB_TOD_DEFINES_FAMILY] \
>                or not ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool]:
>-                EdkLogger.warn("No tool chain family found in configuration for %s.
>Default to MSFT." % Tool)
>+                EdkLogger.warn("build", "No tool chain family found in configuration
>for %s. Default to MSFT." % Tool)
>                 ToolChainFamily.append("MSFT")
>             else:
>
>ToolChainFamily.append(ToolDefinition[TAB_TOD_DEFINES_FAMILY][Tool])
>         self.ToolChainFamily = ToolChainFamily
>
>--
>2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel