[edk2] [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur

Star Zeng posted 2 patches 7 years, 4 months ago
[edk2] [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Posted by Star Zeng 7 years, 4 months ago
Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
MinDur displayed for custom cumulative data will be always 0,
but not the real shortest duration.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 PerformancePkg/Dp_App/Dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
index 4cdc39edb42e..484ef2d50b80 100644
--- a/PerformancePkg/Dp_App/Dp.c
+++ b/PerformancePkg/Dp_App/Dp.c
@@ -382,7 +382,7 @@ InitializeDp (
   if (CustomCumulativeToken != NULL) {
     CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
     ASSERT (CustomCumulativeData != NULL);
-    CustomCumulativeData->MinDur = 0;
+    CustomCumulativeData->MinDur = PERF_MAXDUR;
     CustomCumulativeData->MaxDur = 0;
     CustomCumulativeData->Count  = 0;
     CustomCumulativeData->Duration = 0;
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Posted by Gao, Liming 7 years, 4 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>;
>Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
>MinDur displayed for custom cumulative data will be always 0,
>but not the real shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> PerformancePkg/Dp_App/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c
>index 4cdc39edb42e..484ef2d50b80 100644
>--- a/PerformancePkg/Dp_App/Dp.c
>+++ b/PerformancePkg/Dp_App/Dp.c
>@@ -382,7 +382,7 @@ InitializeDp (
>   if (CustomCumulativeToken != NULL) {
>     CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
>     ASSERT (CustomCumulativeData != NULL);
>-    CustomCumulativeData->MinDur = 0;
>+    CustomCumulativeData->MinDur = PERF_MAXDUR;
>     CustomCumulativeData->MaxDur = 0;
>     CustomCumulativeData->Count  = 0;
>     CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur
Posted by Shia, Cinnamon 7 years, 4 months ago
Reviewed-by: Cinnamon Shia <cinnamon.shia@hpe.com>

-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com] 
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Shia, Cinnamon <cinnamon.shia@hpe.com>
Subject: RE: [PATCH 1/2] PerformancePkg DP: Init CustomCumulativeData.MinDur

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming 
><liming.gao@intel.com>; Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 1/2] PerformancePkg DP: Init 
>CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur 
>displayed for custom cumulative data will be always 0, but not the real 
>shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> PerformancePkg/Dp_App/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c 
>index 4cdc39edb42e..484ef2d50b80 100644
>--- a/PerformancePkg/Dp_App/Dp.c
>+++ b/PerformancePkg/Dp_App/Dp.c
>@@ -382,7 +382,7 @@ InitializeDp (
>   if (CustomCumulativeToken != NULL) {
>     CustomCumulativeData = AllocateZeroPool (sizeof (PERF_CUM_DATA));
>     ASSERT (CustomCumulativeData != NULL);
>-    CustomCumulativeData->MinDur = 0;
>+    CustomCumulativeData->MinDur = PERF_MAXDUR;
>     CustomCumulativeData->MaxDur = 0;
>     CustomCumulativeData->Count  = 0;
>     CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel