DP: Init CustomCumulativeData.MinDur

[edk2] [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur

Posted by Star Zeng 8 years, 6 months ago

Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
MinDur displayed for custom cumulative data will be always 0,
but not the real shortest duration.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/Library/UefiDpLib/Dp.c
index 35ead751becc..94fa61c7108e 100644
--- a/ShellPkg/Library/UefiDpLib/Dp.c
+++ b/ShellPkg/Library/UefiDpLib/Dp.c
@@ -250,7 +250,7 @@ ShellCommandRunDp (
     if (CustomCumulativeData == NULL) {
       return SHELL_OUT_OF_RESOURCES;
     }
-    CustomCumulativeData->MinDur = 0;
+    CustomCumulativeData->MinDur = PERF_MAXDUR;
     CustomCumulativeData->MaxDur = 0;
     CustomCumulativeData->Count  = 0;
     CustomCumulativeData->Duration = 0;
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur

Posted by Gao, Liming 8 years, 5 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni,
>Ruiyu <ruiyu.ni@intel.com>; Cinnamon Shia <cinnamon.shia@hpe.com>
>Subject: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the
>MinDur displayed for custom cumulative data will be always 0,
>but not the real shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/Library/UefiDpLib/Dp.c b/ShellPkg/Library/UefiDpLib/Dp.c
>index 35ead751becc..94fa61c7108e 100644
>--- a/ShellPkg/Library/UefiDpLib/Dp.c
>+++ b/ShellPkg/Library/UefiDpLib/Dp.c
>@@ -250,7 +250,7 @@ ShellCommandRunDp (
>     if (CustomCumulativeData == NULL) {
>       return SHELL_OUT_OF_RESOURCES;
>     }
>-    CustomCumulativeData->MinDur = 0;
>+    CustomCumulativeData->MinDur = PERF_MAXDUR;
>     CustomCumulativeData->MaxDur = 0;
>     CustomCumulativeData->Count  = 0;
>     CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur

Posted by Shia, Cinnamon 8 years, 5 months ago

Reviewed-by: Cinnamon Shia <cinnamon.shia@hpe.com>

-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com] 
Sent: Monday, August 14, 2017 2:59 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Shia, Cinnamon <cinnamon.shia@hpe.com>
Subject: RE: [PATCH 2/2] ShellPkg UefiDpLib: Init CustomCumulativeData.MinDur

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Zeng, Star
>Sent: Friday, August 11, 2017 4:35 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>; Gao, Liming 
><liming.gao@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Cinnamon Shia 
><cinnamon.shia@hpe.com>
>Subject: [PATCH 2/2] ShellPkg UefiDpLib: Init 
>CustomCumulativeData.MinDur
>
>Init CustomCumulativeData.MinDur to PERF_MAXDUR, otherwise the MinDur 
>displayed for custom cumulative data will be always 0, but not the real 
>shortest duration.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Cinnamon Shia <cinnamon.shia@hpe.com>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Star Zeng <star.zeng@intel.com>
>---
> ShellPkg/Library/UefiDpLib/Dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/ShellPkg/Library/UefiDpLib/Dp.c 
>b/ShellPkg/Library/UefiDpLib/Dp.c index 35ead751becc..94fa61c7108e 
>100644
>--- a/ShellPkg/Library/UefiDpLib/Dp.c
>+++ b/ShellPkg/Library/UefiDpLib/Dp.c
>@@ -250,7 +250,7 @@ ShellCommandRunDp (
>     if (CustomCumulativeData == NULL) {
>       return SHELL_OUT_OF_RESOURCES;
>     }
>-    CustomCumulativeData->MinDur = 0;
>+    CustomCumulativeData->MinDur = PERF_MAXDUR;
>     CustomCumulativeData->MaxDur = 0;
>     CustomCumulativeData->Count  = 0;
>     CustomCumulativeData->Duration = 0;
>--
>2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel