On 08/14/17 13:36, Brijesh Singh wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h | 24 ++++++++++----------
> OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c | 24 ++++++++++----------
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h
> index 8f17a16c88f5..6f51f816ef0f 100644
> --- a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h
> +++ b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h
> @@ -96,15 +96,15 @@ VirtioPciGetQueueSize (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueAlignment (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT32 Alignment
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT32 Alignment
> );
>
> EFI_STATUS
> EFIAPI
> VirtioPciSetPageSize (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT32 PageSize
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT32 PageSize
> );
>
> EFI_STATUS
> @@ -131,29 +131,29 @@ VirtioPciSetQueueAddress (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueSel (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Sel
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Sel
> );
>
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueNotify (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Index
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Index
> );
>
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueSize (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Size
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Size
> );
>
> EFI_STATUS
> EFIAPI
> VirtioPciSetDeviceStatus (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT8 DeviceStatus
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT8 DeviceStatus
> );
>
> #endif // _VIRTIO_PCI_DEVICE_DXE_H_
> diff --git a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c
> index 243aa14c2421..5f86914265ea 100644
> --- a/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c
> +++ b/OvmfPkg/VirtioPciDeviceDxe/VirtioPciFunctions.c
> @@ -196,8 +196,8 @@ VirtioPciSetQueueAddress (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueSel (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Sel
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Sel
> )
> {
> VIRTIO_PCI_DEVICE *Dev;
> @@ -211,8 +211,8 @@ VirtioPciSetQueueSel (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueAlignment (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT32 Alignment
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT32 Alignment
> )
> {
> return EFI_SUCCESS;
> @@ -221,8 +221,8 @@ VirtioPciSetQueueAlignment (
> EFI_STATUS
> EFIAPI
> VirtioPciSetPageSize (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT32 PageSize
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT32 PageSize
> )
> {
> return (PageSize == EFI_PAGE_SIZE) ? EFI_SUCCESS : EFI_UNSUPPORTED;
> @@ -231,8 +231,8 @@ VirtioPciSetPageSize (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueNotify (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Index
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Index
> )
> {
> VIRTIO_PCI_DEVICE *Dev;
> @@ -246,8 +246,8 @@ VirtioPciSetQueueNotify (
> EFI_STATUS
> EFIAPI
> VirtioPciSetQueueSize (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT16 Size
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT16 Size
> )
> {
> //
> @@ -260,8 +260,8 @@ VirtioPciSetQueueSize (
> EFI_STATUS
> EFIAPI
> VirtioPciSetDeviceStatus (
> - VIRTIO_DEVICE_PROTOCOL *This,
> - UINT8 DeviceStatus
> + IN VIRTIO_DEVICE_PROTOCOL *This,
> + IN UINT8 DeviceStatus
> )
> {
> VIRTIO_PCI_DEVICE *Dev;
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
Commit e5251fecb931763c90a032266fdd8ab5ec527744.
Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel