Dandan:
I have one minor comments. This protocol is in UEFI2.7. Please add it below UEFI2.7 comment in MdePkg.dec
Thanks
Liming
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, August 22, 2017 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V4 0/3] Add HII Popup Protocol
>
> Patch 1: Add the definition of HII Popup Protocol.
> Patch 2: Add the implementation of HII Popup Protocol.
> Patch 3: Add one sample use case of HII Popup Protocol.
>
> V4:
> Updates in pacth 2:
> Add more comments and remove one unnecessary
> check in function ParseMessageString().
>
> V3:
> Updates in pacth 2:
> Separate DrawMessageBox() function into CalculatePopupPosition()
> DrawMessageBox() and GetUserSelection() three functions and refine
> related codes.
>
> V2:
> Updates in pacth 2:
> Addstring "ERROR", "WARNING", "INFO" at the top of the message box
> to implement the different appearances for different styles of Popup.
> Updates in pacth 3:
> Update the date info in the Copyright.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Dandan Bi (3):
> MdePkg/HiiPopup: Add HII Popup Protocol definitions
> MdeModulePkg/DisplayEngine: Add implementation of HiiPopup protocol
> MdeModulePkg/DriverSample: Add sample case for popup protocol
>
> .../DisplayEngineDxe/DisplayEngineDxe.inf | 4 +-
> .../Universal/DisplayEngineDxe/FormDisplay.c | 42 ++
> .../Universal/DisplayEngineDxe/FormDisplay.h | 96 ++-
> .../Universal/DisplayEngineDxe/FormDisplayStr.uni | 20 +-
> MdeModulePkg/Universal/DisplayEngineDxe/Popup.c | 730 +++++++++++++++++++++
> .../Universal/DriverSampleDxe/DriverSample.c | 29 +
> .../Universal/DriverSampleDxe/DriverSample.h | 4 +-
> .../Universal/DriverSampleDxe/DriverSampleDxe.inf | 3 +-
> MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 10 +-
> .../Universal/DriverSampleDxe/VfrStrings.uni | 8 +-
> MdePkg/Include/Protocol/HiiPopup.h | 81 +++
> MdePkg/MdePkg.dec | 3 +
> 12 files changed, 1022 insertions(+), 8 deletions(-)
> create mode 100644 MdeModulePkg/Universal/DisplayEngineDxe/Popup.c
> create mode 100644 MdePkg/Include/Protocol/HiiPopup.h
>
> --
> 1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel