2_dsc_overview/29_pcd_sections.md | 4 ++++ 3_edk_ii_dsc_file_format/310_pcd_sections.md | 6 ++++++ README.md | 1 + 3 files changed, 11 insertions(+)
fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=597
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
2_dsc_overview/29_pcd_sections.md | 4 ++++
3_edk_ii_dsc_file_format/310_pcd_sections.md | 6 ++++++
README.md | 1 +
3 files changed, 11 insertions(+)
diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_sections.md
index 83689a9..6547656 100644
--- a/2_dsc_overview/29_pcd_sections.md
+++ b/2_dsc_overview/29_pcd_sections.md
@@ -250,10 +250,12 @@ described in the following table.
| `NV` | `EFI_VARIABLE_NON_VOLATILE` | `0x00000001` |
| `BS` | `EFI_VARIABLE_BOOTSERVICE_ACCESS` | `0x00000002` |
| `RT` | `EFI_VARIABLE_RUNTIME_ACCESS` | `0x00000004` |
| `RO` | `VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY` | `BIT0` |
+**Note:** The VariableName field in the HII format PCD entry must not be an empty string.
+
#### Examples
```ini
[PcdsDynamicHii.common.Sku_Two]
NoSuchTokenSpaceGuid.PcdPreAllocatedMem| 0x0053 0x0065 0x0074 0x0075 0x0070|gSysconfigGuid|0x000000A9|0x3
@@ -345,10 +347,12 @@ backslash character is used here to indicate the continuation of the line:
`PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|HiiDefaultValue]`
The optional HII Attribute entry is a comma separated list of attributes as
described in Table 9 HII Attributes.
+**Note:** The VariableName field in the HII format PCD entry must not be an empty string.
+
#### Examples
```ini
[PcdsDynamicExHii.IA32.Sku_Two]
gNoSuchTokenSpaceGuid.PcdPreAllocatedMem|0x0053 0x0065 0x0074 0x0075 0x0070|gSysconfigGuid|0x000000A9|0x11
diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_file_format/310_pcd_sections.md
index c061e5b..2af42cc 100644
--- a/3_edk_ii_dsc_file_format/310_pcd_sections.md
+++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md
@@ -514,10 +514,13 @@ of the offset.
A non-negative numeric value that is the number of bytes from the start to the
start of this variable. The offset value must not exceed the maximum value of
0xFFFF (`UINT16`).
+**_HiiString_**
+The HiiString field in the HII format PCD entry must not be an empty string.
+
**_SkuIds_**
`SkuId`s in the DSC file can be used in two different ways. They can be used to
as conditional modifiers to exclude some content from a build, or they can be
used to identify and group content during a build. If no `SkuId` option (`-x`)
@@ -671,10 +674,13 @@ of the offset.
A non-negative numeric value that is the number of bytes from the start to the
start of this variable. The offset value must not exceed the maximum value of
0xFFFF (`UINT16`).
+**_HiiString_**
+The HiiString field in the HII format PCD entry must not be an empty string.
+
**_SkuIds_**
`SkuId`s in the DSC file can be used in two different ways. They can be used to
as conditional modifiers to exclude some content from a build, or they can be
used to identify and group content during a build. If no `SkuId` option (`-x`)
diff --git a/README.md b/README.md
index 270857e..dd3419a 100644
--- a/README.md
+++ b/README.md
@@ -183,5 +183,6 @@ Copyright (c) 2006-2017, Intel Corporation. All rights reserved.
| | [#521](https://bugzilla.tianocore.org/show_bug.cgi?id=521) DSC spec: add clarification for mixed PCD usage in the DSC spec | |
| | [#519](https://bugzilla.tianocore.org/show_bug.cgi?id=519) DSC Spec: update Precedence of PCD Values | |
| | [#584](https://bugzilla.tianocore.org/show_bug.cgi?id=584) DSC Spec: Update the DSC_SPECIFICATION version to 0x0001001B or 1.27 | |
| | [#645](https://bugzilla.tianocore.org/show_bug.cgi?id=645) DSC Spec: Remove Restriction on Using NULL in [LibraryClasses] Section | |
| | [#669](https://bugzilla.tianocore.org/show_bug.cgi?id=669) DSC Spec: Add multi-arg support to PREBUILD/POSTBUILD | |
+| | [#597](https://bugzilla.tianocore.org/show_bug.cgi?id=597) DSC Spec: Hii type Pcd VariableName is NOT allowed to be empty string | |
--
2.6.1.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: Zhu, Yonghong > Sent: Tuesday, September 5, 2017 11:09 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com> > Subject: [Patch] DSC Spec: Hii type Pcd VariableName is NOT allowed to be empty string > > fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=597 > Cc: Liming Gao <liming.gao@intel.com> > Cc: Michael Kinney <michael.d.kinney@intel.com> > Cc: Kevin W Shaw <kevin.w.shaw@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> > --- > 2_dsc_overview/29_pcd_sections.md | 4 ++++ > 3_edk_ii_dsc_file_format/310_pcd_sections.md | 6 ++++++ > README.md | 1 + > 3 files changed, 11 insertions(+) > > diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_sections.md > index 83689a9..6547656 100644 > --- a/2_dsc_overview/29_pcd_sections.md > +++ b/2_dsc_overview/29_pcd_sections.md > @@ -250,10 +250,12 @@ described in the following table. > | `NV` | `EFI_VARIABLE_NON_VOLATILE` | `0x00000001` | > | `BS` | `EFI_VARIABLE_BOOTSERVICE_ACCESS` | `0x00000002` | > | `RT` | `EFI_VARIABLE_RUNTIME_ACCESS` | `0x00000004` | > | `RO` | `VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY` | `BIT0` | > > +**Note:** The VariableName field in the HII format PCD entry must not be an empty string. > + > #### Examples > > ```ini > [PcdsDynamicHii.common.Sku_Two] > NoSuchTokenSpaceGuid.PcdPreAllocatedMem| 0x0053 0x0065 0x0074 0x0075 0x0070|gSysconfigGuid|0x000000A9|0x3 > @@ -345,10 +347,12 @@ backslash character is used here to indicate the continuation of the line: > `PcdTokenSpaceGuidCName.PcdCName|VariableName|VariableGuid|VariableOffset[|HiiDefaultValue]` > > The optional HII Attribute entry is a comma separated list of attributes as > described in Table 9 HII Attributes. > > +**Note:** The VariableName field in the HII format PCD entry must not be an empty string. > + > #### Examples > > ```ini > [PcdsDynamicExHii.IA32.Sku_Two] > gNoSuchTokenSpaceGuid.PcdPreAllocatedMem|0x0053 0x0065 0x0074 0x0075 0x0070|gSysconfigGuid|0x000000A9|0x11 > diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_file_format/310_pcd_sections.md > index c061e5b..2af42cc 100644 > --- a/3_edk_ii_dsc_file_format/310_pcd_sections.md > +++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md > @@ -514,10 +514,13 @@ of the offset. > > A non-negative numeric value that is the number of bytes from the start to the > start of this variable. The offset value must not exceed the maximum value of > 0xFFFF (`UINT16`). > > +**_HiiString_** > +The HiiString field in the HII format PCD entry must not be an empty string. > + > **_SkuIds_** > > `SkuId`s in the DSC file can be used in two different ways. They can be used to > as conditional modifiers to exclude some content from a build, or they can be > used to identify and group content during a build. If no `SkuId` option (`-x`) > @@ -671,10 +674,13 @@ of the offset. > > A non-negative numeric value that is the number of bytes from the start to the > start of this variable. The offset value must not exceed the maximum value of > 0xFFFF (`UINT16`). > > +**_HiiString_** > +The HiiString field in the HII format PCD entry must not be an empty string. > + > **_SkuIds_** > > `SkuId`s in the DSC file can be used in two different ways. They can be used to > as conditional modifiers to exclude some content from a build, or they can be > used to identify and group content during a build. If no `SkuId` option (`-x`) > diff --git a/README.md b/README.md > index 270857e..dd3419a 100644 > --- a/README.md > +++ b/README.md > @@ -183,5 +183,6 @@ Copyright (c) 2006-2017, Intel Corporation. All rights reserved. > | | [#521](https://bugzilla.tianocore.org/show_bug.cgi?id=521) DSC spec: add clarification for mixed PCD usage in the > DSC spec > | | > | | [#519](https://bugzilla.tianocore.org/show_bug.cgi?id=519) DSC Spec: update Precedence of PCD Values > | | > | | [#584](https://bugzilla.tianocore.org/show_bug.cgi?id=584) DSC Spec: Update the DSC_SPECIFICATION version to > 0x0001001B or 1.27 > | | > | | [#645](https://bugzilla.tianocore.org/show_bug.cgi?id=645) DSC Spec: Remove Restriction on Using NULL in > [LibraryClasses] Section > | | > | | [#669](https://bugzilla.tianocore.org/show_bug.cgi?id=669) DSC Spec: Add multi-arg support to > PREBUILD/POSTBUILD > | | > +| | [#597](https://bugzilla.tianocore.org/show_bug.cgi?id=597) DSC Spec: Hii type Pcd VariableName is NOT allowed to > be empty string > | | > -- > 2.6.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.