[edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning

Heyi Guo posted 11 patches 7 years, 3 months ago
There is a newer version of this series
[edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning
Posted by Heyi Guo 7 years, 3 months ago
From: Chenhui Sun <chenhui.sun@linaro.org>

The PerTuning function is not stable, it will cause the
3008/3108 crash, disable this function first.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>
---
 Platform/Hisilicon/D03/D03.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index fca6781..ac880d9 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -112,7 +112,7 @@
   #  It could be set FALSE to save size.
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
   gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
-  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
+  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE
 
 [PcdsFixedAtBuild.common]
   gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"
-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning
Posted by Leif Lindholm 7 years, 3 months ago
On Thu, Sep 21, 2017 at 06:59:54PM +0800, Heyi Guo wrote:
> From: Chenhui Sun <chenhui.sun@linaro.org>
> 
> The PerTuning function is not stable, it will cause the
> 3008/3108 crash, disable this function first.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chenhui Sun <chenhui.sun@linaro.org>

I do not see any of my comments from previous revision addressed, and
I received no reply. Feedback was:
---
Should this not also delete the PciPerfTuning() function from
PcieInitLib.c, and the declaration of
gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable from HisiPkg.dec?
---

/
    Leif

> ---
>  Platform/Hisilicon/D03/D03.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index fca6781..ac880d9 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -112,7 +112,7 @@
>    #  It could be set FALSE to save size.
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
>    gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
> -  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
> +  gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE
>  
>  [PcdsFixedAtBuild.common]
>    gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03"
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel