[edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2

Heyi Guo posted 11 patches 7 years, 3 months ago
There is a newer version of this series
[edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2
Posted by Heyi Guo 7 years, 3 months ago
From: Ming Huang <waip23@foxmail.com>

There are no interface from SAS0 and SAS2 controller on D05,
so SAS0 and SAS2 can't be use.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <huangming23@huawei.com>
---
 Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
index 93beb95..6455130 100644
--- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
+++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
@@ -88,6 +88,11 @@ Scope(_SB)
       Store(0x7ffff, CLK)
       Sleep(1)
     }
+
+	Method (_STA, 0, NotSerialized)
+	{
+	  Return (0x0)
+	}
   }
 
   Device(SAS1) {
@@ -239,6 +244,11 @@ Scope(_SB)
       Store(0x7ffff, CLK)
       Sleep(1)
     }
+
+	Method (_STA, 0, NotSerialized)
+	{
+	  Return (0x0)
+	}
   }
 
 }
-- 
1.9.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2
Posted by Leif Lindholm 7 years, 3 months ago
On Thu, Sep 21, 2017 at 06:59:55PM +0800, Heyi Guo wrote:
> From: Ming Huang <waip23@foxmail.com>

Can you ensure all "From: " tags use the proper huawei.com addresses?
Signed-off-by below is already correct.
Also, since you are sending these patches out, you should also add
your "Signed-off-by:" below that of the patch author. (Please double
check this on other patches where I have missed it.)

Apart from that, this patch is fine.

/
    Leif

> 
> There are no interface from SAS0 and SAS2 controller on D05,
> so SAS0 and SAS2 can't be use.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang <huangming23@huawei.com>
> ---
>  Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> index 93beb95..6455130 100644
> --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl
> @@ -88,6 +88,11 @@ Scope(_SB)
>        Store(0x7ffff, CLK)
>        Sleep(1)
>      }
> +
> +	Method (_STA, 0, NotSerialized)
> +	{
> +	  Return (0x0)
> +	}
>    }
>  
>    Device(SAS1) {
> @@ -239,6 +244,11 @@ Scope(_SB)
>        Store(0x7ffff, CLK)
>        Sleep(1)
>      }
> +
> +	Method (_STA, 0, NotSerialized)
> +	{
> +	  Return (0x0)
> +	}
>    }
>  
>  }
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel