[edk2] [patch] UefiCpuPkg/CpuDxe: Add missing function description comments

Dandan Bi posted 1 patch 7 years, 3 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +++
1 file changed, 3 insertions(+)
[edk2] [patch] UefiCpuPkg/CpuDxe: Add missing function description comments
Posted by Dandan Bi 7 years, 3 months ago
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
index a25b35c..9c0d223 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.h
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
@@ -263,10 +263,13 @@ VOID
 EFIAPI
 SetDataSelectors (
   UINT16 Selector
   );
 
+/**
+  Update GCD memory space attributes according to current page table setup.
+**/
 VOID
 RefreshGcdMemoryAttributesFromPaging (
   VOID
   );
 
-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] UefiCpuPkg/CpuDxe: Add missing function description comments
Posted by Wang, Jian J 7 years, 3 months ago
Thanks for adding the comment. It look good to me.

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, September 25, 2017 2:01 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [patch] UefiCpuPkg/CpuDxe: Add missing function description
> comments
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h
> index a25b35c..9c0d223 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.h
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h
> @@ -263,10 +263,13 @@ VOID
>  EFIAPI
>  SetDataSelectors (
>    UINT16 Selector
>    );
> 
> +/**
> +  Update GCD memory space attributes according to current page table setup.
> +**/
>  VOID
>  RefreshGcdMemoryAttributesFromPaging (
>    VOID
>    );
> 
> --
> 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel