[edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

Liming Gao posted 11 patches 7 years, 3 months ago
[edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
Posted by Liming Gao 7 years, 3 months ago
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 FatPkg/EnhancedFatDxe/Fat.inf |  2 +-
 FatPkg/FatPei/FatPei.inf      | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf
index e7044cd..686b371 100644
--- a/FatPkg/EnhancedFatDxe/Fat.inf
+++ b/FatPkg/EnhancedFatDxe/Fat.inf
@@ -81,7 +81,7 @@
 
 [Protocols]
   gEfiDiskIoProtocolGuid                ## TO_START
-  gEfiDiskIo2ProtocolGuid               ## TO_START
+  gEfiDiskIo2ProtocolGuid               ## SOMETIMES_CONSUMES
   gEfiBlockIoProtocolGuid               ## TO_START
   gEfiSimpleFileSystemProtocolGuid      ## BY_START
   gEfiUnicodeCollationProtocolGuid      ## TO_START
diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf
index 273f72d..c963429 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -61,9 +61,13 @@
 
 
 [Ppis]
-  gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIoPpiGuid
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIo2PpiGuid
+  gEfiPeiDeviceRecoveryModulePpiGuid          ## PRODUCES
 
 
 [FeaturePcd]
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
Posted by Ni, Ruiyu 7 years, 3 months ago
Liming,
There is no keyword such as "SOMETIMES_TO_START"?
The DiskIo2 is indeed a TO_START protocol, but optional.

-----Original Message-----
From: Gao, Liming 
Sent: Monday, September 25, 2017 7:06 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
---
 FatPkg/EnhancedFatDxe/Fat.inf |  2 +-
 FatPkg/FatPei/FatPei.inf      | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf index e7044cd..686b371 100644
--- a/FatPkg/EnhancedFatDxe/Fat.inf
+++ b/FatPkg/EnhancedFatDxe/Fat.inf
@@ -81,7 +81,7 @@
 
 [Protocols]
   gEfiDiskIoProtocolGuid                ## TO_START
-  gEfiDiskIo2ProtocolGuid               ## TO_START
+  gEfiDiskIo2ProtocolGuid               ## SOMETIMES_CONSUMES
   gEfiBlockIoProtocolGuid               ## TO_START
   gEfiSimpleFileSystemProtocolGuid      ## BY_START
   gEfiUnicodeCollationProtocolGuid      ## TO_START
diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f72d..c963429 100644
--- a/FatPkg/FatPei/FatPei.inf
+++ b/FatPkg/FatPei/FatPei.inf
@@ -61,9 +61,13 @@
 
 
 [Ppis]
-  gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES PPI_NOTIFY
-  gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIoPpiGuid
+  ## NOTIFY
+  ## SOMETIMES_CONSUMES
+  gEfiPeiVirtualBlockIo2PpiGuid
+  gEfiPeiDeviceRecoveryModulePpiGuid          ## PRODUCES
 
 
 [FeaturePcd]
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
Posted by Gao, Liming 7 years, 3 months ago
Ray:
  There is no such key. OK, I will keep its usage to TO_START. 

Thanks
Liming
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Monday, September 25, 2017 8:44 PM
> To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
> 
> Liming,
> There is no keyword such as "SOMETIMES_TO_START"?
> The DiskIo2 is indeed a TO_START protocol, but optional.
> 
> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, September 25, 2017 7:06 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [Patch 02/11] FatPkg: Update Ppi/Protocol usage in Fat INF to match source code logic
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
>  FatPkg/EnhancedFatDxe/Fat.inf |  2 +-
>  FatPkg/FatPei/FatPei.inf      | 10 +++++++---
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/FatPkg/EnhancedFatDxe/Fat.inf b/FatPkg/EnhancedFatDxe/Fat.inf index e7044cd..686b371 100644
> --- a/FatPkg/EnhancedFatDxe/Fat.inf
> +++ b/FatPkg/EnhancedFatDxe/Fat.inf
> @@ -81,7 +81,7 @@
> 
>  [Protocols]
>    gEfiDiskIoProtocolGuid                ## TO_START
> -  gEfiDiskIo2ProtocolGuid               ## TO_START
> +  gEfiDiskIo2ProtocolGuid               ## SOMETIMES_CONSUMES
>    gEfiBlockIoProtocolGuid               ## TO_START
>    gEfiSimpleFileSystemProtocolGuid      ## BY_START
>    gEfiUnicodeCollationProtocolGuid      ## TO_START
> diff --git a/FatPkg/FatPei/FatPei.inf b/FatPkg/FatPei/FatPei.inf index 273f72d..c963429 100644
> --- a/FatPkg/FatPei/FatPei.inf
> +++ b/FatPkg/FatPei/FatPei.inf
> @@ -61,9 +61,13 @@
> 
> 
>  [Ppis]
> -  gEfiPeiVirtualBlockIoPpiGuid                  ## SOMETIMES_CONSUMES PPI_NOTIFY
> -  gEfiPeiVirtualBlockIo2PpiGuid                 ## SOMETIMES_CONSUMES PPI_NOTIFY
> -  gEfiPeiDeviceRecoveryModulePpiGuid            ## SOMETIMES_PRODUCES
> +  ## NOTIFY
> +  ## SOMETIMES_CONSUMES
> +  gEfiPeiVirtualBlockIoPpiGuid
> +  ## NOTIFY
> +  ## SOMETIMES_CONSUMES
> +  gEfiPeiVirtualBlockIo2PpiGuid
> +  gEfiPeiDeviceRecoveryModulePpiGuid          ## PRODUCES
> 
> 
>  [FeaturePcd]
> --
> 2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel