1. Patchew
  2. EDK2
  3. View series

[edk2] [patch] ShellPkg/Dh: Refine variable naming style

Dandan Bi posted 1 patch 8 years, 2 months ago
Failed in applying to current master (apply log)
ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[edk2] [patch] ShellPkg/Dh: Refine variable naming style
Posted by Dandan Bi 8 years, 2 months ago 
Avoid using only lower-case characters for variable name.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
index 7d06163..a7bd251 100644
--- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
+++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
@@ -284,11 +284,11 @@ GetProtocolInfoString(
   EFI_STATUS                Status;
   CHAR16                    *RetVal;
   UINTN                     Size;
   CHAR16                    *Temp;
   CHAR16                    GuidStr[40];
-  VOID                      *instance;
+  VOID                      *Instance;
   CHAR16                    InstanceStr[17];
 
   ProtocolGuidArray = NULL;
   RetVal            = NULL;
   Size              = 0;
@@ -314,14 +314,14 @@ GetProtocolInfoString(
         FreePool(Temp);
       }
       StrnCatGrow(&RetVal, &Size, L"%N", 0);
 
       if(Verbose) {
-        Status = gBS->HandleProtocol (TheHandle, ProtocolGuidArray[ProtocolIndex], &instance);
+        Status = gBS->HandleProtocol (TheHandle, ProtocolGuidArray[ProtocolIndex], &Instance);
         if (!EFI_ERROR (Status)) {
           StrnCatGrow (&RetVal, &Size, L"(%H", 0);
-          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
+          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
           StrnCatGrow (&RetVal, &Size, InstanceStr, 0);
           StrnCatGrow (&RetVal, &Size, L"%N)", 0);
         }
       }
 
-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style
Posted by Ni, Ruiyu 8 years, 2 months ago 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, September 28, 2017 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [patch] ShellPkg/Dh: Refine variable naming style
> 
> Avoid using only lower-case characters for variable name.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> index 7d06163..a7bd251 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> @@ -284,11 +284,11 @@ GetProtocolInfoString(
>    EFI_STATUS                Status;
>    CHAR16                    *RetVal;
>    UINTN                     Size;
>    CHAR16                    *Temp;
>    CHAR16                    GuidStr[40];
> -  VOID                      *instance;
> +  VOID                      *Instance;
>    CHAR16                    InstanceStr[17];
> 
>    ProtocolGuidArray = NULL;
>    RetVal            = NULL;
>    Size              = 0;
> @@ -314,14 +314,14 @@ GetProtocolInfoString(
>          FreePool(Temp);
>        }
>        StrnCatGrow(&RetVal, &Size, L"%N", 0);
> 
>        if(Verbose) {
> -        Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], &instance);
> +        Status = gBS->HandleProtocol (TheHandle,
> ProtocolGuidArray[ProtocolIndex], &Instance);
>          if (!EFI_ERROR (Status)) {
>            StrnCatGrow (&RetVal, &Size, L"(%H", 0);
> -          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
> +          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
>            StrnCatGrow (&RetVal, &Size, InstanceStr, 0);
>            StrnCatGrow (&RetVal, &Size, L"%N)", 0);
>          }
>        }
> 
> --
> 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style
Posted by Carsey, Jaben 8 years, 2 months ago 
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 10:57 PM
> To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: RE: [patch] ShellPkg/Dh: Refine variable naming style
> Importance: High
> 
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Thanks/Ray
> 
> > -----Original Message-----
> > From: Bi, Dandan
> > Sent: Thursday, September 28, 2017 10:45 AM
> > To: edk2-devel@lists.01.org
> > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> > Subject: [patch] ShellPkg/Dh: Refine variable naming style
> >
> > Avoid using only lower-case characters for variable name.
> >
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> >  ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > index 7d06163..a7bd251 100644
> > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c
> > @@ -284,11 +284,11 @@ GetProtocolInfoString(
> >    EFI_STATUS                Status;
> >    CHAR16                    *RetVal;
> >    UINTN                     Size;
> >    CHAR16                    *Temp;
> >    CHAR16                    GuidStr[40];
> > -  VOID                      *instance;
> > +  VOID                      *Instance;
> >    CHAR16                    InstanceStr[17];
> >
> >    ProtocolGuidArray = NULL;
> >    RetVal            = NULL;
> >    Size              = 0;
> > @@ -314,14 +314,14 @@ GetProtocolInfoString(
> >          FreePool(Temp);
> >        }
> >        StrnCatGrow(&RetVal, &Size, L"%N", 0);
> >
> >        if(Verbose) {
> > -        Status = gBS->HandleProtocol (TheHandle,
> > ProtocolGuidArray[ProtocolIndex], &instance);
> > +        Status = gBS->HandleProtocol (TheHandle,
> > ProtocolGuidArray[ProtocolIndex], &Instance);
> >          if (!EFI_ERROR (Status)) {
> >            StrnCatGrow (&RetVal, &Size, L"(%H", 0);
> > -          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", instance);
> > +          UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Instance);
> >            StrnCatGrow (&RetVal, &Size, InstanceStr, 0);
> >            StrnCatGrow (&RetVal, &Size, L"%N)", 0);
> >          }
> >        }
> >
> > --
> > 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2025 Red Hat, Inc.