IntelSiliconPkg/VTdDxe: return unsupported for exceptionlist

[edk2] [PATCH] IntelSiliconPkg/VTdDxe: return unsupported for exceptionlist

Posted by Jiewen Yao 7 years, 12 months ago

Since the exception list is not a recommended way, we returns
EFI_UNSUPPORTED in the sample code.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c b/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
index 3587fa3..e522db0 100644
--- a/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
+++ b/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
@@ -359,6 +359,7 @@ PlatformVTdGetExceptionDeviceList (
   // Uncomment to take affect and comment the sample codes for device scope
   // based exception list.
   //
+  /*
   *DeviceInfo = AllocateZeroPool (sizeof(mExceptionPciDeviceIdList));
   if (*DeviceInfo == NULL) {
     return EFI_OUT_OF_RESOURCES;
@@ -366,8 +367,8 @@ PlatformVTdGetExceptionDeviceList (
   CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, sizeof(mExceptionPciDeviceIdList));
 
   *DeviceInfoCount = ARRAY_SIZE(mExceptionPciDeviceIdList);
-
-  return EFI_SUCCESS;
+  */
+  return EFI_UNSUPPORTED;
 }
 
 EDKII_PLATFORM_VTD_POLICY_PROTOCOL  mPlatformVTdSample = {
-- 
2.7.4.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: return unsupported for exceptionlist

Posted by Zeng, Star 7 years, 12 months ago

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiewen Yao
Sent: Thursday, October 26, 2017 10:14 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>
Subject: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: return unsupported for exceptionlist

Since the exception list is not a recommended way, we returns
EFI_UNSUPPORTED in the sample code.

Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
 IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c b/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
index 3587fa3..e522db0 100644
--- a/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
+++ b/IntelSiliconPkg/Feature/VTd/PlatformVTdSampleDxe/PlatformVTdSampleDxe.c
@@ -359,6 +359,7 @@ PlatformVTdGetExceptionDeviceList (
   // Uncomment to take affect and comment the sample codes for device scope
   // based exception list.
   //
+  /*
   *DeviceInfo = AllocateZeroPool (sizeof(mExceptionPciDeviceIdList));
   if (*DeviceInfo == NULL) {
     return EFI_OUT_OF_RESOURCES;
@@ -366,8 +367,8 @@ PlatformVTdGetExceptionDeviceList (
   CopyMem (*DeviceInfo, mExceptionPciDeviceIdList, sizeof(mExceptionPciDeviceIdList));
 
   *DeviceInfoCount = ARRAY_SIZE(mExceptionPciDeviceIdList);
-
-  return EFI_SUCCESS;
+  */
+  return EFI_UNSUPPORTED;
 }
 
 EDKII_PLATFORM_VTD_POLICY_PROTOCOL  mPlatformVTdSample = {
-- 
2.7.4.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel