From nobody Wed Dec 25 05:54:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1512555188427528.1520711618022; Wed, 6 Dec 2017 02:13:08 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 360F72217CE4A; Wed, 6 Dec 2017 02:08:34 -0800 (PST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA5362217CE24 for ; Wed, 6 Dec 2017 02:08:33 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 02:13:05 -0800 Received: from shwdeopenpsi168.ccr.corp.intel.com ([10.239.158.129]) by fmsmga006.fm.intel.com with ESMTP; 06 Dec 2017 02:13:04 -0800 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,367,1508828400"; d="scan'208";a="184558098" From: Yonghong Zhu To: edk2-devel@lists.01.org Date: Wed, 6 Dec 2017 18:12:58 +0800 Message-Id: <1512555179-10976-3-git-send-email-yonghong.zhu@intel.com> X-Mailer: git-send-email 2.6.1.windows.1 In-Reply-To: <1512555179-10976-1-git-send-email-yonghong.zhu@intel.com> References: <1512555179-10976-1-git-send-email-yonghong.zhu@intel.com> Subject: [edk2] [Patch 2/3] BaseTools: back up the binary files when hash value is same X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liming Gao MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" We meet the case that first build with --hash option, then build it again with --hash and --binary-destination option, since the hash value is same, tool will not build the driver again, it cause the binary files are not backed up. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 22 +++++++++++++++++----- BaseTools/Source/Python/build/build.py | 5 +++++ 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/= Python/AutoGen/AutoGen.py index 8ad385a..740bd4f 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -2706,21 +2706,21 @@ class ModuleAutoGen(AutoGen): # @param Target Build target (DEBUG, RELEASE) # @param Toolchain Name of tool chain # @param Arch The arch the module supports # @param PlatformFile Platform meta-file # - def _Init(self, Workspace, ModuleFile, Target, Toolchain, Arch, Platfo= rmFile): + def _Init(self, Workspace, ModuleFile, Target, Toolchain, Arch, Platfo= rmFile, Flag=3DFalse): EdkLogger.debug(EdkLogger.DEBUG_9, "AutoGen module [%s] [%s]" % (M= oduleFile, Arch)) GlobalData.gProcessingFile =3D "%s [%s, %s, %s]" % (ModuleFile, Ar= ch, Toolchain, Target) =20 self.Workspace =3D Workspace self.WorkspaceDir =3D Workspace.WorkspaceDir - + self.Flag =3D Flag self.MetaFile =3D ModuleFile self.PlatformInfo =3D PlatformAutoGen(Workspace, PlatformFile, Tar= get, Toolchain, Arch) # check if this module is employed by active platform - if not self.PlatformInfo.ValidModule(self.MetaFile): + if not self.Flag and not self.PlatformInfo.ValidModule(self.MetaFi= le): EdkLogger.verbose("Module [%s] for [%s] is not employed by act= ive platform\n" \ % (self.MetaFile, Arch)) return False =20 self.SourceDir =3D self.MetaFile.SubDir @@ -2828,10 +2828,13 @@ class ModuleAutoGen(AutoGen): =20 return self._FixedAtBuildPcds =20 =20 def _GetUniqueBaseName(self): BaseName =3D self.Name + # when self.Flag is true, the module is Asbuilt inf in the build o= utput + if self.Flag: + return BaseName for Module in self.PlatformInfo.ModuleAutoGenList: if Module.MetaFile =3D=3D self.MetaFile: continue if Module.Name =3D=3D self.Name: if uuid.UUID(Module.Guid) =3D=3D uuid.UUID(self.Guid): @@ -3836,11 +3839,17 @@ class ModuleAutoGen(AutoGen): fInputfile.close () return OutputName =20 ## Create AsBuilt INF file the module # - def CreateAsBuiltInf(self): + def CreateAsBuiltInf(self, IsOnlyCopy =3D False): + self.OutputFile =3D [] + if IsOnlyCopy: + if GlobalData.gBinCacheDest: + self.CopyModuleToCache() + return + if self.IsAsBuiltInfCreated: return =20 # Skip the following code for EDK I inf if self.AutoGenVersion < 0x00010005: @@ -3969,11 +3978,10 @@ class ModuleAutoGen(AutoGen): AsBuiltInfDict['module_uefi_specification_version'] +=3D [self= .Specification['UEFI_SPECIFICATION_VERSION']] if 'PI_SPECIFICATION_VERSION' in self.Specification: AsBuiltInfDict['module_pi_specification_version'] +=3D [self.S= pecification['PI_SPECIFICATION_VERSION']] =20 OutputDir =3D self.OutputDir.replace('\\', '/').strip('/') - self.OutputFile =3D [] for Item in self.CodaTargetList: File =3D Item.Target.Path.replace('\\', '/').strip('/').replac= e(OutputDir, '').strip('/') if File not in self.OutputFile: self.OutputFile.append(File) if Item.Target.Ext.lower() =3D=3D '.aml': @@ -4196,12 +4204,16 @@ class ModuleAutoGen(AutoGen): ModuleFile =3D path.join(self.OutputDir, self.Name + '.inf') if os.path.exists(HashFile): shutil.copy2(HashFile, FileDir) if os.path.exists(ModuleFile): shutil.copy2(ModuleFile, FileDir) + if not self.OutputFile: + Ma =3D ModuleAutoGen(self.Workspace, PathClass(ModuleFile), se= lf.BuildTarget, self.ToolChain, self.Arch, self.Workspace.Platform.MetaFile= , True) + self.OutputFile =3D Ma.BinaryFileList if self.OutputFile: for File in self.OutputFile: + File =3D str(File) if not os.path.isabs(File): File =3D os.path.join(self.OutputDir, File) if os.path.exists(File): shutil.copy2(File, FileDir) =20 diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index f94285a..457f6c9 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -823,10 +823,11 @@ class Build(): self.Platform =3D None self.ToolChainFamily =3D None self.LoadFixAddress =3D 0 self.UniFlag =3D BuildOptions.Flag self.BuildModules =3D [] + self.HashSkipModules =3D [] self.Db_Flag =3D False self.LaunchPrebuildFlag =3D False self.PlatformBuildPath =3D os.path.join(GlobalData.gConfDirectory,= '.cache', '.PlatformBuild') if BuildOptions.CommandLength: GlobalData.gCommandMaxLength =3D BuildOptions.CommandLength @@ -2014,10 +2015,11 @@ class Build(): Ma =3D ModuleAutoGen(Wa, Module, BuildTarget, Tool= Chain, Arch, self.PlatformFile) =20 if Ma =3D=3D None: continue if Ma.CanSkipbyHash(): + self.HashSkipModules.append(Ma) continue =20 # Not to auto-gen for targets 'clean', 'cleanlib',= 'cleanall', 'run', 'fds' if self.Target not in ['clean', 'cleanlib', 'clean= all', 'run', 'fds']: # for target which must generate AutoGen code = and makefile @@ -2212,11 +2214,14 @@ class Build(): RemoveDirectory(os.path.dirname(GlobalData.gDatabasePath), Tru= e) =20 def CreateAsBuiltInf(self): for Module in self.BuildModules: Module.CreateAsBuiltInf() + for Module in self.HashSkipModules: + Module.CreateAsBuiltInf(True) self.BuildModules =3D [] + self.HashSkipModules =3D [] ## Do some clean-up works when error occurred def Relinquish(self): OldLogLevel =3D EdkLogger.GetLevel() EdkLogger.SetLevel(EdkLogger.ERROR) #self.DumpBuildData() --=20 2.6.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel