From nobody Sun May 11 15:50:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1514270125340441.7425262266395; Mon, 25 Dec 2017 22:35:25 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 351CD222F4E17; Mon, 25 Dec 2017 22:30:30 -0800 (PST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4101321CB87A5 for ; Mon, 25 Dec 2017 22:30:27 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2017 22:35:21 -0800 Received: from jiaxinwu-mobl2.ccr.corp.intel.com ([10.239.196.165]) by fmsmga006.fm.intel.com with ESMTP; 25 Dec 2017 22:35:20 -0800 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jiaxin.wu@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,458,1508828400"; d="scan'208";a="190005806" From: Jiaxin Wu To: edk2-devel@lists.01.org Date: Tue, 26 Dec 2017 14:35:13 +0800 Message-Id: <1514270114-5776-2-git-send-email-jiaxin.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 In-Reply-To: <1514270114-5776-1-git-send-email-jiaxin.wu@intel.com> References: <1514270114-5776-1-git-send-email-jiaxin.wu@intel.com> Subject: [edk2] [Patch 1/2] NetworkPkg/HttpDxe: Fix the memory leak issue in HttpRequest(). X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ye Ting , Wang Fan , Fu Siyuan , Wu Jiaxin MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Cc: Wang Fan Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpImpl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/HttpDxe/HttpImpl.c b/NetworkPkg/HttpDxe/HttpImpl.c index 57fa39f..fe1c3b7 100644 --- a/NetworkPkg/HttpDxe/HttpImpl.c +++ b/NetworkPkg/HttpDxe/HttpImpl.c @@ -470,10 +470,12 @@ EfiHttpRequest ( =20 Wrap->TcpWrap.Method =3D Request->Method; =20 FreePool (HostName); =20 + HttpUrlFreeParser (UrlParser); + // // Queue the HTTP token and return. // return EFI_SUCCESS; } else { @@ -654,10 +656,14 @@ EfiHttpRequest ( DispatchDpc (); =20 if (HostName !=3D NULL) { FreePool (HostName); } + + if (UrlParser !=3D NULL) { + HttpUrlFreeParser (UrlParser); + } =20 return EFI_SUCCESS; =20 Error5: // @@ -697,11 +703,11 @@ Error1: FreePool (HostName); } if (Wrap !=3D NULL) { FreePool (Wrap); } - if (UrlParser!=3D NULL) { + if (UrlParser !=3D NULL) { HttpUrlFreeParser (UrlParser); } =20 return Status; =20 --=20 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel