From nobody Mon Dec 23 14:23:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1515389341447460.95684035149316; Sun, 7 Jan 2018 21:29:01 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B1224222CB31E; Sun, 7 Jan 2018 21:23:50 -0800 (PST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0081.outbound.protection.outlook.com [104.47.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B5EF222A54D8 for ; Sun, 7 Jan 2018 21:23:48 -0800 (PST) Received: from CY4PR03CA0091.namprd03.prod.outlook.com (10.171.242.160) by DM5SPR00MB106.namprd03.prod.outlook.com (10.174.178.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.7; Mon, 8 Jan 2018 05:28:56 +0000 Received: from BY2FFO11OLC004.protection.gbl (2a01:111:f400:7c0c::185) by CY4PR03CA0091.outlook.office365.com (2603:10b6:910:4d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Mon, 8 Jan 2018 05:28:56 +0000 Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC004.mail.protection.outlook.com (10.1.15.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Mon, 8 Jan 2018 05:28:26 +0000 Received: from uefi-OptiPlex-790.ap.freescale.net (uefi-OptiPlex-790.ap.freescale.net [10.232.132.78]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w085Smjl007922; Sun, 7 Jan 2018 22:28:53 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.41.81; helo=nam03-dm3-obe.outbound.protection.outlook.com; envelope-from=meenakshi.aggarwal@nxp.com; receiver=edk2-devel@lists.01.org Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; From: Meenakshi Aggarwal To: , , , , Date: Mon, 8 Jan 2018 16:46:48 +0530 Message-ID: <1515410208-14559-2-git-send-email-meenakshi.aggarwal@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1515410208-14559-1-git-send-email-meenakshi.aggarwal@nxp.com> References: <1515410208-14559-1-git-send-email-meenakshi.aggarwal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131598629068908104; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(39380400002)(396003)(2980300002)(1110001)(1109001)(339900001)(50944005)(189003)(199004)(8656006)(97736004)(48376002)(50466002)(106466001)(68736007)(6666003)(5660300001)(2950100002)(50226002)(4326008)(59450400001)(498600001)(77096006)(53936002)(2201001)(110136005)(305945005)(51416003)(16586007)(86362001)(575784001)(81156014)(104016004)(36756003)(105606002)(2906002)(76176011)(81166006)(8936002)(8676002)(47776003)(316002)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5SPR00MB106; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC004; 1:INkat1IC7CB2IWlCWTbQRszWlhjhSE2eX8tjjKFCOVrYR7URQKElJt0H3hrpC1MD7ptN6+/MbqOkT07UCSivdKGAqXiML0HUivfY5ULaXIa15GLoUaKBwGgFngrE7A5E MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d39d14d-79e3-41cb-a648-08d55658a50b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:DM5SPR00MB106; X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB106; 3:9w+8aM7DHgJPKsdqZunSOadPY2ueNFswgToYSNhu4cWSUanuKdAILKj9VEcbKXNeD/pddLl0Qf2rzZTIpyA3pXlMGcwpsWZ1SLAQPbrVFHRbHvSdjCu5vEey0lEcXaWKDgpWHuMoAwkxyoESHDIRvWsinr3rtGesCeI1fSo10ngsw7ojLLr7j3n+TMwcW1PDPLXdWiX7XdOFmCGlYjn+BpkmdDGKZjteJ+Wz5MeUIJmDzYlICjnyyZ8Z9VoyloDFunSjXbPADevfdsTYghn2ToEQdwFiLu5026m54E9b7KXxEYTFaqVDs/8uhjE9gahkAqlh8fO81T9xXrg9awUmP57+LKW3xtlvTsnmaWIFMVU=; 25:/mAbxUKG0ZXUhWGorPudC8IiMSkGViBMFlkKgJMVDJsaeFpHTsLWDrymCFzS0Tgy9zne3WVr2c3+kprbQyvo0fBKswzgtw8niZaq7AicHyE9Q/Dm+NH/BwnevG62fkmxByxS2sKq1N2Z7kw5mvkR3rx4TDDpNm+/DnvF7CDh2DR9MoXq6VzAhzlvRlKyDf2mU1ovbQDEYV069v4n4LEfhZhjKJdX9jAjrh0jYRA2A8vMjj7lfJuZrBbJUnmldl/5NlJ0gYdow3hNmriTaWrF23JuVCxKDvL7PZTSuZIlip3dpB28vrzNrL+vSYURmPTkoxAEpTTah3d4Bkb9xPDmag== X-MS-TrafficTypeDiagnostic: DM5SPR00MB106: X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB106; 31:Y6ObUAHdmHZGIz80a8vdIPisgfwdakQMyTJUrRdxmkilGB9VPioyMOwgThx8J92VqMZoKi+cwMKoml15fiUITojDiuXuCOmQ3+QU5W/RtCdHnq0pQfheNmFZXcQ+O4k6cBJowG+kgm/HLTG5cdoxntyl9jX2g+uw0QBR43lamCgE1NqWt9JtKQLf53Sg+qK2PK+XhzDc3KFJOwoyjElLenRURKsVW0R5Ok9Ok8qVdCo=; 4:lPqVFnNOrgEwY1n+1ogALRZM0QL7rG05vgOhPIEvqOuAfi4SZWaaaawlHJZMz5i2oihkX7OWcHQKjxamGWFOFnRJz6y/wLuJI7ufT2KRNPQ5ClQ+Pt9XSuarVUaxAboWL6FFpNBctD7WWiRy6+wiux2LtQRvILkbmA3Ppuj6KpqfAh31Cv17+n19o5nbsUQ0jGTCjfzFezfo2iW7AXOfDx1NzPB42D46Xq2bIcebif4BO5lM5eHc4zzLJZIRWbFjiABLHZMYgPakZrA9rPFcIK2apO/E8DjnlHTi5iV+cBmqNIngApAHHsVKc8Nd1Mpm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(944510075)(944921075)(946801075)(946901075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123556025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123561025)(20161123563025)(201708071742011); SRVR:DM5SPR00MB106; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:DM5SPR00MB106; X-Forefront-PRVS: 054642504A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5SPR00MB106; 23:Osy8JVqzSmqZ/BDw7vHj3PANsFUruutAqU8rc2EZf?= =?us-ascii?Q?N4qW1slnrxCGB5JmkLYAdLy2KuzPpwXpbw83K9hrou7n1JdV1HM0lX5bl6l1?= =?us-ascii?Q?I+ol0SFfKF7E9SLn50mQpgTqK2PvVhGVLd2mz6i8zhSIVMslP6tzmKHK7OAp?= =?us-ascii?Q?ALw/Vlo/7ZOyslUt7awS1UbIzP+JpiV6z8AyLJKm3WGgNscNp8nGnkU9h6W3?= =?us-ascii?Q?w3Lif064kC+OGHFa/j8gLy3JPIry8vqeJCBnevk5XAo75Rkhr4FVbptgqyFO?= =?us-ascii?Q?q3QWoYspGbp4juk/P+vbImwS65WJ+/u9dJtX2dG8X1Tu8WMXBbksbi0RgqpK?= =?us-ascii?Q?PadAjZI3SRoU36pQl+zuHBLNWtL2CRZu25FY/LaN6yT+HdZv9Mjrb04NVARV?= =?us-ascii?Q?lsU0C1bRr1BQiY3khEexgGx8Vz26B4Ow9eB/LyXpQSOwAdlDtqaWHBc+LgfX?= =?us-ascii?Q?FFyEI3BXwcuVivvaet9I5OS7Cz2eaXNiueFkMOiW8Cjp6syW2VWMOE/LbVGj?= =?us-ascii?Q?i+d+aE8s1NLKM8LLCFVd8ReDPrIzXIcF9d7VihFx8aeAA1ULBVa5TUcmXZf2?= =?us-ascii?Q?/+pDSvP288BYZ+bHnl2GTFEXUUU75W2unEE1yAEYdQ4F1Jc9fR2d1LGGFqPe?= =?us-ascii?Q?jUmHGnQn8+HO/XwJwcRezLTs30USg4qHce8iRJpp7Nqklo8jcu3Yg7CuoryE?= =?us-ascii?Q?G+qprzJdMfQoyt083YvNudJQ+G+BWwicxpEPY87AG8ApgmGPHbvBt8XT19OL?= =?us-ascii?Q?QUwxaZ/KTqMPLVtekr5XjnsNSC7GTOl/JTI3jvqyamWbJ9kyrCqD9NYfQqd1?= =?us-ascii?Q?h5DYGKtd0/gxBoxFGOkTGCMx6HvyPSuoCqTFLmG2SahjJkxBS9KuRH+DTgKN?= =?us-ascii?Q?qdJqWx+Zg9nI6h39a7nPiklnOA3+hlhGmHjX6RJXGJkqUsALLAWfLPNnVJJE?= =?us-ascii?Q?3/VuKq1iPRGRHF/DNBO64yglSAhfmqWAUg8qONdo0J3o+2k2tyNWSvLIHSaH?= =?us-ascii?Q?khyn0bA+I0FCUEAqzsASQUA+uNFrPAMd8DGW4rCKwgTTZPU3p50hxKL3kgfr?= =?us-ascii?Q?knFrTKNG4IBuNe1TLofWYGYias4TuRhr81BRJn6+HaTgZRJcA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB106; 6:JzGJRKNoBM3nTecUnL42WWVk939AiXXPK5Fi8vibp3Qd2vlXSJRjkcvtFakuLERYhTrs4aHbLuq6hW6hrVNdZJyH6FK1Hnj0IwRf2EECDWHS0C+tcliEKCawQvO4DNbaJyri9aqDnvyFyTTFeu6Jo6oUmYcRAZUMhx220nb9tIBtMRZYa0MC/nGyXihM/lwqHPGVLpKwHZUC6QCmfFURhWt/EE+RITW6AeZlovcrvaDTK23eSW2j3R+5IlA7f/kJDRqxfFLuZg/dQ0ss3IPQvAsK+VIRKqdV364uwDVFSH9p8ib32WUFwIxOgXAw93vKyZmMlyj9gJN4zhyOJ1kQLf4mJ8BTnFz4SnmkTBIG4Ig=; 5:4tlCuQzuI7nyLXGfnSojaZ5dVWnCjITC7zr4ivPWDa3QPqHuX9kretZCHT6ouPcTtKUpI/YTPFSvnhqRhPwRZbN+sUlQDM44tazdKZvpUDVhpptxns5rSGd6EY7ktX7GnsF/Yqx6rfx1V8xDzVnig75ztp2Rw/RKc51/QIGg8AY=; 24:9WyRgNR3PaK4AVJiycjS4ir20m2QOlW2QdWADljilOrHs9RGqzw5eoBjbkuAlPYjgH+ymtl8z9M0muJm0kMFsymhRzNSmdrPakqidQ4POEk=; 7:8iHQuBX5YKfD7CAaDuyMtDtUNVXME9e3QrSStqOQNLVCVGe7IOVHc/dZ49HWoNl8E3OA6GBdEspb+IqawmrecdpBVVmRiHSncky745rw1nhigdOJYg4p/TGIwMBKZEfKNaqrKnnQQXUP5jEs6/oRmxW/emG4iW+DWy65ttw0qVqMACdB2+6E7ZTlH/Y/GAwbI0jgt4Z7gPQ1rvrxEyfRNzKCmcVx37IQ6zE/mc+SU9VvgVWQU9rjaiso3N+22NzT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 05:28:26.6880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d39d14d-79e3-41cb-a648-08d55658a50b X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5SPR00MB106 Subject: [edk2] [RFC] SATA : Implemented NXP errata A008402 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Description: Commands with 4 MB PRD length entries fail if PRD[DBC] is set to the value according to AHCI standard spec. Due to a logic error, 3F_FFFFh is misinterpreted by the device as zero length. Workaround: Set PRD length to 0 when creating a PRD entry for a maximum data transfer size of 4 MB to fix the erratum. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Meenakshi Aggarwal --- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 2 +- MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf | 1 + MdeModulePkg/MdeModulePkg.dec | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePk= g/Bus/Ata/AtaAtapiPassThru/AhciMode.c index e6de5d6..fb6dc0b 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c @@ -591,7 +591,7 @@ AhciBuildCommand ( if (RemainedData < EFI_AHCI_MAX_DATA_PER_PRDT) { AhciRegisters->AhciCommandTable->PrdtTable[PrdtIndex].AhciPrdtDbc = =3D (UINT32)RemainedData - 1; } else { - AhciRegisters->AhciCommandTable->PrdtTable[PrdtIndex].AhciPrdtDbc = =3D EFI_AHCI_MAX_DATA_PER_PRDT - 1; + AhciRegisters->AhciCommandTable->PrdtTable[PrdtIndex].AhciPrdtDbc = =3D PcdGet32 (PcdPrdtMaxDataLength); } =20 Data64.Uint64 =3D (UINT64)MemAddr; diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf b/M= deModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf index 82d5f7a..8921dd5 100644 --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf @@ -70,6 +70,7 @@ =20 [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable ## SOMETIMES_CONSUMES + gEfiMdeModulePkgTokenSpaceGuid.PcdPrdtMaxDataLength =20 # [Event] # EVENT_TYPE_PERIODIC_TIMER ## SOMETIMES_CONSUMES diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 8efad57..b2f9f2b 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -1434,6 +1434,9 @@ # @Prompt Console Output Row of Text Setup gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x4000000e =20 + ## This PCD specifies the Maximum data length for a PRD Entry + gEfiMdeModulePkgTokenSpaceGuid.PcdPrdtMaxDataLength|0x3FFFFF|UINT32|0x40= 00000f + [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] ## UART clock frequency is for the baud rate configuration. # @Prompt Serial Port Clock Rate. --=20 1.9.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel