1. Patchew
  2. EDK2
  3. View series

[edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

Liming Gao posted 1 patch 6 years, 10 months ago
Failed in applying to current master (apply log)
MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Posted by Liming Gao 6 years, 10 months ago 
In SafeUintnToChar8(), update its output parameter name.
Update pui8Result --> Result to match its library implementation

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/MdePkg/Include/Library/SafeIntLib.h b/MdePkg/Include/Library/SafeIntLib.h
index 5839301..8c5003f 100644
--- a/MdePkg/Include/Library/SafeIntLib.h
+++ b/MdePkg/Include/Library/SafeIntLib.h
@@ -375,7 +375,7 @@ RETURN_STATUS
 EFIAPI
 SafeInt16ToUint8 (
   IN INT16 Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
@@ -564,7 +564,7 @@ RETURN_STATUS
 EFIAPI
 SafeUint16ToUint8 (
   IN UINT16 Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
@@ -672,7 +672,7 @@ RETURN_STATUS
 EFIAPI
 SafeInt32ToUint8 (
   IN INT32 Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
@@ -889,7 +889,7 @@ RETURN_STATUS
 EFIAPI
 SafeUint32ToUint8 (
   IN UINT32 Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
@@ -1078,7 +1078,7 @@ RETURN_STATUS
 EFIAPI
 SafeIntnToUint8 (
   IN INTN Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
@@ -1321,7 +1321,7 @@ RETURN_STATUS
 EFIAPI
 SafeUintnToUint8 (
   IN UINTN Operand,
-  OUT UINT8 *pui8Result
+  OUT UINT8 *Result
   );
 
 /**
-- 
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Posted by Laszlo Ersek 6 years, 10 months ago 
On 01/31/18 13:27, Liming Gao wrote:
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library implementation
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/SafeIntLib.h b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt16ToUint8 (
>    IN INT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint16ToUint8 (
>    IN UINT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt32ToUint8 (
>    IN INT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint32ToUint8 (
>    IN UINT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeIntnToUint8 (
>    IN INTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUintnToUint8 (
>    IN UINTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Posted by Kinney, Michael D 6 years, 10 months ago 
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org]
> On Behalf Of Liming Gao
> Sent: Wednesday, January 31, 2018 4:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] MdePkg SafeIntLib: Update API
> definition to use the same output name
> 
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library
> implementation
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/SafeIntLib.h
> b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt16ToUint8 (
>    IN INT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint16ToUint8 (
>    IN UINT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt32ToUint8 (
>    IN INT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint32ToUint8 (
>    IN UINT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeIntnToUint8 (
>    IN INTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUintnToUint8 (
>    IN UINTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
> 
>  /**
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Posted by Bret Barkelew 6 years, 9 months ago 
Reviewed-By: Bret Barkelew Bret.Barkelew@microsoft.com

- Bret

From: Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Sent: Wednesday, January 31, 2018 11:29 AM
To: Gao, Liming<mailto:liming.gao@intel.com>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Subject: Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org]
> On Behalf Of Liming Gao
> Sent: Wednesday, January 31, 2018 4:27 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] MdePkg SafeIntLib: Update API
> definition to use the same output name
>
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library
> implementation
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/MdePkg/Include/Library/SafeIntLib.h
> b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt16ToUint8 (
>    IN INT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint16ToUint8 (
>    IN UINT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt32ToUint8 (
>    IN INT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint32ToUint8 (
>    IN UINT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeIntnToUint8 (
>    IN INTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUintnToUint8 (
>    IN UINTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>
>  /**
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C5b2fcf3c266945233cd708d568e0ed61%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636530237637093084&sdata=tJVkaZk%2BKBaoBhkfYmPwL9YgId2FniXqd8l7v0ApjUs%3D&reserved=0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C5b2fcf3c266945233cd708d568e0ed61%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636530237637093084&sdata=tJVkaZk%2BKBaoBhkfYmPwL9YgId2FniXqd8l7v0ApjUs%3D&reserved=0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.