NetworkPkg: Support the platform to configure HTTPS CipherList.

[edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Jiaxin Wu 6 years, 10 months ago

V2:
* Rename the file/variable name.
* Refine the error handling returned from GetVariable.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Kinney Michael D <michael.d.kinney@intel.com>
Cc: Zimmer Vincent <vincent.zimmer@intel.com>
Cc: Yao Jiewen <jiewen.yao@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (2):
  NetworkPkg: Define one private variable for HTTPS to set Tls
    CipherList.
  NetworkPkg: Read HttpTlsCipherList variable and configure it for HTTPS
    session.

 NetworkPkg/HttpDxe/HttpDriver.h             |  3 +-
 NetworkPkg/HttpDxe/HttpDxe.inf              |  3 +-
 NetworkPkg/HttpDxe/HttpsSupport.c           | 92 ++++++++++++++++++++++++++++-
 NetworkPkg/Include/Guid/HttpTlsCipherList.h | 38 ++++++++++++
 NetworkPkg/NetworkPkg.dec                   |  3 +
 5 files changed, 136 insertions(+), 3 deletions(-)
 create mode 100644 NetworkPkg/Include/Guid/HttpTlsCipherList.h

-- 
1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Wu, Jiaxin 6 years, 10 months ago

Hi Laszlo, 

Can you help to report one Bugzilla for the new feature request? It's better to describe the reason why we need support in Bugzilla.

Thanks,
Jiaxin  



> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Sunday, February 11, 2018 11:15 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Zimmer, Vincent
> <vincent.zimmer@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ye,
> Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>
> Subject: [PATCH v2 0/2] NetworkPkg: Support the platform to configure
> HTTPS CipherList.
> 
> V2:
> * Rename the file/variable name.
> * Refine the error handling returned from GetVariable.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Kinney Michael D <michael.d.kinney@intel.com>
> Cc: Zimmer Vincent <vincent.zimmer@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (2):
>   NetworkPkg: Define one private variable for HTTPS to set Tls
>     CipherList.
>   NetworkPkg: Read HttpTlsCipherList variable and configure it for HTTPS
>     session.
> 
>  NetworkPkg/HttpDxe/HttpDriver.h             |  3 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf              |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c           | 92
> ++++++++++++++++++++++++++++-
>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 38 ++++++++++++
>  NetworkPkg/NetworkPkg.dec                   |  3 +
>  5 files changed, 136 insertions(+), 3 deletions(-)
>  create mode 100644 NetworkPkg/Include/Guid/HttpTlsCipherList.h
> 
> --
> 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Laszlo Ersek 6 years, 10 months ago

Hi Jiaxin,

On 02/11/18 04:21, Wu, Jiaxin wrote:
> Hi Laszlo, 
> 
> Can you help to report one Bugzilla for the new feature request? It's better to describe the reason why we need support in Bugzilla.

I've filed <https://bugzilla.tianocore.org/show_bug.cgi?id=875>. Thank
you for the patches!

Laszlo

> 
>> -----Original Message-----
>> From: Wu, Jiaxin
>> Sent: Sunday, February 11, 2018 11:15 AM
>> To: edk2-devel@lists.01.org
>> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Zimmer, Vincent
>> <vincent.zimmer@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ye,
>> Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
>> <jiaxin.wu@intel.com>
>> Subject: [PATCH v2 0/2] NetworkPkg: Support the platform to configure
>> HTTPS CipherList.
>>
>> V2:
>> * Rename the file/variable name.
>> * Refine the error handling returned from GetVariable.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Kinney Michael D <michael.d.kinney@intel.com>
>> Cc: Zimmer Vincent <vincent.zimmer@intel.com>
>> Cc: Yao Jiewen <jiewen.yao@intel.com>
>> Cc: Ye Ting <ting.ye@intel.com>
>> Cc: Fu Siyuan <siyuan.fu@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
>>
>> Jiaxin Wu (2):
>>   NetworkPkg: Define one private variable for HTTPS to set Tls
>>     CipherList.
>>   NetworkPkg: Read HttpTlsCipherList variable and configure it for HTTPS
>>     session.
>>
>>  NetworkPkg/HttpDxe/HttpDriver.h             |  3 +-
>>  NetworkPkg/HttpDxe/HttpDxe.inf              |  3 +-
>>  NetworkPkg/HttpDxe/HttpsSupport.c           | 92
>> ++++++++++++++++++++++++++++-
>>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 38 ++++++++++++
>>  NetworkPkg/NetworkPkg.dec                   |  3 +
>>  5 files changed, 136 insertions(+), 3 deletions(-)
>>  create mode 100644 NetworkPkg/Include/Guid/HttpTlsCipherList.h
>>
>> --
>> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Wu, Jiaxin 6 years, 10 months ago

Thanks Laszlo.

If no other comments, I will commit this patch by the end of today.

Best Regards!
Jiaxin

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, February 13, 2018 3:56 AM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Zimmer, Vincent
> <vincent.zimmer@intel.com>
> Subject: Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to
> configure HTTPS CipherList.
> 
> Hi Jiaxin,
> 
> On 02/11/18 04:21, Wu, Jiaxin wrote:
> > Hi Laszlo,
> >
> > Can you help to report one Bugzilla for the new feature request? It's better
> to describe the reason why we need support in Bugzilla.
> 
> I've filed <https://bugzilla.tianocore.org/show_bug.cgi?id=875>. Thank
> you for the patches!
> 
> Laszlo
> 
> >
> >> -----Original Message-----
> >> From: Wu, Jiaxin
> >> Sent: Sunday, February 11, 2018 11:15 AM
> >> To: edk2-devel@lists.01.org
> >> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
> >> <michael.d.kinney@intel.com>; Zimmer, Vincent
> >> <vincent.zimmer@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ye,
> >> Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin
> >> <jiaxin.wu@intel.com>
> >> Subject: [PATCH v2 0/2] NetworkPkg: Support the platform to configure
> >> HTTPS CipherList.
> >>
> >> V2:
> >> * Rename the file/variable name.
> >> * Refine the error handling returned from GetVariable.
> >>
> >> Cc: Laszlo Ersek <lersek@redhat.com>
> >> Cc: Kinney Michael D <michael.d.kinney@intel.com>
> >> Cc: Zimmer Vincent <vincent.zimmer@intel.com>
> >> Cc: Yao Jiewen <jiewen.yao@intel.com>
> >> Cc: Ye Ting <ting.ye@intel.com>
> >> Cc: Fu Siyuan <siyuan.fu@intel.com>
> >> Contributed-under: TianoCore Contribution Agreement 1.0
> >> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> >>
> >> Jiaxin Wu (2):
> >>   NetworkPkg: Define one private variable for HTTPS to set Tls
> >>     CipherList.
> >>   NetworkPkg: Read HttpTlsCipherList variable and configure it for HTTPS
> >>     session.
> >>
> >>  NetworkPkg/HttpDxe/HttpDriver.h             |  3 +-
> >>  NetworkPkg/HttpDxe/HttpDxe.inf              |  3 +-
> >>  NetworkPkg/HttpDxe/HttpsSupport.c           | 92
> >> ++++++++++++++++++++++++++++-
> >>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 38 ++++++++++++
> >>  NetworkPkg/NetworkPkg.dec                   |  3 +
> >>  5 files changed, 136 insertions(+), 3 deletions(-)
> >>  create mode 100644 NetworkPkg/Include/Guid/HttpTlsCipherList.h
> >>
> >> --
> >> 1.9.5.msysgit.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> >
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Laszlo Ersek 6 years, 10 months ago

Hi Jiaxin,

On 02/13/18 03:01, Wu, Jiaxin wrote:
> Thanks Laszlo.
> 
> If no other comments, I will commit this patch by the end of today.

Thank you again for the patches. I have a workflow-related request:
please do not add my "Reviewed-by" to patches for which I didn't post a
"Reviewed-by" *verbatim* to the mailing list. I'm thankful to you for
both the discussion and for the implementation. However, I didn't do a
meticulous review for these patches, and therefore a Reviewed-by in my
name does not match reality; it mis-represents my participation.

There's nothing do about commits e34914db193f and 7ff68b5edc9f now; I'm
just asking for a more careful handling of Reviewed-by tags in the future.

Thank you!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] NetworkPkg: Support the platform to configure HTTPS CipherList.

Posted by Fu, Siyuan 6 years, 10 months ago

Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>

> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Sunday, February 11, 2018 11:15 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Zimmer, Vincent <vincent.zimmer@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Ye, Ting <ting.ye@intel.com>; Fu,
> Siyuan <siyuan.fu@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
> Subject: [PATCH v2 0/2] NetworkPkg: Support the platform to configure
> HTTPS CipherList.
> 
> V2:
> * Rename the file/variable name.
> * Refine the error handling returned from GetVariable.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Kinney Michael D <michael.d.kinney@intel.com>
> Cc: Zimmer Vincent <vincent.zimmer@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> 
> Jiaxin Wu (2):
>   NetworkPkg: Define one private variable for HTTPS to set Tls
>     CipherList.
>   NetworkPkg: Read HttpTlsCipherList variable and configure it for HTTPS
>     session.
> 
>  NetworkPkg/HttpDxe/HttpDriver.h             |  3 +-
>  NetworkPkg/HttpDxe/HttpDxe.inf              |  3 +-
>  NetworkPkg/HttpDxe/HttpsSupport.c           | 92
> ++++++++++++++++++++++++++++-
>  NetworkPkg/Include/Guid/HttpTlsCipherList.h | 38 ++++++++++++
>  NetworkPkg/NetworkPkg.dec                   |  3 +
>  5 files changed, 136 insertions(+), 3 deletions(-)
>  create mode 100644 NetworkPkg/Include/Guid/HttpTlsCipherList.h
> 
> --
> 1.9.5.msysgit.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel