BaseTools: Add WindowsLike path in front of PATH Env

[edk2] [Patch] BaseTools: Add WindowsLike path in front of PATH Env

Posted by Yonghong Zhu 6 years, 10 months ago

Original BaseTools source build append WindowsLike path to PATH Env,
while WINDDK installation has a "build.exe", if user place WINDDK
folder to PATH either during WINDDK installation or manually, it will
block the BaseTools' build.bat.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/toolsetup.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 51c2760..562f993 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -315,11 +315,11 @@ goto end
   if not defined PYTHON_FREEZER_PATH (
     echo.
     echo !!! WARNING !!! PYTHON_FREEZER_PATH environment variable is not set.
     echo Setup environment to run Python scripts directly.
     echo.
-    set "PATH=%PATH%;%BASE_TOOLS_PATH%\BinWrappers\WindowsLike"
+    set "PATH=%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%"
   )
 
   set BASETOOLS_PYTHON_SOURCE=%BASE_TOOLS_PATH%\Source\Python
   set PYTHONPATH=%BASETOOLS_PYTHON_SOURCE%;%PYTHONPATH%
   
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Add WindowsLike path in front of PATH Env

Posted by Gao, Liming 6 years, 10 months ago

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Thursday, February 22, 2018 10:32 AM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Add WindowsLike path in front of PATH Env
>
>Original BaseTools source build append WindowsLike path to PATH Env,
>while WINDDK installation has a "build.exe", if user place WINDDK
>folder to PATH either during WINDDK installation or manually, it will
>block the BaseTools' build.bat.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/toolsetup.bat | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
>index 51c2760..562f993 100755
>--- a/BaseTools/toolsetup.bat
>+++ b/BaseTools/toolsetup.bat
>@@ -315,11 +315,11 @@ goto end
>   if not defined PYTHON_FREEZER_PATH (
>     echo.
>     echo !!! WARNING !!! PYTHON_FREEZER_PATH environment variable is not
>set.
>     echo Setup environment to run Python scripts directly.
>     echo.
>-    set "PATH=%PATH%;%BASE_TOOLS_PATH%\BinWrappers\WindowsLike"
>+    set "PATH=%BASE_TOOLS_PATH%\BinWrappers\WindowsLike;%PATH%"
>   )
>
>   set BASETOOLS_PYTHON_SOURCE=%BASE_TOOLS_PATH%\Source\Python
>   set PYTHONPATH=%BASETOOLS_PYTHON_SOURCE%;%PYTHONPATH%
>
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel