From nobody Mon Dec 23 05:29:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1521086473404325.43622525633873; Wed, 14 Mar 2018 21:01:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id F0BFD2095606B; Wed, 14 Mar 2018 20:54:45 -0700 (PDT) Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BD91620956064 for ; Wed, 14 Mar 2018 20:54:44 -0700 (PDT) Received: by mail-pl0-x244.google.com with SMTP id ay1-v6so3017941plb.7 for ; Wed, 14 Mar 2018 21:01:08 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id e4sm8107785pfa.166.2018.03.14.21.01.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 21:01:05 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rhviWW23udxmj5gdM/D8sUe3FXKlLK7DSnq5kj3vWis=; b=PL3G5DfS9e/gJenyArbVHrbmpGJRWiE5OsHXJH8Rm5FShzfnz7hGaoQhlr0YO8EUKq dHKr82sbEhUtPtRfQ0RE9epSBgk9WxpS9E3OBGzbxh6UQq+U7rbq0DTMj8pH/brOUK4A adapIuXc9emKwpOAOCKHxmkZ5sYOAFos4MaQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rhviWW23udxmj5gdM/D8sUe3FXKlLK7DSnq5kj3vWis=; b=WpwozYfb2tmKZYk1v00m7JilAdCHmZ7bmpgIT2LTCj+9ikNcdoqzU6PYtwvvODyS0B ki6DXer7Uu7UtqeC+BlKadfpx4SNVpSGgtwGW89ab2Z+JMFKxSKrzDZdFzSpMR0DaqhO usKLo8avel6+RcUV64R1c1bEy8hnn9iX2GSgofeV/sLjFp4E6AbzorvXwxWfozzxWILN Bwy2QDvjDY/Z1S3nWA/1Gm3ACwgqvGn8ytr8LwJ9i2+dLhsT00ZljOhsLGnlJ+917SEM Rtf6DlovObApvimC2aWlOH6yHEW2XRVUhvSCDJBu/CIaFr1G/h5VIBa5DNfxvIoOTNh+ Ddpw== X-Gm-Message-State: AElRT7GEzBNSofGpTw4X6q2WGkH9nJRjrmpqgW14hqVARk79mrL7ikJf rwEOOqlLFqowh7Ks/K6qCG/DhWEHaKI= X-Google-Smtp-Source: AG47ELuvg61///CC0s+4vnbtL/mNwYSvsvPAHKfKkEB6ML7Hmtc8iKqgMaHlGjF32I8d/xGeWeY9og== X-Received: by 2002:a17:902:f81:: with SMTP id 1-v6mr6420289plz.265.1521086466451; Wed, 14 Mar 2018 21:01:06 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Thu, 15 Mar 2018 12:00:24 +0800 Message-Id: <1521086424-113954-7-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> References: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> Subject: [edk2] [PATCH v6 6/6] MdeModulePkg/PciBus: return CPU address for GetBarAttributes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Yi Li , Eric Dong , Ard Biesheuvel , Heyi Guo , Michael D Kinney , Laszlo Ersek , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" According to UEFI spec 2.7, PciIo->GetBarAttributes should return host address (CPU view ddress) rather than device address (PCI view address), and device address =3D host address + address translation offset, so we subtract translation from device address before returning. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo Signed-off-by: Yi Li Cc: Ruiyu Ni Cc: Ard Biesheuvel Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Michael D Kinney --- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c b/MdeModulePkg/Bus/Pci/= PciBusDxe/PciIo.c index fef3eceb7f62..62179eb44bbd 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c @@ -1972,6 +1972,10 @@ PciIoGetBarAttributes ( return EFI_UNSUPPORTED; } } + + // According to UEFI spec 2.7, we need return host address for + // PciIo->GetBarAttributes, and host address =3D device address - tran= slation. + Descriptor->AddrRangeMin -=3D Descriptor->AddrTranslationOffset; } =20 return EFI_SUCCESS; --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel