BaseTools: compare GUID value should not case-sensitive

[edk2] [Patch] BaseTools: compare GUID value should not case-sensitive

Posted by Yonghong Zhu 7 years, 10 months ago

From: Bin Wang <binx.a.wang@intel.com>

build report error when the same Guid value in FDF file use lowercase,
in tools_def.txt file use uppercase.
The guid value's compare should not case-sensitive.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bin Wang <binx.a.wang@intel.com>
---
 BaseTools/Source/Python/GenFds/GenFds.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/GenFds.py b/BaseTools/Source/Python/GenFds/GenFds.py
index 03126e3..26122fc 100644
--- a/BaseTools/Source/Python/GenFds/GenFds.py
+++ b/BaseTools/Source/Python/GenFds/GenFds.py
@@ -397,11 +397,11 @@ def FindExtendTool(KeyStringList, CurrentArchList, NameGuid):
     ToolOption = None
     ToolPathKey = None
     ToolOptionKey = None
     KeyList = None
     for ToolDef in ToolDefinition.items():
-        if NameGuid == ToolDef[1]:
+        if NameGuid.lower() == ToolDef[1].lower() :
             KeyList = ToolDef[0].split('_')
             Key = KeyList[0] + \
                   '_' + \
                   KeyList[1] + \
                   '_' + \
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: compare GUID value should not case-sensitive

Posted by Zhu, Yonghong 7 years, 10 months ago

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yonghong Zhu
Sent: Wednesday, March 28, 2018 2:26 PM
To: edk2-devel@lists.01.org
Cc: Wang, BinX A <binx.a.wang@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2] [Patch] BaseTools: compare GUID value should not case-sensitive

From: Bin Wang <binx.a.wang@intel.com>

build report error when the same Guid value in FDF file use lowercase, in tools_def.txt file use uppercase.
The guid value's compare should not case-sensitive.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bin Wang <binx.a.wang@intel.com>
---
 BaseTools/Source/Python/GenFds/GenFds.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/GenFds.py b/BaseTools/Source/Python/GenFds/GenFds.py
index 03126e3..26122fc 100644
--- a/BaseTools/Source/Python/GenFds/GenFds.py
+++ b/BaseTools/Source/Python/GenFds/GenFds.py
@@ -397,11 +397,11 @@ def FindExtendTool(KeyStringList, CurrentArchList, NameGuid):
     ToolOption = None
     ToolPathKey = None
     ToolOptionKey = None
     KeyList = None
     for ToolDef in ToolDefinition.items():
-        if NameGuid == ToolDef[1]:
+        if NameGuid.lower() == ToolDef[1].lower() :
             KeyList = ToolDef[0].split('_')
             Key = KeyList[0] + \
                   '_' + \
                   KeyList[1] + \
                   '_' + \
--
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel