[edk2] [Patch] BaseTools: Correct the variable name

Yonghong Zhu posted 1 patch 5 years, 10 months ago
Failed in applying to current master (apply log)
BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2] [Patch] BaseTools: Correct the variable name
Posted by Yonghong Zhu 5 years, 10 months ago
the commit bff74750 introduce a undefined variable name 'scope' cause build
failure, it should use 'Scope'.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
index 223b453..8a9296c 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -1133,11 +1133,11 @@ class FdfParser:
             return False
 
     @staticmethod
     def __Verify(Name, Value, Scope):
         # value verification only applies to numeric values.
-        if scope not in TAB_PCD_NUMERIC_TYPES:
+        if Scope not in TAB_PCD_NUMERIC_TYPES:
             return
 
         ValueNumber = 0
         try:
             ValueNumber = int(Value, 0)
-- 
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [Patch] BaseTools: Correct the variable name
Posted by Gao, Liming 5 years, 10 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Yonghong Zhu
>Sent: Monday, May 07, 2018 2:04 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [Patch] BaseTools: Correct the variable name
>
>the commit bff74750 introduce a undefined variable name 'scope' cause build
>failure, it should use 'Scope'.
>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
>---
> BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py
>b/BaseTools/Source/Python/GenFds/FdfParser.py
>index 223b453..8a9296c 100644
>--- a/BaseTools/Source/Python/GenFds/FdfParser.py
>+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
>@@ -1133,11 +1133,11 @@ class FdfParser:
>             return False
>
>     @staticmethod
>     def __Verify(Name, Value, Scope):
>         # value verification only applies to numeric values.
>-        if scope not in TAB_PCD_NUMERIC_TYPES:
>+        if Scope not in TAB_PCD_NUMERIC_TYPES:
>             return
>
>         ValueNumber = 0
>         try:
>             ValueNumber = int(Value, 0)
>--
>2.6.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel