From nobody Sat May 4 12:08:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1528920696001346.6474887263745; Wed, 13 Jun 2018 13:11:36 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4A53621199B1D; Wed, 13 Jun 2018 13:11:35 -0700 (PDT) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0042.outbound.protection.outlook.com [104.47.40.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CA96F2119174F for ; Wed, 13 Jun 2018 13:11:34 -0700 (PDT) Received: from leduran-Precision-WorkStation-T5400.amd.com (165.204.77.1) by BN6PR12MB1811.namprd12.prod.outlook.com (2603:10b6:404:107::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Wed, 13 Jun 2018 20:11:32 +0000 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=104.47.40.42; helo=nam03-co1-obe.outbound.protection.outlook.com; envelope-from=leo.duran@amd.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1JoKt+URlpUQk+h1/wFJQlOL2dUhcf6h0Wsof3APb4=; b=PdCbLOvqF6kn0xWHtVB4JhHmuAQTPE3iCLzEQ3PtUiKmr4fg9FgK7S8I8rwq1wJO3Tj4pU95rHV3rSapowEkshtEsiZ3nXGUrKCQMIV0xGm633UyiVQU9HMtDAoheS53Ar+Re3pFoLHiYxYItAUbFQAVzdOhScLHiW98RowEs+Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leo.duran@amd.com; From: Leo Duran To: edk2-devel@lists.01.org Date: Wed, 13 Jun 2018 15:11:14 -0500 Message-Id: <1528920674-24912-2-git-send-email-leo.duran@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528920674-24912-1-git-send-email-leo.duran@amd.com> References: <1528920674-24912-1-git-send-email-leo.duran@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0501CA0008.namprd05.prod.outlook.com (2603:10b6:803:40::21) To BN6PR12MB1811.namprd12.prod.outlook.com (2603:10b6:404:107::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c844e18b-40d4-425f-256f-08d5d169dbcb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN6PR12MB1811; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1811; 3:VXaa1PQ2/dGNKHUsDzDH2DWu0t935NUI8SfjIRECjocVLK2kmmAwOzAkykXTSFdEv2mP3R7vS8k+6oNNjd5UILHvsz0fdFET3DZzuXbgd8Il9ehvogZV88A+MHnaNszEySCVrJeRIRDDCOBokEpF1Lc1OMnzS+ZOiepJYIGhN4Wx6EUFd+qrqNBWZrMDyhCtRlHvjlkuCJoKw84HIA+52BJ126b5mqai/GOuR5meV5hjLjKJV3U4PIEavVdh3j0+; 25:MGxvc6ZJJM/QjoI+tOvYdfmTab22RbJcZxfoqVh0Ktqm+HdxEdUTEoXSbFz0CUBknULQv7kEhVxWW+wH4KdYpQiTlg3HkMb/IGYHaWQS8RDlDdjIcQ53hoE2ZHz7jobjmX1oQ0Xjr7zwoeZboEMiZ7zL/37Dabms8Nmh9hYDIbsqT+kyGDMXtRyuE/8JXoZxueW/ekDvH2QYOUJ3c3EvzCgvVR5mEOKpYVgDw7+6+mX2HlyJT8CHUW0fyVeASWD1x1D+9xYVivZ2YnHrSrwoOUdo6FINGjZnSfqvUJUDqzF64p7L/g/GagNf55cn+qOBj+60LCzSOMcSHrFV5ov5aw==; 31:EjUC6sFkKBO26U7fxNZj22Zzv9A8NHvmvXSUjht3fS/WloAxl0oXqeTAXpnsZIyoafdRvbmhGoJD2eFS7fggSJDPxYiqXnmvXg8zvhF6avHBr8B7sDZ6Mba/1JB7wRvyzpmOyc5UlZ2j8Fb4oMZr/CAsahXTKsNwjFpvWJtELjbgFIMwwQjAIwS1DURFtqYSWrlL7nGtsVNsDgKYZ6IFvskCxAkMrsokJewK2Wm1Q8o= X-MS-TrafficTypeDiagnostic: BN6PR12MB1811: X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1811; 20:RTU9Fhq/ZCgVzdx3b8fdBOPtuevv9pM71NX4BC9pkLJCHHUDV542CLFLIrSqzcq3vbrmP9PXqTdx808qJPfR8ICiiwaKgzD8nEudila1q2ac7uNyVPlmIZRIPWN0GH9yw0BxMxflsUyYT185HrthqjymBB/FPCjwA1d2XApap3yPgn8Vhgnj7Up8655DiB94dwlSP96naNYViSViT+AL4TWyOaPUx9VdOWTdS1urTBHfQZ9t1/4FsZ35HFeiavenkFijGqCMmooCSycNOVgGwrg7+ds9AyBHPadOTmsOrfVc9oX9bubLUm/A9aNK7zvjzjMuYOA1ftBhEq8uSeGQlfDMvRVg7lIcsh2WtNcUYzszdpUzLHX+FnariwWME8+cSKO+v0K4yRfFd+B+ftWGtiArg3Qe6OoSQASNDGY0rcUtdXnFg4gHdyJrUoMCZtyRFsxnuA/21icLzJ6mxzMUuDp2JIBVI9Nh7PiYl61au1R/TwB7kT2QUnvr1PV8pbMQ; 4:8nit94XgvtAPZGqCTx+u8KVCPZwfcFf0OoXLQPqUbbKSMrIE6XziC8M66cbResLNoBVlbAsjj7vjDn1SmhKBLMJ8xEPRmurZXBBcw/zfdzzpBZrgM5W/sTOkrTJKEJr4Wle2x8oc8q/XXbapZHAc9rP6j8QilyxhpXHtcppR/lr30OUtv9At5MV/m8ylzSoPN2eY79CXjHmmskmzThWLMKB0Klbkf57FD44viIoA7Gq2w207gi/vYxbpk7srrRRLQLSMbbIWdqv2vOUE1ZT9pNbKxEBDfTjQOsVbCd/73DJ7RBst1+VEl5cYpfrhqNuWE3zMZX37ZtKxzlYsWTnc2A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201703011903075)(201702281528075)(20161123555045)(201703061421075)(6072148)(201708071742011)(7699016); SRVR:BN6PR12MB1811; BCL:0; PCL:0; RULEID:; SRVR:BN6PR12MB1811; X-Forefront-PRVS: 07025866F6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7966004)(39380400002)(39860400002)(346002)(366004)(376002)(396003)(199004)(189003)(76176011)(5660300001)(44832011)(486006)(476003)(446003)(11346002)(956004)(2616005)(25786009)(508600001)(105586002)(106356001)(53936002)(2361001)(4326008)(53416004)(2906002)(6916009)(50226002)(2351001)(6666003)(51416003)(97736004)(66066001)(47776003)(54906003)(81156014)(7696005)(81166006)(8936002)(48376002)(386003)(50466002)(68736007)(16586007)(36756003)(52116002)(305945005)(6116002)(3846002)(7736002)(26005)(1857600001)(16526019)(6486002)(575784001)(86362001)(316002)(186003)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1811; H:leduran-Precision-WorkStation-T5400.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR12MB1811; 23:2OCcxHGcQINuthMKR8TFM1AsujhJn1b9MMCitYzcr?= =?us-ascii?Q?Q+7jKEuwQHJd9h06iNnf7lkH2bjmA5MFRVa5Ocr32K6st/3zhjmPUgWy/qa4?= =?us-ascii?Q?WgSlMGt96jrhP5RtkwgkT5zkglpFxsRVdRY1X6B2kPKKUGOhvK4A0bfrbNQ8?= =?us-ascii?Q?5IlRqcXN+0MDQdQws+b2hFzeqc1Kr8sAFhwyXo6RnAOcPUEUw3n/kKfLvtA/?= =?us-ascii?Q?Cc6hoEwojyDLuVCUjJHzf8V5n/vGUUQcbFlo9TEyyal/jX7x+MBlnl8VzrrN?= =?us-ascii?Q?nqKRJb6YHw4z2TEDPoteprGZ1eSg7lqQzjgxHdDerszbvDoLaSXcFpKN/056?= =?us-ascii?Q?EtTNSBJaCW2Up2DIXUOZDqJuNhzFgx1DhCTXXK3lIlhjnRHZgF8HfNAFQ7tr?= =?us-ascii?Q?d+7jMll06yHYstwytuxfab+qqfTyDn/i7zDUxp77EVKIrpmLM7BwLC1SXDZd?= =?us-ascii?Q?wXO2pBj+KO0mmc+tocpcVn+J5xmMJXzfq4cvmURUDfxvO2+9YToc7oLu64Sd?= =?us-ascii?Q?QM6lS6e3L7g7ZP20Qk+Tamg9q/sRMVzqreB8ZZUaytgIkkwdwX/jLts7UTVH?= =?us-ascii?Q?dJ3OcxR+GtVlVRLC1Pji5ea/yu9ggENryibcTGY723dOdhK73SB0CbmdqIQd?= =?us-ascii?Q?oKludB6bMUUFtclJG4HCvD/ynoqTiE+PyrAwvc9yXZOmREU+q4NcVJqwwh6o?= =?us-ascii?Q?lcRa9HDahvHcfr4oSt9kAqtucTizs6fCMBF1MzdmuPljorSyXpq73rPB6Pnd?= =?us-ascii?Q?2YAXHDkMNYT0YyLuxMlOml6JTPwPPbFEWFf4/AvXC7p0qmp9l3ERRjyTaujd?= =?us-ascii?Q?M8s4GE9+Tzs9H5iQZMYKXaQNPKxU5VzaRRM8d3q6WLt+DiUTrLpv5ZDpxCVT?= =?us-ascii?Q?tPpaBBE9N6wh7/mcmc53qPNA5hn/xXoG3b5J7RvUibCpZX2mWpi1SXozEpw7?= =?us-ascii?Q?5RlHsKLDLFL2QCCsGFs1xktc7M1C7EwakpKM9QW6qly9ZZ/lgOwi5YMnQ9ZO?= =?us-ascii?Q?iSo/jKCTjS7XDCnJGMHTIpN1qhZWuQ2TXJuNWNtQ0KbLvMkfwkDEjwdF364p?= =?us-ascii?Q?DzivnzM2URj3H3ERxA4ON5ciAa34mczozt66UuaAdp1xWmibPnJh3bLDNN1l?= =?us-ascii?Q?6sara41aPPQIpd7kstRlhmv0XYF6bt3Z51zDeOUlRAewAdk5lOojdpKmUlIf?= =?us-ascii?Q?fHDOM2kiJgdnTwnX44CUBUNHlTvO8sm+Mlczt2NwSZonQQUbDNfd8ShXNd2e?= =?us-ascii?Q?wruJJHbQusnth/h70NQO+u8o0EUjtysPNt5D07N3iZyTzQI0iK0rMRohD7w/?= =?us-ascii?Q?p6R6K7DeJ9+SaBOrZ3o5Ji48t+1uBdSwBMC4SDm6P1j?= X-Microsoft-Antispam-Message-Info: GlsJJ1uZ1W7imj2cymKul5o3dUEuXK3K+fs684Zt6k3fCWCrmn+3wYtSrN54OzB92Ind3hMrrUGUNmd1V7rKcDh5bnfM25FnqnCeNqfMrKPPDYu6cKJULJwLC7cEsDtMXjU6hB16vJvkMmxxdf3P0arRJkBw4sXbP+o6wdqFAQHc1IV83G/ISZxLnRWquoUl X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1811; 6:aCCs0N4tlAP2ljdMp5hcjyS4rtoQ1F6fFTAPsV9QrXMQvGEUQ7iIOjwurxscHKY+CXZlRH+5fBdUfa/0GVkV7tLwvVt+nU1GX0uS+7xlcqdKJEeZndokNhPRyz09nO7isx84wNH4EwVq8Hz9zizA68pvik1niNHUreQnk/J4/Y8ZBeKORVQfEHMSyFDxcd9bklbQUBMGcvHujLYiCLZ/FwAgw2BxmXUhw8Wv52YDwa+hNLMX/xoyLIshRjg4j9ghM1UkxrP8ouGoxG10eduE7177i7D9wM1JlJgKhVifD5sCFDSCtfdO02hxvnhvR+gbBXlO6QGmzhKOoYxCDANiea8bmAJozCyxSK8jbSukKGBSWodMqS4M+i3XlzVO6VlHvCt0mAqlhapZxf8Ge6cM8MQF5Q7WikJNJv7WoshqiRnoNJ2KHkuyZgvaQhX4Ao4rNw/sU0mCvjrKZdfmkGy7pw==; 5:spnsNFzlIrbEwygX7qm3aSnKTDM9D2Cq1xmavwzVsZX4VNdIOQteSSxNHnoGqLlruEa6zYN06CnzSjAe2TV6hmMo2Cbb95f37BV0Xyst1xyQlOtCWzG0c59Izr14RUZlgOotvhtso8PJ+pW7PQkY/jzDBBBXLJ2pObVIRwDexhU=; 24:CvShI4eBfCNyP64apTNQ8tnCxe9ZyPqqM6psryT/TfBdasCfoTwK1Mtk0SW4CxHWUIukalBLE3OCbYSttXGBRPJGoipNMKfVyaDRr5qM498= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1811; 7:rBE2z/pNYrI31oLivN/A3CqbynmaTSoW9/4RUPfYKTKpgKqII6/lSRLqmlTL1UyTwREj4DOKPf+rxn6g6LBXi/3RUb8/6W56j6TtVC1H49aNcA0T5Uxp6yxmC/EtqBSzp+Z2w0ykjamZsoh4VRAvS2k2A/CEQyMvPy6OCD7jzOyDhDvGdZvO2cj6wk/FWGD2Ufmd9IQ6Cz+/Cvf0qQBzJbWa03QjJIhm/Xzggd8vft2jcVcIIqniwcopJBGmSAM1; 20:egsp4bU+bRRHYpHFqHQs8CqX0XW5UON5Si8fbop/wVtxzTiQgOHh/58/SFbnHwMo1v9So2bo69Ied99RJVPHAIj4tdyjivaqiIVeDAu+kHntdZtzwBI2cYI6f4z0xpVk/AtyQ5RORpHinqb6U4IINYIltAvi59NzcZvAQ90QMW5mzPq93IFaC93b1KeHqaStzaLrhDU63ftNQPu41Acq0baJTiJh5nJoTjUdeBtz4NxAJZOWctdr+Siggr8G7ROG X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2018 20:11:32.5422 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c844e18b-40d4-425f-256f-08d5d169dbcb X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1811 Subject: [edk2] [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD processors. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen , Jeff Fan , Liming Gao Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" On AMD processors the second SendIpi in the SendInitSipiSipi and SendInitSipiSipiAllExcludingSelf routines is not required, and may cause undesired side-effects during MP initialization. This patch leverages the StandardSignatureIsAuthenticAMD check to exclude the second SendIpi and its associated MicroSecondDelay (200). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Leo Duran Cc: Jordan Justen Cc: Jeff Fan Cc: Liming Gao Reviewed-by: Eric Dong and pushed the patch with the= change suggested by Laszlo. Reviewed-by: Laszlo Ersek --- UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 12 ++++++++--= -- UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 12 ++++++++--= -- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c b/UefiCpuPkg/Li= brary/BaseXApicLib/BaseXApicLib.c index b0b7e32..6e80536 100644 --- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c +++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c @@ -554,8 +554,10 @@ SendInitSipiSipi ( IcrLow.Bits.DeliveryMode =3D LOCAL_APIC_DELIVERY_MODE_STARTUP; IcrLow.Bits.Level =3D 1; SendIpi (IcrLow.Uint32, ApicId); - MicroSecondDelay (200); - SendIpi (IcrLow.Uint32, ApicId); + if (!StandardSignatureIsAuthenticAMD()) { + MicroSecondDelay (200); + SendIpi (IcrLow.Uint32, ApicId); + } } =20 /** @@ -588,8 +590,10 @@ SendInitSipiSipiAllExcludingSelf ( IcrLow.Bits.Level =3D 1; IcrLow.Bits.DestinationShorthand =3D LOCAL_APIC_DESTINATION_SHORTHAND_AL= L_EXCLUDING_SELF; SendIpi (IcrLow.Uint32, 0); - MicroSecondDelay (200); - SendIpi (IcrLow.Uint32, 0); + if (!StandardSignatureIsAuthenticAMD()) { + MicroSecondDelay (200); + SendIpi (IcrLow.Uint32, 0); + } } =20 /** diff --git a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c b/U= efiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c index 1f4dcf7..5d82836 100644 --- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c +++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c @@ -649,8 +649,10 @@ SendInitSipiSipi ( IcrLow.Bits.DeliveryMode =3D LOCAL_APIC_DELIVERY_MODE_STARTUP; IcrLow.Bits.Level =3D 1; SendIpi (IcrLow.Uint32, ApicId); - MicroSecondDelay (200); - SendIpi (IcrLow.Uint32, ApicId); + if (!StandardSignatureIsAuthenticAMD()) { + MicroSecondDelay (200); + SendIpi (IcrLow.Uint32, ApicId); + } } =20 /** @@ -683,8 +685,10 @@ SendInitSipiSipiAllExcludingSelf ( IcrLow.Bits.Level =3D 1; IcrLow.Bits.DestinationShorthand =3D LOCAL_APIC_DESTINATION_SHORTHAND_AL= L_EXCLUDING_SELF; SendIpi (IcrLow.Uint32, 0); - MicroSecondDelay (200); - SendIpi (IcrLow.Uint32, 0); + if (!StandardSignatureIsAuthenticAMD()) { + MicroSecondDelay (200); + SendIpi (IcrLow.Uint32, 0); + } } =20 /** --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel