From nobody Tue Jul 15 04:27:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1530817961465618.1079966587358; Thu, 5 Jul 2018 12:12:41 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 21A7E210E2DA8; Thu, 5 Jul 2018 12:12:39 -0700 (PDT) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0063.outbound.protection.outlook.com [104.47.33.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3466210D7F24 for ; Thu, 5 Jul 2018 12:12:37 -0700 (PDT) Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SN6PR12MB2685.namprd12.prod.outlook.com (2603:10b6:805:6f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.20; Thu, 5 Jul 2018 19:12:35 +0000 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=104.47.33.63; helo=nam01-bn3-obe.outbound.protection.outlook.com; envelope-from=brijesh.singh@amd.com; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFTLUSkdJwyNg0dJWuVJMorkr3wmBzt+Xaj56Y9IljA=; b=whz9f1UdIoDdhhrOn9ALWhyX55ItS9Hp4/meON5osiw+z2BchzJBiQPFUb+Qa4oxXIkqp++ctDWSl84v9HGZCNs6XbnOHrmTqFE/Q+KM0ftpYhVarsDKLm2Q6EZGsPQL4ckh4mOB+qp/XAY8YtUl05AmYLaXI58YPTZxrG84yC4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; From: Brijesh Singh To: edk2-devel@lists.01.org Date: Thu, 5 Jul 2018 14:12:23 -0500 Message-Id: <1530817945-8030-2-git-send-email-brijesh.singh@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530817945-8030-1-git-send-email-brijesh.singh@amd.com> References: <1530817945-8030-1-git-send-email-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR1201CA0013.namprd12.prod.outlook.com (2603:10b6:405:4c::23) To SN6PR12MB2685.namprd12.prod.outlook.com (2603:10b6:805:6f::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0692f512-e5b1-4fd3-6b61-08d5e2ab4489 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:SN6PR12MB2685; X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2685; 3:vuV5mb/Fy+FJS1/hC94r04ZMpz8URxfjc6kuS83WbHi/zTmSKju9dRQyfItC9OtquWJG9FqoXqC1CXXz9auLKtDJYExbZizxmr8E1zz1K5/JhlcnePyOyeFvc4jzGUADda4t8KzKNdEXpUKGRD2irXt2UPpy02UNWY56B7/KDbT86PPlis/eQauI4Kl8teWPP7gzkNIYMNURj+1fRDCkBHkY8ZRSukciWsFtgHC/2Hlrcb0Z3ML6/ma5bAtCiM3O; 25:tbUOoFGK9J98J+z0wTOSxAHy2PY8wmiVZVVNv1vXIM1BKwrkYRb5LpSWeQZXY4L+GIKKZarXnu7O0xUMjaqEVVU77DUh+8UnX/eRgfARrbYQWjQoy/WycjrgZK3vNXcPNIY9QiZyoLMYGBY+gffqgdcV6O0kOvc1357w2jnK/m1GPEONowEXIuK6gdv+dtp28sQH/K3C3ZPNqnwmhj9YwGY4XQfWUAboxzsD0JV/4/w1OuXl8qLxlOje660Foo7izJIELBkPW64k3PMaMubSXyyjkvAb4LgMk56scRbs+pjqX6CoEaer8bK7lNU48V1wAO5AneQo7GtXZ6sczT+zSg==; 31:PpAfruA4tOp6tpyv9xrtGxF3WFMeRzlhEd/t93R2zq3P13jM8TJVFeg6O6ErMrBNyYBb/JdLpDSYahtWB4NkUjAxdX5GotzZTQDDWV5GFDqDA3+Q74Q/Imq9ztCGEaIpxLoB7afJzNDBoS06YnCX5BS2O0hXQa/JXrkrd05eQyJ6Iv61dKJWy/ZbglQJs587/WhYSlwhEs95CFDibLWEtWpVVChiij+TeZ6e4V//9I8= X-MS-TrafficTypeDiagnostic: SN6PR12MB2685: X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2685; 20:mdoJdNqXlRG9zl97WRFRqOI36nHluZLSP29O/HnY7oBxsFwjAj9aH76BxA7r8/43Dz/jHfTlXY3KXqIIdmZE5fDkaxL+lbsNf4q1xYFo2NlZc7nSs4OkJ2PLctQ80AseCfdkmhCzuZD9KRfrMmsAd2S6X28DmUDgIb4hQm//qRNiSE1KpslLBIX0spsHWo6uNp2xm4HsxKHLwgjyHNp2Aicgt8fNqsYV5uGEkzgIZkvv1CgjRAcjE6NPITm908XCR7lrGeBK4as9tpxa4Fufyobpxsf+YfKB/ObUgpAP7UmVySF0yRWxb70N1F/5rtFgd0rPGLg57DNWonQUCVv60cHIWC2uLEUo21FPIvzNs9K4L60Kzfnyi9/jYsKRVyN06LJ8li5UaYb52XfECeNSJq+8SyEWheZzX9rbbHWYVVLzgFQWeF/CYUKDwKK37Hl+5vy5BSgs3aKljok6TEQlzMBV5Z9sXOrSXwrk1jYQrV6TmlB1Zkkx8rcR/gX+xGa7; 4:kLEa3Vzzlp3P859TVqqMyHOhCOv/9QsQQoteRQnxO5vgbMxg3JpKgVNwZa8fJuTGoSMOuqVjayQz2nmA9WubnbvAOwzO3+zA5Ir7NIAzbEfXQ5BRDKo1ckuJInKT5iGLn3n2emNb0S7qOoc2B61qR6QJKyUEAHDI60Fq+zYZCx58LQWqhkaMz6Br0NedSO+sTQWBiYnYuxOEM+n9pfB+r6I3FIKmN/4Yp/LmBhEbkrr3RhyX7IYLds+LbN0bd1Ohs7vnvv5+pk14fISw2b+RlsY8pBRioLiP90SRP5yd3ksWrA0WLC+iU557RV+IurI5qzcjwasfsQOc/akWH2sY9e1MxO+KrRXyS1mqgiWqHQnemGkieZS0vu06ZASv9yUU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(70601490899591)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:SN6PR12MB2685; BCL:0; PCL:0; RULEID:; SRVR:SN6PR12MB2685; X-Forefront-PRVS: 0724FCD4CD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(396003)(136003)(346002)(366004)(189003)(199004)(106356001)(105586002)(4326008)(2351001)(54906003)(50226002)(25786009)(186003)(53936002)(51416003)(52116002)(36756003)(7696005)(16526019)(66066001)(47776003)(2361001)(5660300001)(6916009)(68736007)(316002)(16586007)(6666003)(446003)(478600001)(53416004)(8676002)(86362001)(6486002)(50466002)(2906002)(44832011)(81156014)(3846002)(386003)(2616005)(476003)(11346002)(956004)(81166006)(8936002)(48376002)(97736004)(486006)(305945005)(6116002)(76176011)(26005)(7736002)(213903007); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR12MB2685; H:sbrijesh-desktop.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR12MB2685; 23:j2aQUmsml7kz55+LX+6fym4Idnh4ZAAo3tguUglt6?= =?us-ascii?Q?muzw6ofds5CsAyRU1GU3zVswrN5abG8Z86iOmi06xIgbPssvE6/dtTRqdlXG?= =?us-ascii?Q?opCJNxoDx6O6M/XE6uo+TdDTK4qj00psyi1p5rYvRCCG4PikgEUYAhd/neGX?= =?us-ascii?Q?DlHSw05vjul91mKotbQzRQ8x82sLzf161XZ1xKbEDcrLP1I4QLVonPeIpXzu?= =?us-ascii?Q?fVEx8t9kqxK8ury45WyY73mq9t3mE3r1XiU26n+TTwwpkANDPqNDUOaEh0Uq?= =?us-ascii?Q?8Z/hgGxia7GxH709RcZNAMOQlZd9rDqgMK7w8dDOyY2pIioJ4g3ni76FvWDJ?= =?us-ascii?Q?aQIOMbf9EHjeJL/egeNbZQTKsvC97e+6KKk5nU4NMp0hvc24oJxCSaXrM3yi?= =?us-ascii?Q?xMfqBotUVcLh699riIiieAIjfeuIxChEczbk6AyQEHxffcMHpRxym2zU0I5e?= =?us-ascii?Q?tA2WKaqa71K34BIFU8A15e5osibPL0zxyoW9v7nVclagAyaVIDje8rNJVTr/?= =?us-ascii?Q?uKDq3AhKkA6M36mPq91WGnKTZp42bOjdr6e/3b6NAh+iAgFDuTaAUZXdoxHu?= =?us-ascii?Q?xoICKSStY2wxOXoIl4Mx6LxECVxKCG4Ru350Ly0Vdk0vFKfL/UDUsW9U+xN9?= =?us-ascii?Q?k1Xkbfgit2PyrNOdkyKCL4gwTPRkMVgagrCg48akNpUbWf9/rbAQf2MujOSI?= =?us-ascii?Q?S6iE+Am8d7pfGFSevZjr77HW8JfqxcrG0ZIrEl5XpSmgIMUcSNtxvuyOJ5Lp?= =?us-ascii?Q?3L7Qsfpsw70ENj0IBnlvIwpXQzfpj/X9H88h/sa5tEKO5Mc0HTtCFB7P0Gju?= =?us-ascii?Q?3eLWkmP+gkgfZ9tm9iYCZCYIFqVyn6RorHPOY+W340W9m1FeSjXgWki0q17e?= =?us-ascii?Q?AyUYpmJXg2DgiFJsCTJ3CkZlYxS2Fq0YAtnBwNYacvQur9N2xNPT19RREwIG?= =?us-ascii?Q?GAkfsfqeyYqgtuVfedgWyOZSel6feojIXe3N09LdG8aNVQ+me+So67YDxJTp?= =?us-ascii?Q?gsDiNPk6HMSU7oDF9GITk/9rAnbazKC84JborOySHgETSkjX1wYxfyDnTCdq?= =?us-ascii?Q?I7yVG5FWnMB8FbvqnXisI1RZOphY+4Ulvc2Px0upfgyU9KciR7REXpzwfzb6?= =?us-ascii?Q?S42jo2HkyTrH1fzWkuyuf/zEwKIZLMGnIecDf9y+pGz21afY7z2wetljd9ik?= =?us-ascii?Q?79c1QtCd6dbrY9eeatVOzNOlaVvpGA7Stx3zqKO3UB7+zDK3b4hzOGTYhhJn?= =?us-ascii?Q?TBt0BuwuwjQdLU4Oat3aDzUlVCh3P6mmFNp/tH8?= X-Microsoft-Antispam-Message-Info: ARZnrhFSWfnJYFeOsqcZBY4NG3VTPQx5ZMoWD/fvbLAt1kjOvxc+QEMkGNPYJlPikSSMaBY+y0mGSbUEvFMwMxHhyN8DP0TgfrK8PYp3cUmjl67ajOykCeS5qItF7SkUNtOt8yyPiSk6hAm5zmSYxoqtoORjNZJSvCWSYpuhZkmW6i1Fq9Kmqtw2elmwKj13afMh2XR1INXmsY7ub7v7UVzfUm+K+CgKNMa+wGH58Bj6w295KuiQryVAKnKFLeru6dPkIfUw3qZOwBD2RCk12QcRc2+ww5e7YBuampIsf1RormOqoPv2Miipl13ZaHhVYSe9QL1+Vtug0CmmBkNK/3kwIOXIBekrjDKLEj4yDAM= X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2685; 6:B3LdrnKgxPyM+FU7YwoRPK8J+pxAd6hFbbENxW2uy5fUvcQl9l0fgFejUxeKx4biZOJeZ6V0wbXtSjihUR9oMtcQHYbcANnP84vDzHnz3/3d9dLdb5jrsm+HTNGJx6/L56577zxWl59AZKqtLBtwaNQMqXE7GIWog+TrSxvCTKSimDRxYGx3g1xosgANN2kTnpbI5Iq7EhsR65vSY7MBHBEHmzgSKn9cok8BRmTVwjWv8GRzG2yyJbRt91A+xVYW8ipcvSl7ung8xjNnLeQJo+vvXWB4s31EQp2JHVGP4bTAw+/JGppL7rSnSlaUoL2jEf02ZJhyw/D55Mz7LKooWPkgbXyS+jkuwUyIFcENTveGhUa9gQM7XZAFwTlVz+T2DkqT8a7uhcYq3hlHb0RaLWrBWb5awRZ8TzSS7qqk0iImkV0pMec6RIBPv94iqQfmOsO2dnu/vfb8Ght7HNVAig==; 5:M9LQnOdzSClDBF5eNe2ig13XyhmqPmexbnZQe7FRVeYOVXdfX9gjpvnmyNCFB5fZ7fFt7Q3TIC61lmp73ibJV97c0Otmj+dCm+Akq1t0pOjrTpJTiT728OPEYuctQfPfBP886bdPT7Xh1rBnnVXvKwT0KNaOnayokXKGpYqb22o=; 24:zltB2HO23RarEOeJa1vNgjOKX/f3SG6M2HfWyydgDIrjBKdnJCBCMUUOHCJMSHyN8l0cqCAVYffo0xrViUJ4+z++QSRY1xg7SzR4f4Wg8Rk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2685; 7:xQ2T8YS6ryXa96QE7FUQOzRgx10sStPszGcqKQXWGGBbJX5b7O7tQhrP/LKY/FkEN8eLrw1Y2jceOsSsvk0kwpSluxbL9pFeYApsD4I9oI1mFLvnqGnpkXqPjC+NBnf+C4IjCWCDSVxfoGSZ0xMqRIr1+2bJIuCW1K897tLBHUExFggzXtfz6MvN/h8V+pfjbvw87Pf91tDNM1je9xO31+JnHPztiY41YlTWVU9um4V5FjjJVrO8o6NMDPVlshK0; 20:Ty19qWJG6f4AR7glYZSaG593KeqDWCIZfkqnooatBc/K1vyVKP5+jNSdCIdVNAU7tw7Pks3wc4sf/hLNy/dGxdEFiS0lEvHpn0Mjh+TzV17yOsiPBMEbdtXN4XAD4/UAZf2aVAe+Fnjmy0IbKqCvdRNLu8m60INDUp7tU8h4FHUrFDsCxJoNtki8r26FBHPFfANF6cP1OcPsufPzDm2aU8U49Ou/WezpQcctehYyClXmSva2CagO98eKlYHhRcEu X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2018 19:12:35.2669 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0692f512-e5b1-4fd3-6b61-08d5e2ab4489 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2685 Subject: [edk2] [PATCH v3 1/3] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: mark Flash memory range as MMIO X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lendacky Thomas , Brijesh Singh , Justen Jordan L , Anthony Perard , Laszlo Ersek Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The flash memory range is an IO address and should be presented as Memory Mapped IO in EFI Runtime mapping. This information can be used by OS when mapping the flash memory range. It is especially helpful in SEV guest case, in which IO addresses should be mapped as unencrypted. If memory region is not marked as MMIO then OS maps the range as encrypted. Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Cc: Justen Jordan L Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Brijesh Singh --- .../FwBlockService.c | 28 ++++++++++++++++--= ---- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c b/Ovmf= Pkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c index 558b395dff4a..28499991a43c 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c @@ -831,12 +831,13 @@ ValidateFvHeader ( =20 STATIC EFI_STATUS -MarkMemoryRangeForRuntimeAccess ( +MarkIoMemoryRangeForRuntimeAccess ( EFI_PHYSICAL_ADDRESS BaseAddress, UINTN Length ) { EFI_STATUS Status; + EFI_GCD_MEMORY_SPACE_DESCRIPTOR GcdDescriptor; =20 // // Mark flash region as runtime memory @@ -847,18 +848,31 @@ MarkMemoryRangeForRuntimeAccess ( ); =20 Status =3D gDS->AddMemorySpace ( - EfiGcdMemoryTypeSystemMemory, + EfiGcdMemoryTypeMemoryMappedIo, BaseAddress, Length, EFI_MEMORY_UC | EFI_MEMORY_RUNTIME ); ASSERT_EFI_ERROR (Status); =20 - Status =3D gBS->AllocatePages ( + Status =3D gDS->AllocateMemorySpace ( AllocateAddress, - EfiRuntimeServicesData, - EFI_SIZE_TO_PAGES (Length), - &BaseAddress + EfiGcdMemoryTypeMemoryMappedIo, + 0, + Length, + &BaseAddress, + gImageHandle, + NULL + ); + ASSERT_EFI_ERROR (Status); + + Status =3D gDS->GetMemorySpaceDescriptor (BaseAddress, &GcdDescript= or); + ASSERT_EFI_ERROR (Status); + + Status =3D gDS->SetMemorySpaceAttributes ( + BaseAddress, + Length, + GcdDescriptor.Attributes | EFI_MEMORY_RUNTIME ); ASSERT_EFI_ERROR (Status); =20 @@ -1091,7 +1105,7 @@ FvbInitialize ( // InstallProtocolInterfaces (FvbDevice); =20 - MarkMemoryRangeForRuntimeAccess (BaseAddress, Length); + MarkIoMemoryRangeForRuntimeAccess (BaseAddress, Length); =20 // // Set several PCD values to point to flash --=20 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel