FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked

[edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked

Posted by Star Zeng 4 years, 8 months ago

Instead of EFI_ACCESS_DENIED which is not defined in retval by
UEFI spec, return UNSUPPORTED if device has been locked in
SetTheImage().

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index fb02e34f708f..b25a1511c70c 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -928,7 +928,7 @@ SetTheImage (
   //
   if (mFmpDeviceLocked) {
     DEBUG ((DEBUG_ERROR, "FmpDxe: SetTheImage() - Device is already locked.  Can't update.\n"));
-    Status = EFI_ACCESS_DENIED;
+    Status = EFI_UNSUPPORTED;
     goto cleanup;
   }
 
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked

Posted by Kinney, Michael D 4 years, 8 months ago

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Zeng, Star
> Sent: Saturday, July 28, 2018 6:58 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [staging/FmpDevicePkg-master][PATCH]
> FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has
> been locked
> 
> Instead of EFI_ACCESS_DENIED which is not defined in
> retval by
> UEFI spec, return UNSUPPORTED if device has been locked
> in
> SetTheImage().
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index fb02e34f708f..b25a1511c70c 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -928,7 +928,7 @@ SetTheImage (
>    //
>    if (mFmpDeviceLocked) {
>      DEBUG ((DEBUG_ERROR, "FmpDxe: SetTheImage() -
> Device is already locked.  Can't update.\n"));
> -    Status = EFI_ACCESS_DENIED;
> +    Status = EFI_UNSUPPORTED;
>      goto cleanup;
>    }
> 
> --
> 2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel