[v2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

[edk2] [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Posted by Star Zeng 4 years, 8 months ago

Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.

This patch updates the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index b25a1511c70c..095cebaa7507 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -229,6 +229,7 @@ GetLowestSupportedVersion (
   //
   // Check the FmpDeviceLib
   //
+  DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
   Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
   if (EFI_ERROR (Status)) {
     DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion

Posted by Kinney, Michael D 4 years, 8 months ago

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Zeng, Star
> Sent: Sunday, July 29, 2018 11:02 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [staging/FmpDevicePkg-master][PATCH V2]
> FmpDevicePkg FmpDxe: Initialize
> DeviceLibLowestSupportedVersion
> 
> Some static tool reports
> "DeviceLibLowestSupportedVersion" is used,
> but is uninitialized. It is false positive reporting
> based because
> DeviceLibLowestSupportedVersion will have assigned
> value after
> FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
> 
> This patch updates the code to initialize
> DeviceLibLowestSupportedVersion
> to DEFAULT_LOWESTSUPPORTEDVERSION before calling
> FmpDeviceGetLowestSupportedVersion().
> It can pass the static tool's check.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index b25a1511c70c..095cebaa7507 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -229,6 +229,7 @@ GetLowestSupportedVersion (
>    //
>    // Check the FmpDeviceLib
>    //
> +  DeviceLibLowestSupportedVersion =
> DEFAULT_LOWESTSUPPORTEDVERSION;
>    Status = FmpDeviceGetLowestSupportedVersion
> (&DeviceLibLowestSupportedVersion);
>    if (EFI_ERROR (Status)) {
>      DeviceLibLowestSupportedVersion =
> DEFAULT_LOWESTSUPPORTEDVERSION;
> --
> 2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel