From nobody Sat Apr 20 14:20:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=intel.com Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1532944923746580.9329838967586; Mon, 30 Jul 2018 03:02:03 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 90FC6210C515E; Mon, 30 Jul 2018 03:02:01 -0700 (PDT) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8DBA210C4DBF for ; Mon, 30 Jul 2018 03:02:00 -0700 (PDT) Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 03:01:59 -0700 Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by orsmga008.jf.intel.com with ESMTP; 30 Jul 2018 03:01:58 -0700 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,422,1526367600"; d="scan'208";a="60900779" From: Star Zeng To: edk2-devel@lists.01.org Date: Mon, 30 Jul 2018 18:01:56 +0800 Message-Id: <1532944916-30288-1-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Fix code style issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael D Kinney , Star Zeng MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng Reviewed-by: Michael D Kinney --- FmpDevicePkg/FmpDevicePkg.uni | 22 ++++++------ FmpDevicePkg/FmpDxe/DetectTestKey.c | 2 +- FmpDevicePkg/FmpDxe/FmpDxe.c | 42 +++++++++++-------= ---- FmpDevicePkg/FmpDxe/VariableSupport.c | 6 ++-- FmpDevicePkg/FmpDxe/VariableSupport.h | 6 ++-- .../Include/Library/CapsuleUpdatePolicyLib.h | 6 ++-- FmpDevicePkg/Include/Library/FmpDeviceLib.h | 20 +++++------ FmpDevicePkg/Include/Library/FmpPayloadHeaderLib.h | 8 ++--- .../CapsuleUpdatePolicyLibNull.c | 6 ++-- .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 22 ++++++------ .../FmpPayloadHeaderLibV1/FmpPayloadHeaderLib.c | 8 ++--- 11 files changed, 75 insertions(+), 73 deletions(-) diff --git a/FmpDevicePkg/FmpDevicePkg.uni b/FmpDevicePkg/FmpDevicePkg.uni index fed1da48026e..a922ff44e4db 100644 --- a/FmpDevicePkg/FmpDevicePkg.uni +++ b/FmpDevicePkg/FmpDevicePkg.uni @@ -59,17 +59,17 @@ = "value of 0 disables the watchdog timer. T= he default value is 0 (watchdog" = "disabled)." =20 -#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdFmpDevicePkcs7CertBufferXdr_P= ROMPT #language en-US "One or more XDR encoded PKCS7 certificates used to = verify firmware device capsule update images" -#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdFmpDevicePkcs7CertBufferXdr_H= ELP #language en-US "Provides one or more PKCS7 certificates used to ver= ify a firmware device" - = "capsule update image. This PCD is encoded using th= e Variable-Length Opaque" - = "Data format of RFC 4506 External Data Representatio= n Standard (XDR)." - = "The default value is empty with 0 certificates." +#string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDevicePkcs7CertBufferXdr_PRO= MPT #language en-US "One or more XDR encoded PKCS7 certificates used to ve= rify firmware device capsule update images" +#string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDevicePkcs7CertBufferXdr_HEL= P #language en-US "Provides one or more PKCS7 certificates used to verif= y a firmware device" + = "capsule update image. This PCD is encoded using the = Variable-Length Opaque" + = "Data format of RFC 4506 External Data Representation = Standard (XDR)." + = "The default value is empty with 0 certificates." =20 -#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdFmpDeviceLockEventGuid_PROMPT= #language en-US "Firmware Device Lock Event GUID." -#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdFmpDeviceLockEventGuid_HELP = #language en-US "An event GUID that locks the firmware device when the ev= ent is signaled." - = "If this PCD is not a valid GUID value, then the firmware= device is locked" - = "when gEfiEndOfDxeEventGroupGuid (End of DXE Phase) is si= gnaled. The" - = "default value is empty, so by default the firmware devic= e is locked at the" - = "end of the DXE phase." +#string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDeviceLockEventGuid_PROMPT = #language en-US "Firmware Device Lock Event GUID." +#string STR_gFmpDevicePkgTokenSpaceGuid_PcdFmpDeviceLockEventGuid_HELP = #language en-US "An event GUID that locks the firmware device when the even= t is signaled." + = "If this PCD is not a valid GUID value, then the firmware d= evice is locked" + = "when gEfiEndOfDxeEventGroupGuid (End of DXE Phase) is sign= aled. The" + = "default value is empty, so by default the firmware device = is locked at the" + = "end of the DXE phase." =20 =20 diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/Dete= ctTestKey.c index 05ed00732abe..d1ac5a680134 100644 --- a/FmpDevicePkg/FmpDxe/DetectTestKey.c +++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c @@ -1,4 +1,4 @@ -/** @file +/** @file Detects if PcdFmpDevicePkcs7CertBufferXdr contains a test key. =20 Copyright (c) 2018, Intel Corporation. All rights reserved.
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index 095cebaa7507..0f3396c2ef83 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -1,4 +1,4 @@ -/** @file +/** @file Produces a Firmware Management Protocol that supports updates to a firmw= are image stored in a firmware device with platform and firmware device spec= ific information provided through PCDs and libraries. @@ -90,7 +90,7 @@ CHAR16 *mVersionName =3D NULL; =20 EFI_EVENT mFmpDeviceLockEvent; // -// Indicates if an attempt has been made to lock a=20 +// Indicates if an attempt has been made to lock a // FLASH storage device by calling FmpDeviceLock(). // A FLASH storage device may not support being locked, // so this variable is set to TRUE even if FmpDeviceLock() @@ -474,11 +474,11 @@ cleanup: This function allows a copy of the current firmware image to be created = and saved. The saved copy could later been used, for example, in firmware image rec= overy or rollback. =20 - @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_= PROTOCOL instance. - @param[in] ImageIndex A unique number identifying the firmware = image(s) within the device. + @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_= PROTOCOL instance. + @param[in] ImageIndex A unique number identifying the firmware = image(s) within the device. The number is between 1 and DescriptorCou= nt. - @param[out] Image Points to the buffer where the current im= age is copied to. - @param[out] ImageSize On entry, points to the size of the buffe= r pointed to by Image, in bytes. + @param[in, out] Image Points to the buffer where the current im= age is copied to. + @param[in, out] ImageSize On entry, points to the size of the buffe= r pointed to by Image, in bytes. On return, points to the length of the im= age, in bytes. =20 @retval EFI_SUCCESS The device was successfully updated with = the new image. @@ -646,7 +646,7 @@ CheckTheImage ( IN UINT8 ImageIndex, IN CONST VOID *Image, IN UINTN ImageSize, - OUT UINT32 *ImageUpdateable + OUT UINT32 *ImageUpdatable ) { EFI_STATUS Status; @@ -677,8 +677,8 @@ CheckTheImage ( PopulateDescriptor(); } =20 - if (ImageUpdateable =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "FmpDxe: CheckImage() - ImageUpdateable Pointer P= arameter is NULL.\n")); + if (ImageUpdatable =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "FmpDxe: CheckImage() - ImageUpdatable Pointer Pa= rameter is NULL.\n")); Status =3D EFI_INVALID_PARAMETER; goto cleanup; } @@ -686,14 +686,14 @@ CheckTheImage ( // //Set to valid and then if any tests fail it will update this flag. // - *ImageUpdateable =3D IMAGE_UPDATABLE_VALID; + *ImageUpdatable =3D IMAGE_UPDATABLE_VALID; =20 if (Image =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "FmpDxe: CheckImage() - Image Pointer Parameter i= s NULL.\n")); // // not sure if this is needed // - *ImageUpdateable =3D IMAGE_UPDATABLE_INVALID; + *ImageUpdatable =3D IMAGE_UPDATABLE_INVALID; return EFI_INVALID_PARAMETER; } =20 @@ -767,7 +767,7 @@ CheckTheImage ( // if (ImageIndex !=3D 1) { DEBUG ((DEBUG_ERROR, "FmpDxe: CheckImage() - Image Index Invalid.\n")); - *ImageUpdateable =3D IMAGE_UPDATABLE_INVALID_TYPE; + *ImageUpdatable =3D IMAGE_UPDATABLE_INVALID_TYPE; Status =3D EFI_SUCCESS; goto cleanup; } @@ -785,7 +785,7 @@ CheckTheImage ( Status =3D GetFmpPayloadHeaderVersion (FmpPayloadHeader, FmpPayloadSize,= &Version); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "FmpDxe: CheckTheImage() - GetFmpPayloadHeaderVer= sion failed %r.\n", Status)); - *ImageUpdateable =3D IMAGE_UPDATABLE_INVALID; + *ImageUpdatable =3D IMAGE_UPDATABLE_INVALID; Status =3D EFI_SUCCESS; goto cleanup; } @@ -799,7 +799,7 @@ CheckTheImage ( "FmpDxe: CheckTheImage() - Version Lower than lowest supported versi= on. 0x%08X < 0x%08X\n", Version, mDesc.LowestSupportedImageVersion) ); - *ImageUpdateable =3D IMAGE_UPDATABLE_INVALID_OLD; + *ImageUpdatable =3D IMAGE_UPDATABLE_INVALID_OLD; Status =3D EFI_SUCCESS; goto cleanup; } @@ -810,7 +810,7 @@ CheckTheImage ( Status =3D GetFmpPayloadHeaderSize (FmpPayloadHeader, FmpPayloadSize, &F= mpHeaderSize); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "FmpDxe: CheckTheImage() - GetFmpPayloadHeaderSiz= e failed %r.\n", Status)); - *ImageUpdateable =3D IMAGE_UPDATABLE_INVALID; + *ImageUpdatable =3D IMAGE_UPDATABLE_INVALID; Status =3D EFI_SUCCESS; goto cleanup; } @@ -830,7 +830,7 @@ CheckTheImage ( // // FmpDeviceLib CheckImage function to do any specific checks // - Status =3D FmpDeviceCheckImage ((((UINT8 *)Image) + AllHeaderSize), RawS= ize, ImageUpdateable); + Status =3D FmpDeviceCheckImage ((((UINT8 *)Image) + AllHeaderSize), RawS= ize, ImageUpdatable); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "FmpDxe: CheckTheImage() - FmpDeviceLib CheckImag= e failed. Status =3D %r\n", Status)); } @@ -909,6 +909,8 @@ SetTheImage ( EFI_STATUS GetAttributesStatus; UINT64 AttributesSupported; UINT64 AttributesSetting; + UINT32 Version; + UINT32 LowestSupportedVersion; =20 Status =3D EFI_SUCCESS; Updateable =3D 0; @@ -1103,7 +1105,7 @@ SetTheImage ( // Update the version stored in variable // if (!mRuntimeVersionSupported) { - UINT32 Version =3D DEFAULT_VERSION; + Version =3D DEFAULT_VERSION; GetFmpPayloadHeaderVersion (FmpHeader, FmpPayloadSize, &Version); SetVersionInVariable (Version); } @@ -1112,9 +1114,9 @@ SetTheImage ( // Update lowest supported variable // { - UINT32 Version =3D DEFAULT_LOWESTSUPPORTEDVERSION; - GetFmpPayloadHeaderLowestSupportedVersion (FmpHeader, FmpPayloadSize, = &Version); - SetLowestSupportedVersionInVariable (Version); + LowestSupportedVersion =3D DEFAULT_LOWESTSUPPORTEDVERSION; + GetFmpPayloadHeaderLowestSupportedVersion (FmpHeader, FmpPayloadSize, = &LowestSupportedVersion); + SetLowestSupportedVersionInVariable (LowestSupportedVersion); } =20 LastAttemptStatus =3D LAST_ATTEMPT_STATUS_SUCCESS; diff --git a/FmpDevicePkg/FmpDxe/VariableSupport.c b/FmpDevicePkg/FmpDxe/Va= riableSupport.c index 6a4330ad6a83..b7e4cb989628 100644 --- a/FmpDevicePkg/FmpDxe/VariableSupport.c +++ b/FmpDevicePkg/FmpDxe/VariableSupport.c @@ -1,4 +1,4 @@ -/** @file +/** @file UEFI variable support functions for Firmware Management Protocol based firmware updates. =20 @@ -305,8 +305,8 @@ SetVersionInVariable ( =20 UEFI Variable accessed: GUID =3D gEfiCallerIdGuid, Name =3D L"FmpLsv" =20 - @param[in] LowestSupported The lowest supported version of the firmware= image - in the firmware device. + @param[in] LowestSupportedVersion The lowest supported version of the fi= rmware image + in the firmware device. =20 **/ VOID diff --git a/FmpDevicePkg/FmpDxe/VariableSupport.h b/FmpDevicePkg/FmpDxe/Va= riableSupport.h index e7e34f5d8f79..62c213ee1ac8 100644 --- a/FmpDevicePkg/FmpDxe/VariableSupport.h +++ b/FmpDevicePkg/FmpDxe/VariableSupport.h @@ -1,4 +1,4 @@ -/** @file +/** @file UEFI variable support functions for Firmware Management Protocol based firmware updates. =20 @@ -128,8 +128,8 @@ SetVersionInVariable ( =20 UEFI Variable accessed: GUID =3D gEfiCallerIdGuid, Name =3D L"FmpLsv" =20 - @param[in] LowestSupported The lowest supported version of the firmware= image - in the firmware device. + @param[in] LowestSupportedVersion The lowest supported version of the fi= rmware image + in the firmware device. =20 **/ VOID diff --git a/FmpDevicePkg/Include/Library/CapsuleUpdatePolicyLib.h b/FmpDev= icePkg/Include/Library/CapsuleUpdatePolicyLib.h index acd3ce5bf545..b5fffc9acb94 100644 --- a/FmpDevicePkg/Include/Library/CapsuleUpdatePolicyLib.h +++ b/FmpDevicePkg/Include/Library/CapsuleUpdatePolicyLib.h @@ -1,4 +1,4 @@ -/** @file +/** @file Provides platform policy services used during a capsule update. =20 Copyright (c) 2016, Microsoft Corporation. All rights reserved.
@@ -63,7 +63,7 @@ CheckSystemPower ( EFI_STATUS EFIAPI CheckSystemThermal ( - IN OUT BOOLEAN *Good + OUT BOOLEAN *Good ); =20 /** @@ -82,7 +82,7 @@ CheckSystemThermal ( EFI_STATUS EFIAPI CheckSystemEnvironment ( - IN OUT BOOLEAN *Good + OUT BOOLEAN *Good ); =20 /** diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h b/FmpDevicePkg/Inc= lude/Library/FmpDeviceLib.h index 08125f00962c..e882b145cbb9 100644 --- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h +++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h @@ -1,4 +1,4 @@ -/** @file +/** @file Provides firmware device specific services to support updates of a firmw= are image stored in a firmware device. =20 @@ -147,8 +147,8 @@ FmpDeviceGetImageTypeIdGuidPtr ( EFI_STATUS EFIAPI FmpDeviceGetAttributes ( - IN OUT UINT64 *Supported, - IN OUT UINT64 *Setting + OUT UINT64 *Supported, + OUT UINT64 *Setting ); =20 /** @@ -256,9 +256,9 @@ FmpDeviceGetVersion ( a copy currently stored firmware image. This can be used to suppo= rt features such as recovery and rollback. =20 - @param[out] Image Pointer to a caller allocated buffer where the + @param[out] Image Pointer to a caller allocated buffer where the currently stored firmware image is copied to. - @param[in out] ImageSize Pointer the size, in bytes, of the Image buffe= r. + @param[in, out] ImageSize Pointer the size, in bytes, of the Image buffe= r. On return, points to the size, in bytes, of fi= rmware image currently stored in the firmware device. =20 @@ -282,8 +282,8 @@ FmpDeviceGetVersion ( EFI_STATUS EFIAPI FmpDeviceGetImage ( - IN OUT VOID *Image, - IN IN OUT UINTN *ImageSize + OUT VOID *Image, + IN OUT UINTN *ImageSize ); =20 /** @@ -305,9 +305,9 @@ FmpDeviceGetImage ( =20 @retval EFI_SUCCESS The image was successfully checked. Addi= tional status information is returned in - ImageUpdateable. + ImageUpdatable. @retval EFI_INVALID_PARAMETER Image is NULL. - @retval EFI_INVALID_PARAMETER ImageUpdateable is NULL. + @retval EFI_INVALID_PARAMETER ImageUpdatable is NULL. =20 **/ EFI_STATUS @@ -315,7 +315,7 @@ EFIAPI FmpDeviceCheckImage ( IN CONST VOID *Image, IN UINTN ImageSize, - OUT UINT32 *ImageUpdateable + OUT UINT32 *ImageUpdatable ); =20 /** diff --git a/FmpDevicePkg/Include/Library/FmpPayloadHeaderLib.h b/FmpDevice= Pkg/Include/Library/FmpPayloadHeaderLib.h index cb5622e9ce1f..f959cbbc94d1 100644 --- a/FmpDevicePkg/Include/Library/FmpPayloadHeaderLib.h +++ b/FmpDevicePkg/Include/Library/FmpPayloadHeaderLib.h @@ -1,4 +1,4 @@ -/** @file +/** @file Provides services to retrieve values from a capsule's FMP Payload Header. The structure is not included in the library class. Instead, services a= re provided to retrieve information from the FMP Payload Header. If inform= ation @@ -92,9 +92,9 @@ GetFmpPayloadHeaderVersion ( EFI_STATUS EFIAPI GetFmpPayloadHeaderLowestSupportedVersion ( - IN CONST VOID *Header, - IN CONST UINTN FmpPayloadSize, - IN OUT UINT32 *LowestSupportedVersion + IN CONST VOID *Header, + IN CONST UINTN FmpPayloadSize, + OUT UINT32 *LowestSupportedVersion ); =20 #endif diff --git a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdateP= olicyLibNull.c b/FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpd= atePolicyLibNull.c index d86d6ba61234..3f49b69e9045 100644 --- a/FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLi= bNull.c +++ b/FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLi= bNull.c @@ -1,4 +1,4 @@ -/** @file +/** @file Provides platform policy services used during a capsule update. =20 Copyright (c) 2016, Microsoft Corporation. All rights reserved.
@@ -67,7 +67,7 @@ CheckSystemPower ( EFI_STATUS EFIAPI CheckSystemThermal ( - IN OUT BOOLEAN *Good + OUT BOOLEAN *Good ) { *Good =3D TRUE; @@ -90,7 +90,7 @@ CheckSystemThermal ( EFI_STATUS EFIAPI CheckSystemEnvironment ( - IN OUT BOOLEAN *Good + OUT BOOLEAN *Good ) { *Good =3D TRUE; diff --git a/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c b/FmpDevi= cePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c index 03e8750661c2..c918c5b2e8d9 100644 --- a/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c +++ b/FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLib.c @@ -1,4 +1,4 @@ -/** @file +/** @file Provides firmware device specific services to support updates of a firmw= are image stored in a firmware device. =20 @@ -79,7 +79,7 @@ RegisterFmpInstaller ( EFI_STATUS EFIAPI FmpDeviceGetSize ( - IN UINTN *Size + OUT UINTN *Size ) { if (Size =3D=3D NULL) { @@ -138,8 +138,8 @@ FmpDeviceGetImageTypeIdGuidPtr ( EFI_STATUS EFIAPI FmpDeviceGetAttributes ( - IN OUT UINT64 *Supported, - IN OUT UINT64 *Setting + OUT UINT64 *Supported, + OUT UINT64 *Setting ) { if (Supported =3D=3D NULL || Setting =3D=3D NULL) { @@ -268,9 +268,9 @@ FmpDeviceGetVersion ( a copy currently stored firmware image. This can be used to suppo= rt features such as recovery and rollback. =20 - @param[out] Image Pointer to a caller allocated buffer where the + @param[out] Image Pointer to a caller allocated buffer where the currently stored firmware image is copied to. - @param[in out] ImageSize Pointer the size, in bytes, of the Image buffe= r. + @param[in, out] ImageSize Pointer the size, in bytes, of the Image buffe= r. On return, points to the size, in bytes, of fi= rmware image currently stored in the firmware device. =20 @@ -294,8 +294,8 @@ FmpDeviceGetVersion ( EFI_STATUS EFIAPI FmpDeviceGetImage ( - IN OUT VOID *Image, - IN IN OUT UINTN *ImageSize + OUT VOID *Image, + IN OUT UINTN *ImageSize ) { return EFI_UNSUPPORTED; @@ -320,9 +320,9 @@ FmpDeviceGetImage ( =20 @retval EFI_SUCCESS The image was successfully checked. Addi= tional status information is returned in - ImageUpdateable. + ImageUpdatable. @retval EFI_INVALID_PARAMETER Image is NULL. - @retval EFI_INVALID_PARAMETER ImageUpdateable is NULL. + @retval EFI_INVALID_PARAMETER ImageUpdatable is NULL. =20 **/ EFI_STATUS @@ -330,7 +330,7 @@ EFIAPI FmpDeviceCheckImage ( IN CONST VOID *Image, IN UINTN ImageSize, - OUT UINT32 *ImageUpdateable + OUT UINT32 *ImageUpdatable ) { return EFI_SUCCESS; diff --git a/FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLib= .c b/FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLib.c index 5f08e8b0fd15..b7cf044aa98d 100644 --- a/FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLib.c +++ b/FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLib.c @@ -1,4 +1,4 @@ -/** @file +/** @file Provides services to retrieve values from Version 1 of a capsule's FMP P= ayload Header. The FMP Payload Header structure is not defined in the library c= lass. Instead, services are provided to retrieve information from the FMP Payl= oad @@ -159,9 +159,9 @@ GetFmpPayloadHeaderVersion ( EFI_STATUS EFIAPI GetFmpPayloadHeaderLowestSupportedVersion ( - IN CONST VOID *Header, - IN CONST UINTN FmpPayloadSize, - IN OUT UINT32 *LowestSupportedVersion + IN CONST VOID *Header, + IN CONST UINTN FmpPayloadSize, + OUT UINT32 *LowestSupportedVersion ) { FMP_PAYLOAD_HEADER *FmpPayloadHeader; --=20 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel