FmpDevicePkg FmpDxe: Fix XCODE build failure

[edk2] [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure

Posted by Star Zeng 4 years, 8 months ago

FmpDxe.c:517:18: error: equality comparison with extraneous
parentheses [-Werror,-Wparentheses-equality]

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>

NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.

---
 FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index 0f3396c2ef83..eb3a9b0e32c2 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -514,7 +514,7 @@ GetTheImage (
     goto cleanup;
   }
 
-  if ((ImageSize == NULL)) {
+  if (ImageSize == NULL) {
     DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() - ImageSize Pointer Parameter is NULL.\n"));
     Status = EFI_INVALID_PARAMETER;
     goto cleanup;
-- 
2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure

Posted by Kinney, Michael D 4 years, 8 months ago

Star,

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

I have integrated this patch into a V6 patch series.

Mike

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:31 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build
> failure
> 
> FmpDxe.c:517:18: error: equality comparison with
> extraneous
> parentheses [-Werror,-Wparentheses-equality]
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> 
> NOTE: This patch is based on thread
> https://lists.01.org/pipermail/edk2-devel/2018-
> July/027810.html.
> 
> ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index 0f3396c2ef83..eb3a9b0e32c2 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -514,7 +514,7 @@ GetTheImage (
>      goto cleanup;
>    }
> 
> -  if ((ImageSize == NULL)) {
> +  if (ImageSize == NULL) {
>      DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() -
> ImageSize Pointer Parameter is NULL.\n"));
>      Status = EFI_INVALID_PARAMETER;
>      goto cleanup;
> --
> 2.7.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel