From nobody Tue Apr 16 10:36:59 2024
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
	spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain
 of lists.01.org)  smtp.mailfrom=edk2-devel-bounces@lists.01.org;
	dmarc=fail(p=none dis=none)  header.from=intel.com
Return-Path: <edk2-devel-bounces@lists.01.org>
Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com
	with SMTPS id 1533276750372321.143121285695;
 Thu, 2 Aug 2018 23:12:30 -0700 (PDT)
Received: from [127.0.0.1] (localhost [IPv6:::1])
	by ml01.01.org (Postfix) with ESMTP id 33B27210C4DB4;
	Thu,  2 Aug 2018 23:12:29 -0700 (PDT)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 388B92097FA8F
 for <edk2-devel@lists.01.org>; Thu,  2 Aug 2018 23:12:25 -0700 (PDT)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Aug 2018 23:12:25 -0700
Received: from shwdeopenpsi168.ccr.corp.intel.com ([10.239.158.129])
 by orsmga002.jf.intel.com with ESMTP; 02 Aug 2018 23:12:23 -0700
X-Original-To: edk2-devel@lists.01.org
Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by
 domain of lists.01.org) client-ip=198.145.21.10;
 envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org;
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=192.55.52.88; helo=mga01.intel.com;
 envelope-from=yonghong.zhu@intel.com; receiver=edk2-devel@lists.01.org
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,437,1526367600"; d="scan'208";a="80151065"
From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Date: Fri,  3 Aug 2018 14:12:21 +0800
Message-Id: <1533276741-13044-1-git-send-email-yonghong.zhu@intel.com>
X-Mailer: git-send-email 2.6.1.windows.1
Subject: [edk2] [Patch] DSC Spec: limit the VOID* PCD max size to UINT16
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
Cc: Michael Kinney <michael.d.kinney@intel.com>,
 Kevin W Shaw <kevin.w.shaw@intel.com>, Liming Gao <liming.gao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Errors-To: edk2-devel-bounces@lists.01.org
Sender: "edk2-devel" <edk2-devel-bounces@lists.01.org>
X-ZohoMail: RDMRC_1  RSF_4  Z_629925259 SPT_0
Content-Type: text/plain; charset="utf-8"

current the max size of VOID* PCD in the spec is a number that doesn't
no limitation, now this patch update to limit the max size to UINT16,
besides, also update some typo to make sure the format in chapter 2
and chapter 3 are align.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
 2_dsc_overview/29_pcd_sections.md            | 6 +++---
 3_edk_ii_dsc_file_format/310_pcd_sections.md | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/2_dsc_overview/29_pcd_sections.md b/2_dsc_overview/29_pcd_sect=
ions.md
index 6547656..b33026c 100644
--- a/2_dsc_overview/29_pcd_sections.md
+++ b/2_dsc_overview/29_pcd_sections.md
@@ -1,9 +1,9 @@
 <!--- @file
   2.9 PCD Sections
=20
-  Copyright (c) 2006-2017, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006-2018, Intel Corporation. All rights reserved.<BR>
=20
   Redistribution and use in source (original document form) and 'compiled'
   forms (converted to PDF, epub, HTML and other formats) with or without
   modification, are permitted provided that the following conditions are m=
et:
=20
@@ -112,11 +112,11 @@ The following are typical examples of the `[PcdsFixed=
AtBuild]` section tag (the
 [PcdsFixedAtBuild.$(arch).$(SkuIdentifier)]
 ```
=20
 Format of a point (VOID*) entry in this section is:
=20
-`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatumSize]]`
+`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatumSize]`
=20
 Format for Boolean and numeric entries in this section is:
=20
 `PcdTokenSpaceGuidCName.PcdCName|Value`
=20
@@ -157,11 +157,11 @@ The following are typical examples of the `[PcdsPatch=
ableInModule]` section tag
 [PcdsPatchableInModule.$(arch).$(SkuIdentifier)]
 ```
=20
 Format of an entry in this section is:
=20
-`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType[|MaximumDatumSize]]`
+`PcdTokenSpaceGuidCName.PcdCName|Value[|DatumType|MaximumDatumSize]`
=20
 #### Example
=20
 ```ini
 [PcdsPatchableInModule.common]
diff --git a/3_edk_ii_dsc_file_format/310_pcd_sections.md b/3_edk_ii_dsc_fi=
le_format/310_pcd_sections.md
index 607c479..1879923 100644
--- a/3_edk_ii_dsc_file_format/310_pcd_sections.md
+++ b/3_edk_ii_dsc_file_format/310_pcd_sections.md
@@ -233,11 +233,11 @@ fields that are separated by the pipe character, "|".
                       {<NumValUint32>} {<Expression>}
                     elif (pcddatumtype =3D=3D "UINT64"):
                       {<NumValUint64>} {<Expression>}
                     else:
                       <StringValue> [<MaxSize>]
-<MaxSize>       ::=3D <FS> "VOID*" <FS> {<Number>} {<Expression>}
+<MaxSize>       ::=3D <FS> "VOID*" <FS> {<IntNum>} {<UINT16>}
 <StringValue>   ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
 ```
=20
 #### Parameters
=20
@@ -341,11 +341,11 @@ of the DSC file.
                       {<NumValUint32>} {<Expression>}
                     elif (pcddatumtype =3D=3D "UINT64"):
                       {<NumValUint64>} {<Expression>}
                     else:
                       <StringValue> [<MaxSize>]
-<MaxSize>       ::=3D <FS> {<Number>} {<Expression>}
+<MaxSize>       ::=3D <FS> "VOID*" <FS> {<IntNum>} {<UINT16>}
 <StringValue>   ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
 ```
=20
 #### Parameters
=20
@@ -480,11 +480,11 @@ sections of the DSC file.
                      elif (pcddatumtype =3D=3D "UINT64"):
                        {<NumValUint64>} {<Expression>}
                      else:
                        <StringValue> [<MaxSize>]
 <MaxSize>        ::=3D <FS> "VOID*" [<FS> <SizeValue>]
-<SizeValue>      ::=3D {<Number>} {<Expression>}
+<SizeValue>      ::=3D {<IntNum>} {<UINT16>}
 <StringValue>    ::=3D {<StringVal>} {<MACROVAL>} {<Expression>}
 <VpdEntry>       ::=3D <PcdName> <FS> <VpdOffset> [<FS> <VpdData>] <EOL>
 <VpdOffset>      ::=3D {<Number>} {"*"}
 <VpdData>        ::=3D if (pcddatumtype =3D=3D "BOOLEAN"):
                        {<BoolType>} {<Expression>}
@@ -496,11 +496,11 @@ sections of the DSC file.
                        {<NumValUint32>} {<Expression>}
                      elif(pcddatumtype =3D=3D "UINT64"):
                        {<NumValUint64>} {<Expression>}
                      else:
                        <VpdMaxSize>
-<VpdMaxSize>     ::=3D {<LongNum>} {<UINT32>} [<FS> <StringValue>]
+<VpdMaxSize>     ::=3D {<IntNum>} {<UINT16>} [<FS> <StringValue>]
 <HiiEntry>       ::=3D <PcdName> <FS> <HiiString> <Field2> <EOL>
 <HiiString>      ::=3D {<CArray>} {<UnicodeString>}
 <Field2>         ::=3D <FS> <VariableGuid> <FS> <VariableOffset> [<ValueFi=
eld>]
 <VariableGuid>   ::=3D <CName>
 <ValueField>     ::=3D <FS> <DefaultValue> [<FS> <HiiAttrs>]
--=20
2.6.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel