[edk2] [PATCH 0/2] Initialize CNTHCTL

evan.lloyd@arm.com posted 2 patches 7 years, 7 months ago
Failed in applying to current master (apply log)
ArmPkg/Include/Chipset/AArch64.h               | 12 +++++++++++-
ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c       |  9 ++++++++-
ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 10 ++++++++++
ArmPlatformPkg/PrePeiCore/AArch64/Helper.S     |  9 ++++++++-
4 files changed, 37 insertions(+), 3 deletions(-)
[edk2] [PATCH 0/2] Initialize CNTHCTL
Posted by evan.lloyd@arm.com 7 years, 7 months ago
From: Evan <evan.lloyd@arm.com>

A pair of minor patches to correct an omission.
This patch set enables timer access as required by the UEFI
specification.
The first patch adds accessors for the register to ArmPkg,
the second fixes the error in ArmPlatofrmPkg.
They are in different packages, but dependent.
As the responsible adults involved are the same, I hope that is
acceptable.

The code can be examined at:
https://github.com/EvanLloyd/tianocore/tree/initialize_cnthctl_v1


Sami Mujawar (2):
  ArmPkg: Add CNTHCTL_EL2 support functions
  ArmPlatformPkg: Timer access for non-secure EL1/0

 ArmPkg/Include/Chipset/AArch64.h               | 12 +++++++++++-
 ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c       |  9 ++++++++-
 ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 10 ++++++++++
 ArmPlatformPkg/PrePeiCore/AArch64/Helper.S     |  9 ++++++++-
 4 files changed, 37 insertions(+), 3 deletions(-)

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] Initialize CNTHCTL
Posted by Leif Lindholm 7 years, 7 months ago
Hi Evan,

Apologies for delay, was off sick last week.

On Tue, May 16, 2017 at 11:10:43AM +0100, evan.lloyd@arm.com wrote:
> From: Evan <evan.lloyd@arm.com>
> 
> A pair of minor patches to correct an omission.
> This patch set enables timer access as required by the UEFI
> specification.
> The first patch adds accessors for the register to ArmPkg,
> the second fixes the error in ArmPlatofrmPkg.
> They are in different packages, but dependent.
> As the responsible adults involved are the same, I hope that is
> acceptable.

More than acceptable, it's preferable (and means we don't break
bisect).

This looks like a clear fix - thanks.

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 7320b8e..0e07733.

> The code can be examined at:
> https://github.com/EvanLloyd/tianocore/tree/initialize_cnthctl_v1
> 
> 
> Sami Mujawar (2):
>   ArmPkg: Add CNTHCTL_EL2 support functions
>   ArmPlatformPkg: Timer access for non-secure EL1/0
> 
>  ArmPkg/Include/Chipset/AArch64.h               | 12 +++++++++++-
>  ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c       |  9 ++++++++-
>  ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 10 ++++++++++
>  ArmPlatformPkg/PrePeiCore/AArch64/Helper.S     |  9 ++++++++-
>  4 files changed, 37 insertions(+), 3 deletions(-)
> 
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel