[edk2] [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify

Ruiyu Ni posted 1 patch 8 years, 5 months ago
Failed in applying to current master (apply log)
MdePkg/Include/Protocol/ResetNotification.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2] [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify
Posted by Ruiyu Ni 8 years, 5 months ago
UEFI Spec uses UnRegisterResetNotify in protocol structure
definition but uses UnregisterResetNotify in the function
prototype definition.

By searching the entire spec, Unregister* is used for
SIMPLE_TEXT_INPUT_EX_PROTOCOL.UnregisterKeyNotify(). So choose
to use UnregisterResetNotify for consistency.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
---
 MdePkg/Include/Protocol/ResetNotification.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/ResetNotification.h b/MdePkg/Include/Protocol/ResetNotification.h
index ade0eee34a..f2834f9ee1 100644
--- a/MdePkg/Include/Protocol/ResetNotification.h
+++ b/MdePkg/Include/Protocol/ResetNotification.h
@@ -76,7 +76,7 @@ EFI_STATUS
 
 typedef struct _EFI_RESET_NOTIFICATION_PROTOCOL {
   EFI_REGISTER_RESET_NOTIFY   RegisterResetNotify;
-  EFI_UNREGISTER_RESET_NOTIFY UnRegisterResetNotify;
+  EFI_UNREGISTER_RESET_NOTIFY UnregisterResetNotify;
 } EFI_RESET_NOTIFICATION_PROTOCOL;
 
 
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] MdePkg/ResetNotification: Rename to UnregisterResetNotify
Posted by Gao, Liming 8 years, 4 months ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Ni, Ruiyu
>Sent: Wednesday, July 19, 2017 5:15 PM
>To: edk2-devel@lists.01.org
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: [PATCH] MdePkg/ResetNotification: Rename to
>UnregisterResetNotify
>
>UEFI Spec uses UnRegisterResetNotify in protocol structure
>definition but uses UnregisterResetNotify in the function
>prototype definition.
>
>By searching the entire spec, Unregister* is used for
>SIMPLE_TEXT_INPUT_EX_PROTOCOL.UnregisterKeyNotify(). So choose
>to use UnregisterResetNotify for consistency.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>---
> MdePkg/Include/Protocol/ResetNotification.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdePkg/Include/Protocol/ResetNotification.h
>b/MdePkg/Include/Protocol/ResetNotification.h
>index ade0eee34a..f2834f9ee1 100644
>--- a/MdePkg/Include/Protocol/ResetNotification.h
>+++ b/MdePkg/Include/Protocol/ResetNotification.h
>@@ -76,7 +76,7 @@ EFI_STATUS
>
> typedef struct _EFI_RESET_NOTIFICATION_PROTOCOL {
>   EFI_REGISTER_RESET_NOTIFY   RegisterResetNotify;
>-  EFI_UNREGISTER_RESET_NOTIFY UnRegisterResetNotify;
>+  EFI_UNREGISTER_RESET_NOTIFY UnregisterResetNotify;
> } EFI_RESET_NOTIFICATION_PROTOCOL;
>
>
>--
>2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel