Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"

[edk2] [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"

Posted by Laszlo Ersek 7 years, 4 months ago

This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:

TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
option in GCC tool chain", 2017-08-23), so we can return to the GCC5
toolchain with gcc-7.*.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 5868d3b8c498..682155202564 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -102,7 +102,7 @@ case `uname` in
       4.8.*)
         TARGET_TOOLS=GCC48
         ;;
-      4.9.*|6.[0-2].*|7.*)
+      4.9.*|6.[0-2].*)
         TARGET_TOOLS=GCC49
         ;;
       *)
-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"

Posted by Jordan Justen 7 years, 4 months ago

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2017-08-25 02:34:54, Laszlo Ersek wrote:
> This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
> 
> TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
> been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
> option in GCC tool chain", 2017-08-23), so we can return to the GCC5
> toolchain with gcc-7.*.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 5868d3b8c498..682155202564 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -102,7 +102,7 @@ case `uname` in
>        4.8.*)
>          TARGET_TOOLS=GCC48
>          ;;
> -      4.9.*|6.[0-2].*|7.*)
> +      4.9.*|6.[0-2].*)
>          TARGET_TOOLS=GCC49
>          ;;
>        *)
> -- 
> 2.14.1.3.gb7cf6e02401b
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] Revert "OvmfPkg/build.sh: select the GCC49 toolchain settings for gcc-7.*"

Posted by Laszlo Ersek 7 years, 4 months ago

On 08/25/17 17:42, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Thank you, pushed as commit 656ac0c7d8ea.

Laszlo

> On 2017-08-25 02:34:54, Laszlo Ersek wrote:
>> This reverts commit ca56256d5e0b7e63325b049e90a6bd03f90e3598:
>>
>> TianoCore BZ#671 <https://bugzilla.tianocore.org/show_bug.cgi?id=671> has
>> been fixed in commit 2f7f1e73c10f ("BaseTools: Add the missing -pie link
>> option in GCC tool chain", 2017-08-23), so we can return to the GCC5
>> toolchain with gcc-7.*.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/build.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 5868d3b8c498..682155202564 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -102,7 +102,7 @@ case `uname` in
>>        4.8.*)
>>          TARGET_TOOLS=GCC48
>>          ;;
>> -      4.9.*|6.[0-2].*|7.*)
>> +      4.9.*|6.[0-2].*)
>>          TARGET_TOOLS=GCC49
>>          ;;
>>        *)
>> -- 
>> 2.14.1.3.gb7cf6e02401b
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel