MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it

[edk2] [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it

Posted by Laszlo Ersek 7 years, 3 months ago

Repo:   https://github.com/lersek/edk2.git
Branch: debugprint_iofifo

The first patch (for MdePkg) fixes an assembly language operand ordering
oversight in the unrolled / SEV implementations of IoWriteFifoXX().

The second patch makes OvmfPkg use IoWriteFifo8() for printing DEBUG
messages and ASSERT() failures.

Thanks,
Laszlo

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Laszlo Ersek (2):
  MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of
    IoWriteFifoXX()
  OvmfPkg/PlatformDebugLibIoPort: write messages with IoWriteFifo8()

 OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c     | 20 ++++++++------------
 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm |  6 +++---
 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm  |  6 +++---
 3 files changed, 14 insertions(+), 18 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] MdePkg, OvmfPkg: fix IoWriteFifo8(), and print debug messages with it

Posted by Laszlo Ersek 7 years, 3 months ago

On 09/04/17 17:57, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: debugprint_iofifo
> 
> The first patch (for MdePkg) fixes an assembly language operand ordering
> oversight in the unrolled / SEV implementations of IoWriteFifoXX().
> 
> The second patch makes OvmfPkg use IoWriteFifo8() for printing DEBUG
> messages and ASSERT() failures.
> 
> Thanks,
> Laszlo
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Laszlo Ersek (2):
>   MdePkg/BaseIoLibIntrinsic: fix SEV (=unrolled) variants of
>     IoWriteFifoXX()
>   OvmfPkg/PlatformDebugLibIoPort: write messages with IoWriteFifo8()
> 
>  OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c     | 20 ++++++++------------
>  MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm |  6 +++---
>  MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm  |  6 +++---
>  3 files changed, 14 insertions(+), 18 deletions(-)
> 

Thanks for the feedback, pushed as aa9aa47e06ac..80886a695377.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel