[edk2] [PATCH 0/2] Options to remove code

evan.lloyd@arm.com posted 2 patches 7 years, 3 months ago
Failed in applying to current master (apply log)
ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
[edk2] [PATCH 0/2] Options to remove code
Posted by evan.lloyd@arm.com 7 years, 3 months ago
From: EvanLloyd <evan.lloyd@arm.com>

There are a number of cases where it is desirable to remove unused code.
An obvious instance might be on an emulator, where executing irrelevant
code can add hours to the boot time.  This change enables removal of
some code that might not be relevant, using build options that can be
configured in the platform build.

Sami (1):
  ArmPlatformPkg: Juno networking build option

Sami Mujawar (1):
  ArmPlatformPkg: Remove DT code when unsupported

 ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/2] Options to remove code
Posted by Leif Lindholm 7 years, 3 months ago
Hi Evan,

On Wed, Sep 13, 2017 at 07:16:19PM +0100, evan.lloyd@arm.com wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
> 
> There are a number of cases where it is desirable to remove unused code.
> An obvious instance might be on an emulator, where executing irrelevant
> code can add hours to the boot time.  This change enables removal of
> some code that might not be relevant, using build options that can be
> configured in the platform build.

In principle, I'm fine with this change.

However, I would have expected a companion patch to this (for
edk2-platforms) to add a CFLAGS statement to the platform build if
some build option was specified with -D. Or am I missing some way of
doing this directly on the build command line?

Also, this patch by Sami

> Sami (1):
>   ArmPlatformPkg: Juno networking build option

and this patch by Sami

> Sami Mujawar (1):
>   ArmPlatformPkg: Remove DT code when unsupported

have different author names, which also confuses this cover letter
somewhat.

/
    Leif

>  ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> -- 
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel