MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 20 +- MdeModulePkg/Universal/Disk/UdfDxe/File.c | 5 +- MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 27 +- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 +++++++++++++++----- MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 49 +- 5 files changed, 432 insertions(+), 152 deletions(-)
The series introduces the following code refinements for UdfDxe & PartitionDxe: a. Add checks to ensure no possible NULL pointer dereference b. Reslove operands of different size in bitwise operations c. Use compare operator for non-boolean comparisons d. Refine function description comments e. Refine local variable initialization f. Refine enum members naming style Cc: Paulo Alcantara <pcacjr@zytor.com> Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Dandan Bi <dandan.bi@intel.com> Hao Wu (7): MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP MdeModulePkg/UdfDxe: Use compare operator for non-boolean comparisons MdeModulePkg/Udf: Refine function description comments MdeModulePkg/UdfDxe: Avoid short (single character) variable name MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable MdeModulePkg/UdfDxe: Refine enum member naming style MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 20 +- MdeModulePkg/Universal/Disk/UdfDxe/File.c | 5 +- MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 27 +- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 +++++++++++++++----- MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 49 +- 5 files changed, 432 insertions(+), 152 deletions(-) -- 2.12.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Hi Hao, On 15/09/2017 01:57, Hao Wu wrote: > The series introduces the following code refinements for UdfDxe & > PartitionDxe: > > a. Add checks to ensure no possible NULL pointer dereference > b. Reslove operands of different size in bitwise operations > c. Use compare operator for non-boolean comparisons > d. Refine function description comments > e. Refine local variable initialization > f. Refine enum members naming style > > Cc: Paulo Alcantara <pcacjr@zytor.com> > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > Cc: Dandan Bi <dandan.bi@intel.com> > > Hao Wu (7): > MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref > MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP > MdeModulePkg/UdfDxe: Use compare operator for non-boolean comparisons > MdeModulePkg/Udf: Refine function description comments > MdeModulePkg/UdfDxe: Avoid short (single character) variable name > MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable > MdeModulePkg/UdfDxe: Refine enum member naming style > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 20 +- > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 5 +- > MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 27 +- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 +++++++++++++++----- > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 49 +- > 5 files changed, 432 insertions(+), 152 deletions(-) Looks good to me. Also tested it with OVMF X64. Thanks! Reviewed-by: Paulo Alcantara <pcacjr@zytor.com> Paulo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Thanks for keeping improving the UDF code. Reviewed-by: Star Zeng <star.zeng@intel.com> Hao, you may push this patch series first, after that, could you help kindly check whether are there similar issues with the new patch series at https://lists.01.org/pipermail/edk2-devel/2017-September/014791.html? Thanks, Star -----Original Message----- From: Paulo Alcantara [mailto:pcacjr@zytor.com] Sent: Saturday, September 16, 2017 5:47 AM To: Wu, Hao A <hao.a.wu@intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com> Subject: Re: [PATCH 0/7] MdeModulePkg/Udf: Code refinements Hi Hao, On 15/09/2017 01:57, Hao Wu wrote: > The series introduces the following code refinements for UdfDxe & > PartitionDxe: > > a. Add checks to ensure no possible NULL pointer dereference b. > Reslove operands of different size in bitwise operations c. Use > compare operator for non-boolean comparisons d. Refine function > description comments e. Refine local variable initialization f. Refine > enum members naming style > > Cc: Paulo Alcantara <pcacjr@zytor.com> > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > Cc: Dandan Bi <dandan.bi@intel.com> > > Hao Wu (7): > MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref > MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP > MdeModulePkg/UdfDxe: Use compare operator for non-boolean comparisons > MdeModulePkg/Udf: Refine function description comments > MdeModulePkg/UdfDxe: Avoid short (single character) variable name > MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable > MdeModulePkg/UdfDxe: Refine enum member naming style > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 20 +- > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 5 +- > MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 27 +- > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 +++++++++++++++----- > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 49 +- > 5 files changed, 432 insertions(+), 152 deletions(-) Looks good to me. Also tested it with OVMF X64. Thanks! Reviewed-by: Paulo Alcantara <pcacjr@zytor.com> Paulo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Sure, I will keep an eye on the changes in UDF-related code. Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, September 19, 2017 11:31 AM > To: Paulo Alcantara; Wu, Hao A; edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Dong, Eric; Bi, Dandan; Zeng, Star > Subject: RE: [PATCH 0/7] MdeModulePkg/Udf: Code refinements > > Thanks for keeping improving the UDF code. > Reviewed-by: Star Zeng <star.zeng@intel.com> > > Hao, you may push this patch series first, after that, could you help kindly check > whether are there similar issues with the new patch series at > https://lists.01.org/pipermail/edk2-devel/2017-September/014791.html? > > > Thanks, > Star > -----Original Message----- > From: Paulo Alcantara [mailto:pcacjr@zytor.com] > Sent: Saturday, September 16, 2017 5:47 AM > To: Wu, Hao A <hao.a.wu@intel.com>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, > Eric <eric.dong@intel.com>; Bi, Dandan <dandan.bi@intel.com> > Subject: Re: [PATCH 0/7] MdeModulePkg/Udf: Code refinements > > Hi Hao, > > On 15/09/2017 01:57, Hao Wu wrote: > > The series introduces the following code refinements for UdfDxe & > > PartitionDxe: > > > > a. Add checks to ensure no possible NULL pointer dereference b. > > Reslove operands of different size in bitwise operations c. Use > > compare operator for non-boolean comparisons d. Refine function > > description comments e. Refine local variable initialization f. Refine > > enum members naming style > > > > Cc: Paulo Alcantara <pcacjr@zytor.com> > > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > > Cc: Star Zeng <star.zeng@intel.com> > > Cc: Eric Dong <eric.dong@intel.com> > > Cc: Dandan Bi <dandan.bi@intel.com> > > > > Hao Wu (7): > > MdeModulePkg/UdfDxe: Add checks to ensure no possible NULL ptr deref > > MdeModulePkg/UdfDxe: Fix operands of different size in bitwise OP > > MdeModulePkg/UdfDxe: Use compare operator for non-boolean > comparisons > > MdeModulePkg/Udf: Refine function description comments > > MdeModulePkg/UdfDxe: Avoid short (single character) variable name > > MdeModulePkg/Udf: Avoid declaring and initializing local GUID variable > > MdeModulePkg/UdfDxe: Refine enum member naming style > > > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 20 +- > > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 5 +- > > MdeModulePkg/Universal/Disk/UdfDxe/FileName.c | 27 +- > > MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 483 > +++++++++++++++----- > > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 49 +- > > 5 files changed, 432 insertions(+), 152 deletions(-) > Looks good to me. Also tested it with OVMF X64. Thanks! > > Reviewed-by: Paulo Alcantara <pcacjr@zytor.com> > > Paulo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.