[edk2] [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown

Laszlo Ersek posted 2 patches 7 years, 3 months ago
[edk2] [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown
Posted by Laszlo Ersek 7 years, 3 months ago
Document the following actions on the

  EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized

state transitions:

* from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using
  AllocateSharedPages()", 2017-09-14):

  VirtioNetInitRx ->
  { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }

  VirtioNetShutdownRx ->
  { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }

* from commit 891f016c1b99 ("OvmfPkg/VirtioNetDxe: dynamically alloc
  transmit header", 2017-09-14):

  VirtioNetInitTx ->
  { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }

  VirtioNetShutdownTx ->
  { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/OvmfPkg/VirtioNetDxe/TechNotes.txt b/OvmfPkg/VirtioNetDxe/TechNotes.txt
index 40a22f66dc22..cd38750a4afb 100644
--- a/OvmfPkg/VirtioNetDxe/TechNotes.txt
+++ b/OvmfPkg/VirtioNetDxe/TechNotes.txt
@@ -69,10 +69,14 @@ faithfully indented) that implement the transition.
   [SnpInitialize.c]            |  | [SnpShutdown.c]
   VirtioNetInitialize          |  | VirtioNetShutdown
     VirtioNetInitRing {Rx, Tx} |  |   VirtioNetShutdownRx [SnpSharedHelpers.c]
-      VirtioRingInit           |  |   VirtioNetShutdownTx [SnpSharedHelpers.c]
-      VirtioRingMap            |  |   VirtioNetUninitRing [SnpSharedHelpers.c]
-    VirtioNetInitTx            |  |                       {Tx, Rx}
-    VirtioNetInitRx            |  |     VirtIo->UnmapSharedBuffer
+      VirtioRingInit           |  |     VirtIo->UnmapSharedBuffer
+      VirtioRingMap            |  |     VirtIo->FreeSharedPages
+    VirtioNetInitTx            |  |   VirtioNetShutdownTx [SnpSharedHelpers.c]
+      VirtIo->AllocateShare... |  |     VirtIo->UnmapSharedBuffer
+      VirtioMapAllBytesInSh... |  |     VirtIo->FreeSharedPages
+    VirtioNetInitRx            |  |   VirtioNetUninitRing [SnpSharedHelpers.c]
+      VirtIo->AllocateShare... |  |                       {Tx, Rx}
+      VirtioMapAllBytesInSh... |  |     VirtIo->UnmapSharedBuffer
                                |  |     VirtioRingUninit
                                v  |
                   +-----------------------------+
-- 
2.14.1.3.gb7cf6e02401b


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 1/2] OvmfPkg/VirtioNetDxe: document Rx/Tx allocs and mappings on Init/Shutdown
Posted by Brijesh Singh 7 years, 3 months ago

On 09/15/2017 03:57 AM, Laszlo Ersek wrote:
> Document the following actions on the
> 
>    EfiSimpleNetworkStarted <-> EfiSimpleNetworkInitialized
> 
> state transitions:
> 
> * from commit 46b11f00ac70 ("OvmfPkg/VirtioNetDxe: alloc RxBuf using
>    AllocateSharedPages()", 2017-09-14):
> 
>    VirtioNetInitRx ->
>    { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }
> 
>    VirtioNetShutdownRx ->
>    { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }
> 
> * from commit 891f016c1b99 ("OvmfPkg/VirtioNetDxe: dynamically alloc
>    transmit header", 2017-09-14):
> 
>    VirtioNetInitTx ->
>    { VirtIo->AllocateSharedPages, VirtioMapAllBytesInSharedBuffer }
> 
>    VirtioNetShutdownTx ->
>    { VirtIo->UnmapSharedBuffer, VirtIo->FreeSharedPages }
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   OvmfPkg/VirtioNetDxe/TechNotes.txt | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel