1. Patchew
  2. EDK2
  3. View series

[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

Jian J Wang posted 1 patch 7 years, 3 months ago
Failed in applying to current master (apply log)
UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
[edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153
Posted by Jian J Wang 7 years, 3 months ago 
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Suggested-by: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c b/UefiCpuPkg/CpuDxe/CpuPageTable.c
index ae93f3f553..d312eb66f8 100644
--- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
+++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
@@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging (
 
   GetCurrentPagingContext (&PagingContext);
 
-  BaseAddress = 0;
-  PageLength  = 0;
+  DoUpdate      = FALSE;
+  Capabilities  = 0;
+  Attributes    = 0;
+  BaseAddress   = 0;
+  PageLength    = 0;
+
   for (Index = 0; Index < NumberOfDescriptors; Index++) {
     if (MemorySpaceMap[Index].GcdMemoryType == EfiGcdMemoryTypeNonExistent) {
       continue;
-- 
2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153
Posted by Wu, Hao A 7 years, 3 months ago 
One minor comment, please shorten the subject of the patch.

Maybe like:
UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54

With that change,
Reviewed-by: Hao Wu <hao.a.wu@intel.com>


Best Regards,
Hao Wu

> -----Original Message-----
> From: Wang, Jian J
> Sent: Friday, September 22, 2017 10:15 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Anthony PERARD
> Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit
> c1cab54ce57c2608b8b3ea051c7041f036f21153
> 
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Suggested-by: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> index ae93f3f553..d312eb66f8 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging (
> 
>    GetCurrentPagingContext (&PagingContext);
> 
> -  BaseAddress = 0;
> -  PageLength  = 0;
> +  DoUpdate      = FALSE;
> +  Capabilities  = 0;
> +  Attributes    = 0;
> +  BaseAddress   = 0;
> +  PageLength    = 0;
> +
>    for (Index = 0; Index < NumberOfDescriptors; Index++) {
>      if (MemorySpaceMap[Index].GcdMemoryType ==
> EfiGcdMemoryTypeNonExistent) {
>        continue;
> --
> 2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153
Posted by Wang, Jian J 7 years, 3 months ago 
Ok, thanks for the review.

-----Original Message-----
From: Wu, Hao A 
Sent: Friday, September 22, 2017 11:21 AM
To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
Cc: Anthony PERARD <anthony.perard@citrix.com>
Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153

One minor comment, please shorten the subject of the patch.

Maybe like:
UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54

With that change,
Reviewed-by: Hao Wu <hao.a.wu@intel.com>


Best Regards,
Hao Wu

> -----Original Message-----
> From: Wang, Jian J
> Sent: Friday, September 22, 2017 10:15 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Anthony PERARD
> Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit
> c1cab54ce57c2608b8b3ea051c7041f036f21153
> 
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Suggested-by: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> index ae93f3f553..d312eb66f8 100644
> --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging (
> 
>    GetCurrentPagingContext (&PagingContext);
> 
> -  BaseAddress = 0;
> -  PageLength  = 0;
> +  DoUpdate      = FALSE;
> +  Capabilities  = 0;
> +  Attributes    = 0;
> +  BaseAddress   = 0;
> +  PageLength    = 0;
> +
>    for (Index = 0; Index < NumberOfDescriptors; Index++) {
>      if (MemorySpaceMap[Index].GcdMemoryType ==
> EfiGcdMemoryTypeNonExistent) {
>        continue;
> --
> 2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54ce57c2608b8b3ea051c7041f036f21153
Posted by Wu, Hao A 7 years, 3 months ago 
After altering the commit logs, push at:
96207191fd715e268c6ba6d6ac8650ef914e1686


Best Regards,
Hao Wu


> -----Original Message-----
> From: Wang, Jian J
> Sent: Friday, September 22, 2017 11:34 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Anthony PERARD
> Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit
> c1cab54ce57c2608b8b3ea051c7041f036f21153
> 
> Ok, thanks for the review.
> 
> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, September 22, 2017 11:21 AM
> To: Wang, Jian J <jian.j.wang@intel.com>; edk2-devel@lists.01.org
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Subject: RE: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit
> c1cab54ce57c2608b8b3ea051c7041f036f21153
> 
> One minor comment, please shorten the subject of the patch.
> 
> Maybe like:
> UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54
> 
> With that change,
> Reviewed-by: Hao Wu <hao.a.wu@intel.com>
> 
> 
> Best Regards,
> Hao Wu
> 
> > -----Original Message-----
> > From: Wang, Jian J
> > Sent: Friday, September 22, 2017 10:15 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A; Anthony PERARD
> > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit
> > c1cab54ce57c2608b8b3ea051c7041f036f21153
> >
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Cc: Anthony PERARD <anthony.perard@citrix.com>
> > Suggested-by: Jiewen Yao <jiewen.yao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> > ---
> >  UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> > b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> > index ae93f3f553..d312eb66f8 100644
> > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c
> > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c
> > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging (
> >
> >    GetCurrentPagingContext (&PagingContext);
> >
> > -  BaseAddress = 0;
> > -  PageLength  = 0;
> > +  DoUpdate      = FALSE;
> > +  Capabilities  = 0;
> > +  Attributes    = 0;
> > +  BaseAddress   = 0;
> > +  PageLength    = 0;
> > +
> >    for (Index = 0; Index < NumberOfDescriptors; Index++) {
> >      if (MemorySpaceMap[Index].GcdMemoryType ==
> > EfiGcdMemoryTypeNonExistent) {
> >        continue;
> > --
> > 2.14.1.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.