[edk2] [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly

Ruiyu Ni posted 2 patches 7 years, 2 months ago
[edk2] [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly
Posted by Ruiyu Ni 7 years, 2 months ago
From: Huajing Li <huajing.li@intel.com>

The current implementation has a typo that maps SmmPciRootBridgeIo
to "PciRootBridgeIo".

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Huajing Li <huajing.li@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
 ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 06f9d26e5f..489decfaf8 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -2229,7 +2229,7 @@ STATIC CONST GUID_INFO_BLOCK mGuidStringList[] = {
   {STRING_TOKEN(STR_S_COMM),                &gEfiSmmCommunicationProtocolGuid,                NULL},
   {STRING_TOKEN(STR_S_STAT),                &gEfiSmmStatusCodeProtocolGuid,                   NULL},
   {STRING_TOKEN(STR_S_CPU),                 &gEfiSmmCpuProtocolGuid,                          NULL},
-  {STRING_TOKEN(STR_S_PCIRBIO),             &gEfiPciRootBridgeIoProtocolGuid,                 NULL},
+  {STRING_TOKEN(STR_S_PCIRBIO),             &gEfiSmmPciRootBridgeIoProtocolGuid,              NULL},
   {STRING_TOKEN(STR_S_SWD),                 &gEfiSmmSwDispatch2ProtocolGuid,                  NULL},
   {STRING_TOKEN(STR_S_SXD),                 &gEfiSmmSxDispatch2ProtocolGuid,                  NULL},
   {STRING_TOKEN(STR_S_PTD2),                &gEfiSmmPeriodicTimerDispatch2ProtocolGuid,       NULL},
-- 
2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly
Posted by Carsey, Jaben 7 years, 2 months ago
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 11:37 PM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing.li@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Subject: [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map
> SmmPciRootBridgeIo correctly
> Importance: High
> 
> From: Huajing Li <huajing.li@intel.com>
> 
> The current implementation has a typo that maps SmmPciRootBridgeIo
> to "PciRootBridgeIo".
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Huajing Li <huajing.li@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 06f9d26e5f..489decfaf8 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -2229,7 +2229,7 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[] = {
>    {STRING_TOKEN(STR_S_COMM),
> &gEfiSmmCommunicationProtocolGuid,                NULL},
>    {STRING_TOKEN(STR_S_STAT),                &gEfiSmmStatusCodeProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_S_CPU),                 &gEfiSmmCpuProtocolGuid,
> NULL},
> -  {STRING_TOKEN(STR_S_PCIRBIO),
> &gEfiPciRootBridgeIoProtocolGuid,                 NULL},
> +  {STRING_TOKEN(STR_S_PCIRBIO),
> &gEfiSmmPciRootBridgeIoProtocolGuid,              NULL},
>    {STRING_TOKEN(STR_S_SWD),
> &gEfiSmmSwDispatch2ProtocolGuid,                  NULL},
>    {STRING_TOKEN(STR_S_SXD),                 &gEfiSmmSxDispatch2ProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_S_PTD2),
> &gEfiSmmPeriodicTimerDispatch2ProtocolGuid,       NULL},
> --
> 2.12.2.windows.2

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel