Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 34 +++++++++++++++++++++++++++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
index 9e617b8e6991..dc84dd32d24a 100644
--- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
+++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
@@ -1,7 +1,7 @@
/** @file
HOB Library implemenation for Dxe Phase with DebugLib dependency removed
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -442,6 +442,38 @@ BuildFv2Hob (
ASSERT (FALSE);
}
+/**
+ Builds a EFI_HOB_TYPE_FV3 HOB.
+
+ This function builds a EFI_HOB_TYPE_FV3 HOB.
+ It can only be invoked during PEI phase;
+ for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
+
+ If there is no additional space for HOB creation, then ASSERT().
+ If the FvImage buffer is not at its required alignment, then ASSERT().
+
+ @param BaseAddress The base address of the Firmware Volume.
+ @param Length The size of the Firmware Volume in bytes.
+ @param AuthenticationStatus The authentication status.
+ @param ExtractedFv TRUE if the FV was extracted as a file within another firmware volume.
+ FALSE otherwise.
+ @param FvName The name of the Firmware Volume. Valid only if IsExtractedFv is TRUE
+ @param FileName The name of the file. Valid only if IsExtractedFv is TRUE
+
+**/
+VOID
+EFIAPI
+BuildFv3Hob (
+ IN EFI_PHYSICAL_ADDRESS BaseAddress,
+ IN UINT64 Length,
+ IN UINT32 AuthenticationStatus,
+ IN BOOLEAN ExtractedFv,
+ IN CONST EFI_GUID *FvName, OPTIONAL
+ IN CONST EFI_GUID *FileName OPTIONAL
+ )
+{
+ ASSERT (FALSE);
+}
/**
Builds a Capsule Volume HOB.
--
2.13.3.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
On 5 October 2017 at 07:33, Star Zeng <star.zeng@intel.com> wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 34 +++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> index 9e617b8e6991..dc84dd32d24a 100644
> --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> @@ -1,7 +1,7 @@
> /** @file
> HOB Library implemenation for Dxe Phase with DebugLib dependency removed
>
> -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -442,6 +442,38 @@ BuildFv2Hob (
> ASSERT (FALSE);
> }
>
> +/**
> + Builds a EFI_HOB_TYPE_FV3 HOB.
> +
> + This function builds a EFI_HOB_TYPE_FV3 HOB.
> + It can only be invoked during PEI phase;
> + for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
> +
> + If there is no additional space for HOB creation, then ASSERT().
> + If the FvImage buffer is not at its required alignment, then ASSERT().
> +
> + @param BaseAddress The base address of the Firmware Volume.
> + @param Length The size of the Firmware Volume in bytes.
> + @param AuthenticationStatus The authentication status.
> + @param ExtractedFv TRUE if the FV was extracted as a file within another firmware volume.
> + FALSE otherwise.
> + @param FvName The name of the Firmware Volume. Valid only if IsExtractedFv is TRUE
> + @param FileName The name of the file. Valid only if IsExtractedFv is TRUE
> +
Could we keep line lengths below 80 columns please? Same for the previous patch.
> +**/
> +VOID
> +EFIAPI
> +BuildFv3Hob (
> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
> + IN UINT64 Length,
> + IN UINT32 AuthenticationStatus,
> + IN BOOLEAN ExtractedFv,
> + IN CONST EFI_GUID *FvName, OPTIONAL
> + IN CONST EFI_GUID *FileName OPTIONAL
> + )
> +{
> + ASSERT (FALSE);
> +}
>
> /**
> Builds a Capsule Volume HOB.
> --
> 2.13.3.windows.1
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Hi Star,
On 10/05/17 09:56, Ard Biesheuvel wrote:
> On 5 October 2017 at 07:33, Star Zeng <star.zeng@intel.com> wrote:
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Star Zeng <star.zeng@intel.com>
>> ---
>> ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 34 +++++++++++++++++++++++++++-
>> 1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> index 9e617b8e6991..dc84dd32d24a 100644
>> --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> @@ -1,7 +1,7 @@
>> /** @file
>> HOB Library implemenation for Dxe Phase with DebugLib dependency removed
>>
>> -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
>> Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
>> This program and the accompanying materials
>> are licensed and made available under the terms and conditions of the BSD License
>> @@ -442,6 +442,38 @@ BuildFv2Hob (
>> ASSERT (FALSE);
>> }
>>
>> +/**
>> + Builds a EFI_HOB_TYPE_FV3 HOB.
>> +
>> + This function builds a EFI_HOB_TYPE_FV3 HOB.
>> + It can only be invoked during PEI phase;
>> + for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
>> +
>> + If there is no additional space for HOB creation, then ASSERT().
>> + If the FvImage buffer is not at its required alignment, then ASSERT().
>> +
>> + @param BaseAddress The base address of the Firmware Volume.
>> + @param Length The size of the Firmware Volume in bytes.
>> + @param AuthenticationStatus The authentication status.
>> + @param ExtractedFv TRUE if the FV was extracted as a file within another firmware volume.
>> + FALSE otherwise.
>> + @param FvName The name of the Firmware Volume. Valid only if IsExtractedFv is TRUE
>> + @param FileName The name of the file. Valid only if IsExtractedFv is TRUE
>> +
>
> Could we keep line lengths below 80 columns please? Same for the previous patch.
I agree; please rewrap the comment block like that.
>> +**/
>> +VOID
>> +EFIAPI
>> +BuildFv3Hob (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINT64 Length,
>> + IN UINT32 AuthenticationStatus,
>> + IN BOOLEAN ExtractedFv,
>> + IN CONST EFI_GUID *FvName, OPTIONAL
>> + IN CONST EFI_GUID *FileName OPTIONAL
>> + )
>> +{
>> + ASSERT (FALSE);
>> +}
The implementation looks good, this library instance is restricted to
"DXE and later" modules, and HOB production finishes with the PEI phase
-- DXE and later are not allowed to produce HOBs. So this follows the
rest of the HOB-building functions in this library instance.
With the line lengths adjusted, for this patch:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks for the quick followup!
Laszlo
>>
>> /**
>> Builds a Capsule Volume HOB.
>> --
>> 2.13.3.windows.1
>>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Agree and thanks for Laslzo's RB (added in V2 patch series).
Please help check the V2 patch series at https://lists.01.org/pipermail/edk2-devel/2017-October/015628.html.
Thanks,
Star
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com]
Sent: Thursday, October 5, 2017 4:06 PM
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zeng, Star <star.zeng@intel.com>
Cc: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>
Subject: Re: [PATCH 2/2] ArmVirtPkg ArmVirtDxeHobLib: Implement BuildFv3Hob
Hi Star,
On 10/05/17 09:56, Ard Biesheuvel wrote:
> On 5 October 2017 at 07:33, Star Zeng <star.zeng@intel.com> wrote:
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Star Zeng <star.zeng@intel.com>
>> ---
>> ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 34
>> +++++++++++++++++++++++++++-
>> 1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> index 9e617b8e6991..dc84dd32d24a 100644
>> --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
>> @@ -1,7 +1,7 @@
>> /** @file
>> HOB Library implemenation for Dxe Phase with DebugLib dependency
>> removed
>>
>> -Copyright (c) 2006 - 2016, Intel Corporation. All rights
>> reserved.<BR>
>> +Copyright (c) 2006 - 2017, Intel Corporation. All rights
>> +reserved.<BR>
>> Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR> This
>> program and the accompanying materials are licensed and made
>> available under the terms and conditions of the BSD License @@ -442,6
>> +442,38 @@ BuildFv2Hob (
>> ASSERT (FALSE);
>> }
>>
>> +/**
>> + Builds a EFI_HOB_TYPE_FV3 HOB.
>> +
>> + This function builds a EFI_HOB_TYPE_FV3 HOB.
>> + It can only be invoked during PEI phase; for DXE phase, it will
>> + ASSERT() since PEI HOB is read-only for DXE phase.
>> +
>> + If there is no additional space for HOB creation, then ASSERT().
>> + If the FvImage buffer is not at its required alignment, then ASSERT().
>> +
>> + @param BaseAddress The base address of the Firmware Volume.
>> + @param Length The size of the Firmware Volume in bytes.
>> + @param AuthenticationStatus The authentication status.
>> + @param ExtractedFv TRUE if the FV was extracted as a file within another firmware volume.
>> + FALSE otherwise.
>> + @param FvName The name of the Firmware Volume. Valid only if IsExtractedFv is TRUE
>> + @param FileName The name of the file. Valid only if IsExtractedFv is TRUE
>> +
>
> Could we keep line lengths below 80 columns please? Same for the previous patch.
I agree; please rewrap the comment block like that.
>> +**/
>> +VOID
>> +EFIAPI
>> +BuildFv3Hob (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINT64 Length,
>> + IN UINT32 AuthenticationStatus,
>> + IN BOOLEAN ExtractedFv,
>> + IN CONST EFI_GUID *FvName, OPTIONAL
>> + IN CONST EFI_GUID *FileName OPTIONAL
>> + )
>> +{
>> + ASSERT (FALSE);
>> +}
The implementation looks good, this library instance is restricted to "DXE and later" modules, and HOB production finishes with the PEI phase
-- DXE and later are not allowed to produce HOBs. So this follows the rest of the HOB-building functions in this library instance.
With the line lengths adjusted, for this patch:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks for the quick followup!
Laszlo
>>
>> /**
>> Builds a Capsule Volume HOB.
>> --
>> 2.13.3.windows.1
>>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
© 2016 - 2024 Red Hat, Inc.