From nobody Wed Dec 25 02:28:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1510648923529842.726957878469; Tue, 14 Nov 2017 00:42:03 -0800 (PST) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C0FBD20349DBB; Tue, 14 Nov 2017 00:37:54 -0800 (PST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EEF020349D90 for ; Tue, 14 Nov 2017 00:37:53 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2017 00:42:00 -0800 Received: from zyou1-mobl.ccr.corp.intel.com ([10.239.158.165]) by fmsmga002.fm.intel.com with ESMTP; 14 Nov 2017 00:41:35 -0800 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=benjamin.you@intel.com; receiver=edk2-devel@lists.01.org X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,393,1505804400"; d="scan'208";a="1243824117" From: Benjamin You To: edk2-devel@lists.01.org Date: Tue, 14 Nov 2017 16:41:13 +0800 Message-Id: <20171114084113.127904-1-benjamin.you@intel.com> X-Mailer: git-send-email 2.14.3.windows.1 Subject: [edk2] [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prince Agyeman MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GCD, CorebootModulePkg's CbSupportDxe should not do this again. Doing this again causes error return status from GCD service, and ASSERT (FALSE) with debug build, so the duplicated addition is removed. Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Benjamin You Reviewed-by: Maurice Ma --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModule= Pkg/CbSupportDxe/CbSupportDxe.c index 24bacf815c..c526c9e871 100755 --- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c +++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c @@ -140,9 +140,6 @@ CbDxeEntryPoint ( // // Report MMIO/IO Resources // - Status =3D CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo,= 0xFEE00000, SIZE_1MB, 0, SystemTable); // LAPIC - ASSERT_EFI_ERROR (Status); - Status =3D CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo,= 0xFEC00000, SIZE_4KB, 0, SystemTable); // IOAPIC ASSERT_EFI_ERROR (Status); =20 --=20 2.14.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel