ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class

[edk2] [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class

Posted by Ard Biesheuvel 6 years, 4 months ago

Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
instance) as LIBRARY_CLASS attribute.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
index 41c1d9638812..2cec9b970b5b 100644
--- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
+++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
@@ -18,7 +18,7 @@ [Defines]
   FILE_GUID                      = b78d02bb-d0b5-4389-bc7f-b39ee846c784
   MODULE_TYPE                    = BASE
   VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = LcdPlatformNullLib
+  LIBRARY_CLASS                  = LcdPlatformLib
 
 [Sources]
   LcdPlatformNullLib.c
-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class

Posted by Leif Lindholm 6 years, 4 months ago

On Fri, Dec 08, 2017 at 05:10:51PM +0000, Ard Biesheuvel wrote:
> Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
> instance) as LIBRARY_CLASS attribute.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Ah, oops.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---
>  ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> index 41c1d9638812..2cec9b970b5b 100644
> --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
> @@ -18,7 +18,7 @@ [Defines]
>    FILE_GUID                      = b78d02bb-d0b5-4389-bc7f-b39ee846c784
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
> -  LIBRARY_CLASS                  = LcdPlatformNullLib
> +  LIBRARY_CLASS                  = LcdPlatformLib
>  
>  [Sources]
>    LcdPlatformNullLib.c
> -- 
> 2.11.0
> 
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] ArmPlatformPkg/LcdPlatformNullLib: fix incorrect library class

Posted by Ard Biesheuvel 6 years, 4 months ago

On 8 December 2017 at 19:11, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Dec 08, 2017 at 05:10:51PM +0000, Ard Biesheuvel wrote:
>> Use LcdPlatformLib not LcdPlatformNullLib (which is the name of this
>> instance) as LIBRARY_CLASS attribute.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Ah, oops.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks. Pushed as  a5be96819fb66b5ce7a5251b6680c71b2dd459c1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel