MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

[edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

Posted by Fu Siyuan 7 years, 4 months ago

This patch updates the constructor of DpcLib to return error if failed to
locate DPC protocol.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
index 6eda8ca0fb..ddc3e0adda 100644
--- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
+++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
@@ -45,7 +45,7 @@ DpcLibConstructor (
   Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID **)&mDpc);
   ASSERT_EFI_ERROR (Status);
 
-  return EFI_SUCCESS;
+  return Status;
 }
 
 /**
-- 
2.13.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

Posted by Wu, Jiaxin 7 years, 4 months ago

Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu,
> Siyuan
> Sent: Friday, December 22, 2017 2:14 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Wang, Fan <fan.wang@intel.com>; Wu,
> Jiaxin <jiaxin.wu@intel.com>
> Subject: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to
> locate DPC protocol.
> 
> This patch updates the constructor of DpcLib to return error if failed to
> locate DPC protocol.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Wang Fan <fan.wang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> ---
>  MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> index 6eda8ca0fb..ddc3e0adda 100644
> --- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> +++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
> @@ -45,7 +45,7 @@ DpcLibConstructor (
>    Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID
> **)&mDpc);
>    ASSERT_EFI_ERROR (Status);
> 
> -  return EFI_SUCCESS;
> +  return Status;
>  }
> 
>  /**
> --
> 2.13.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

Posted by Wang, Fan 7 years, 4 months ago

Reviewed by Wang, Fan <fan.wang@intel.com>

-----Original Message-----
From: Fu, Siyuan 
Sent: Friday, December 22, 2017 2:14 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Wang, Fan <fan.wang@intel.com>
Subject: [Patch] MdeModulePkg/DpcLib: return error if failed to locate DPC protocol.

This patch updates the constructor of DpcLib to return error if failed to locate DPC protocol.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Wang Fan <fan.wang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
---
 MdeModulePkg/Library/DxeDpcLib/DpcLib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
index 6eda8ca0fb..ddc3e0adda 100644
--- a/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
+++ b/MdeModulePkg/Library/DxeDpcLib/DpcLib.c
@@ -45,7 +45,7 @@ DpcLibConstructor (
   Status = gBS->LocateProtocol (&gEfiDpcProtocolGuid, NULL, (VOID **)&mDpc);
   ASSERT_EFI_ERROR (Status);
 
-  return EFI_SUCCESS;
+  return Status;
 }
 
 /**
--
2.13.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel