[edk2] [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids

Leif Lindholm posted 6 patches 6 years, 10 months ago
Failed in applying to current master (apply log)
ArmPkg/Drivers/CpuDxe/CpuDxe.h                                      |   1 -
ArmPkg/Drivers/CpuDxe/CpuDxe.inf                                    |   2 -
ArmVirtPkg/ArmVirt.dsc.inc                                          |   2 -
BeagleBoardPkg/BeagleBoardPkg.dsc                                   |  18 -
BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c              |   6 +-
EmbeddedPkg/EmbeddedPkg.dec                                         |  17 -
EmbeddedPkg/EmbeddedPkg.dsc                                         |  15 -
EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h         |  42 -
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c          | 288 -------
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c              | 226 -----
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c | 198 -----
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c            |  63 --
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c              | 862 --------------------
EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c         | 306 -------
14 files changed, 1 insertion(+), 2045 deletions(-)
delete mode 100644 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c
delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c
[edk2] [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids
Posted by Leif Lindholm 6 years, 10 months ago
This series cleans up a set of unused Pcds, mostly related to Ebl,
that have been copied around to various platforms. With a single
exception they were all unused (but explicitly set, and hence
deleting their definitions caused build failure), and that
exception had a tiny conditional to excise.

As part of cleaning out that, I also found some other unused bits
to get rid of.

Leif Lindholm (6):
  ArmVirtPkg: drop unused PcdCacheEnable
  BeagleBoardPkg: drop unused EmbeddedPkg Pcds
  ArmPkg: delete references to unused guids/Pcds from CpuDxe
  EmbeddedPkg: drop unused Pcds from package .dsc
  EmbeddedPkg: delete unused HalRuntimeServicesExampleLib
  EmbeddedPkg: delete unused Pcds and guids

 ArmPkg/Drivers/CpuDxe/CpuDxe.h                                      |   1 -
 ArmPkg/Drivers/CpuDxe/CpuDxe.inf                                    |   2 -
 ArmVirtPkg/ArmVirt.dsc.inc                                          |   2 -
 BeagleBoardPkg/BeagleBoardPkg.dsc                                   |  18 -
 BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c              |   6 +-
 EmbeddedPkg/EmbeddedPkg.dec                                         |  17 -
 EmbeddedPkg/EmbeddedPkg.dsc                                         |  15 -
 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h         |  42 -
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c          | 288 -------
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c              | 226 -----
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c | 198 -----
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c            |  63 --
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c              | 862 --------------------
 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c         | 306 -------
 14 files changed, 1 insertion(+), 2045 deletions(-)
 delete mode 100644 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c
 delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids
Posted by Ard Biesheuvel 6 years, 10 months ago
On 6 February 2018 at 17:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> This series cleans up a set of unused Pcds, mostly related to Ebl,
> that have been copied around to various platforms. With a single
> exception they were all unused (but explicitly set, and hence
> deleting their definitions caused build failure), and that
> exception had a tiny conditional to excise.
>
> As part of cleaning out that, I also found some other unused bits
> to get rid of.
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


> Leif Lindholm (6):
>   ArmVirtPkg: drop unused PcdCacheEnable
>   BeagleBoardPkg: drop unused EmbeddedPkg Pcds
>   ArmPkg: delete references to unused guids/Pcds from CpuDxe
>   EmbeddedPkg: drop unused Pcds from package .dsc
>   EmbeddedPkg: delete unused HalRuntimeServicesExampleLib
>   EmbeddedPkg: delete unused Pcds and guids
>
>  ArmPkg/Drivers/CpuDxe/CpuDxe.h                                      |   1 -
>  ArmPkg/Drivers/CpuDxe/CpuDxe.inf                                    |   2 -
>  ArmVirtPkg/ArmVirt.dsc.inc                                          |   2 -
>  BeagleBoardPkg/BeagleBoardPkg.dsc                                   |  18 -
>  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c              |   6 +-
>  EmbeddedPkg/EmbeddedPkg.dec                                         |  17 -
>  EmbeddedPkg/EmbeddedPkg.dsc                                         |  15 -
>  EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h         |  42 -
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c          | 288 -------
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c              | 226 -----
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c | 198 -----
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c            |  63 --
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c              | 862 --------------------
>  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c         | 306 -------
>  14 files changed, 1 insertion(+), 2045 deletions(-)
>  delete mode 100644 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c
>  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c
>
> --
> 2.11.0
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 0/6] Delete unused EmbeddedPkg code, Pcds and guids
Posted by Leif Lindholm 6 years, 10 months ago
On Tue, Feb 06, 2018 at 05:24:49PM +0000, Ard Biesheuvel wrote:
> On 6 February 2018 at 17:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > This series cleans up a set of unused Pcds, mostly related to Ebl,
> > that have been copied around to various platforms. With a single
> > exception they were all unused (but explicitly set, and hence
> > deleting their definitions caused build failure), and that
> > exception had a tiny conditional to excise.
> >
> > As part of cleaning out that, I also found some other unused bits
> > to get rid of.
> >
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks!
Pushed as 34a4ddda4d..e537d87817.

> 
> > Leif Lindholm (6):
> >   ArmVirtPkg: drop unused PcdCacheEnable
> >   BeagleBoardPkg: drop unused EmbeddedPkg Pcds
> >   ArmPkg: delete references to unused guids/Pcds from CpuDxe
> >   EmbeddedPkg: drop unused Pcds from package .dsc
> >   EmbeddedPkg: delete unused HalRuntimeServicesExampleLib
> >   EmbeddedPkg: delete unused Pcds and guids
> >
> >  ArmPkg/Drivers/CpuDxe/CpuDxe.h                                      |   1 -
> >  ArmPkg/Drivers/CpuDxe/CpuDxe.inf                                    |   2 -
> >  ArmVirtPkg/ArmVirt.dsc.inc                                          |   2 -
> >  BeagleBoardPkg/BeagleBoardPkg.dsc                                   |  18 -
> >  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardMem.c              |   6 +-
> >  EmbeddedPkg/EmbeddedPkg.dec                                         |  17 -
> >  EmbeddedPkg/EmbeddedPkg.dsc                                         |  15 -
> >  EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h         |  42 -
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c          | 288 -------
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c              | 226 -----
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c | 198 -----
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c            |  63 --
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c              | 862 --------------------
> >  EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c         | 306 -------
> >  14 files changed, 1 insertion(+), 2045 deletions(-)
> >  delete mode 100644 EmbeddedPkg/Include/Protocol/DebugSupportPeriodicCallback.h
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Capsule.c
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Mtc.c
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/ReportStatusCode.c
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Reset.c
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Rtc.c
> >  delete mode 100644 EmbeddedPkg/Library/HalRuntimeServicesExampleLib/Variable.c
> >
> > --
> > 2.11.0
> >
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel