sync some function definitions with their declarations

[edk2] [PATCH v2 0/2] sync some function definitions with their declarations

Posted by Laszlo Ersek 6 years, 10 months ago

Repo:   https://github.com/lersek/edk2.git
Branch: sync_defs_to_decls_v2

This is version 2 of the series that I posted earlier. Because that
series didn't reach the list at all, due to SMTP issues on my end, I'm
including the v1 blurb here:

> The patches say it all, just a side remark up here:
>
> These errors would have been caught long ago if we had enabled the
> "-Wmissing-prototypes" gcc option.
>
> (Unfortunately, we can't enable that option even now, because it --
> laudably -- forces the programmer to give internal linkage ("STATIC")
> to their helper / local functions, and -- as we've learned -- some
> versions of the the Visual Studio debugger choke on STATIC functions.
> Thus, core modules basically never make their internal functions
> STATIC.)

The v2 changes are noted per patch.

(This posting should hopefully reach the list; while the original SMTP
issue remains undiagnosed, I attempted to put a work-around in place.
Let's see if it works.)

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Gary Lin <glin@suse.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>

Thanks,
Laszlo

Laszlo Ersek (2):
  ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with
    decl.
  OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with
    declaration

 OvmfPkg/PlatformPei/AmdSev.c                           |  3 ++-
 ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 ++++++++------
 ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h |  1 -
 3 files changed, 10 insertions(+), 8 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] sync some function definitions with their declarations

Posted by Carsey, Jaben 6 years, 10 months ago

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, February 07, 2018 2:45 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
> Ard Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Gary Lin <glin@suse.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH v2 0/2] sync some function definitions with their
> declarations
> Importance: High
> 
> Repo:   https://github.com/lersek/edk2.git
> Branch: sync_defs_to_decls_v2
> 
> This is version 2 of the series that I posted earlier. Because that
> series didn't reach the list at all, due to SMTP issues on my end, I'm
> including the v1 blurb here:
> 
> > The patches say it all, just a side remark up here:
> >
> > These errors would have been caught long ago if we had enabled the
> > "-Wmissing-prototypes" gcc option.
> >
> > (Unfortunately, we can't enable that option even now, because it --
> > laudably -- forces the programmer to give internal linkage ("STATIC")
> > to their helper / local functions, and -- as we've learned -- some
> > versions of the the Visual Studio debugger choke on STATIC functions.
> > Thus, core modules basically never make their internal functions
> > STATIC.)
> 
> The v2 changes are noted per patch.
> 
> (This posting should hopefully reach the list; while the original SMTP
> issue remains undiagnosed, I attempted to put a work-around in place.
> Let's see if it works.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Gary Lin <glin@suse.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (2):
>   ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with
>     decl.
>   OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with
>     declaration
> 
>  OvmfPkg/PlatformPei/AmdSev.c                           |  3 ++-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14
> ++++++++------
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h |  1 -
>  3 files changed, 10 insertions(+), 8 deletions(-)
> 
> --
> 2.14.1.3.gb7cf6e02401b
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 0/2] sync some function definitions with their declarations

Posted by Laszlo Ersek 6 years, 10 months ago

On 02/08/18 16:14, Carsey, Jaben wrote:
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

Thank you all; series pushed as commit range de8373fa07f8..c0d221a34854.

Laszlo

>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Wednesday, February 07, 2018 2:45 PM
>> To: edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Brijesh Singh <brijesh.singh@amd.com>;
>> Ard Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
>> <jordan.l.justen@intel.com>; Gary Lin <glin@suse.com>; Carsey, Jaben
>> <jaben.carsey@intel.com>
>> Subject: [edk2] [PATCH v2 0/2] sync some function definitions with their
>> declarations
>> Importance: High
>>
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: sync_defs_to_decls_v2
>>
>> This is version 2 of the series that I posted earlier. Because that
>> series didn't reach the list at all, due to SMTP issues on my end, I'm
>> including the v1 blurb here:
>>
>>> The patches say it all, just a side remark up here:
>>>
>>> These errors would have been caught long ago if we had enabled the
>>> "-Wmissing-prototypes" gcc option.
>>>
>>> (Unfortunately, we can't enable that option even now, because it --
>>> laudably -- forces the programmer to give internal linkage ("STATIC")
>>> to their helper / local functions, and -- as we've learned -- some
>>> versions of the the Visual Studio debugger choke on STATIC functions.
>>> Thus, core modules basically never make their internal functions
>>> STATIC.)
>>
>> The v2 changes are noted per patch.
>>
>> (This posting should hopefully reach the list; while the original SMTP
>> issue remains undiagnosed, I attempted to put a work-around in place.
>> Let's see if it works.)
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: Gary Lin <glin@suse.com>
>> Cc: Jaben Carsey <jaben.carsey@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with
>>     decl.
>>   OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with
>>     declaration
>>
>>  OvmfPkg/PlatformPei/AmdSev.c                           |  3 ++-
>>  ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14
>> ++++++++------
>>  ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h |  1 -
>>  3 files changed, 10 insertions(+), 8 deletions(-)
>>
>> --
>> 2.14.1.3.gb7cf6e02401b
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel