1. Patchew
  2. EDK2
  3. [edk2] [PATCH 0/4] minuscule cleanups for Shell library resolutions
  4. View patch

[edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

Laszlo Ersek posted 4 patches 6 years, 10 months ago
[edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
Posted by Laszlo Ersek 6 years, 10 months ago 
In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the
useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData()
function was removed. No TimerLib API calls are left, thus remove the
TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
as well.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
 MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h           | 1 -
 2 files changed, 2 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index 1adffd70d06a..8d5b89ea2970 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -52,7 +52,6 @@ [LibraryClasses]
   PcdLib
   BaseLib
   UefiLib
-  TimerLib
   DebugLib
   PrintLib
   BaseMemoryLib
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
index ed0cd16ef322..25a1d522fe84 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
+++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
@@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/PcdLib.h>
 #include <Library/PeCoffGetEntryPointLib.h>
 #include <Library/UefiBootManagerLib.h>
-#include <Library/TimerLib.h>
 #include <Library/DxeServicesLib.h>
 #include <Library/ReportStatusCodeLib.h>
 #include <Library/CapsuleLib.h>
-- 
2.14.1.3.gb7cf6e02401b


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
Posted by Zeng, Star 6 years, 10 months ago 
Reviewed-by: Star Zeng <star.zeng@intel.com>


Thanks,
Star
-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Monday, February 12, 2018 9:45 PM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Dong, Eric <eric.dong@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency

In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData() function was removed. No TimerLib API calls are left, thus remove the TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
as well.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
 MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h           | 1 -
 2 files changed, 2 deletions(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index 1adffd70d06a..8d5b89ea2970 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -52,7 +52,6 @@ [LibraryClasses]
   PcdLib
   BaseLib
   UefiLib
-  TimerLib
   DebugLib
   PrintLib
   BaseMemoryLib
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
index ed0cd16ef322..25a1d522fe84 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
+++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
@@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 #include <Library/PcdLib.h>
 #include <Library/PeCoffGetEntryPointLib.h>
 #include <Library/UefiBootManagerLib.h> -#include <Library/TimerLib.h>  #include <Library/DxeServicesLib.h>  #include <Library/ReportStatusCodeLib.h>  #include <Library/CapsuleLib.h>
--
2.14.1.3.gb7cf6e02401b


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH 3/4] MdeModulePkg/UefiBootManagerLib: remove superfluous TimerLib dependency
Posted by Ni, Ruiyu 6 years, 10 months ago 
On 2/12/2018 9:45 PM, Laszlo Ersek wrote:
> In commit 3a039a567a5f ("MdeModulePkg/UefiBootManagerLib: Remove the
> useless perf codes", 2018-02-12), the BmWriteBootToOsPerformanceData()
> function was removed. No TimerLib API calls are left, thus remove the
> TimerLib class dependency from "InternalBm.h" and "UefiBootManagerLib.inf"
> as well.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 -
>   MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h           | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index 1adffd70d06a..8d5b89ea2970 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -52,7 +52,6 @@ [LibraryClasses]
>     PcdLib
>     BaseLib
>     UefiLib
> -  TimerLib
>     DebugLib
>     PrintLib
>     BaseMemoryLib
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> index ed0cd16ef322..25a1d522fe84 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
> @@ -68,7 +68,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>   #include <Library/PcdLib.h>
>   #include <Library/PeCoffGetEntryPointLib.h>
>   #include <Library/UefiBootManagerLib.h>
> -#include <Library/TimerLib.h>
>   #include <Library/DxeServicesLib.h>
>   #include <Library/ReportStatusCodeLib.h>
>   #include <Library/CapsuleLib.h>
> 
Thanks!
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patchew 2.1-devel-8c64711

© 2016 - 2024 Red Hat, Inc.