OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg

[edk2] [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg

Posted by Laszlo Ersek 7 years, 8 months ago

QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
complex way, in the pc_memory_init() function. Log the value as a
DEBUG_VERBOSE message to support debugging.

Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/PlatformPei/MemDetect.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
index 2b2f3e4bec55..2f9e83551364 100644
--- a/OvmfPkg/PlatformPei/MemDetect.c
+++ b/OvmfPkg/PlatformPei/MemDetect.c
@@ -358,6 +358,8 @@ GetFirstNonAddress (
   if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
     QemuFwCfgSelectItem (FwCfgItem);
     QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
+    DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
+      HotPlugMemoryEnd));
 
     ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
     FirstNonAddress = HotPlugMemoryEnd;
-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg

Posted by Ard Biesheuvel 7 years, 8 months ago

On 28 March 2018 at 13:38, Laszlo Ersek <lersek@redhat.com> wrote:
> QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
> complex way, in the pc_memory_init() function. Log the value as a
> DEBUG_VERBOSE message to support debugging.
>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  OvmfPkg/PlatformPei/MemDetect.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
> index 2b2f3e4bec55..2f9e83551364 100644
> --- a/OvmfPkg/PlatformPei/MemDetect.c
> +++ b/OvmfPkg/PlatformPei/MemDetect.c
> @@ -358,6 +358,8 @@ GetFirstNonAddress (
>    if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
>      QemuFwCfgSelectItem (FwCfgItem);
>      QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
> +    DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
> +      HotPlugMemoryEnd));
>
>      ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
>      FirstNonAddress = HotPlugMemoryEnd;
> --
> 2.14.1.3.gb7cf6e02401b
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH] OvmfPkg/PlatformPei: debug log "etc/reserved-memory-end" from fw_cfg

Posted by Laszlo Ersek 7 years, 8 months ago

On 03/28/18 14:57, Ard Biesheuvel wrote:
> On 28 March 2018 at 13:38, Laszlo Ersek <lersek@redhat.com> wrote:
>> QEMU calculates the UINT64 value in "etc/reserved-memory-end" in a quite
>> complex way, in the pc_memory_init() function. Log the value as a
>> DEBUG_VERBOSE message to support debugging.
>>
>> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1353591
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Ard! Commit c27c0003c10f.
Laszlo


>> ---
>>  OvmfPkg/PlatformPei/MemDetect.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
>> index 2b2f3e4bec55..2f9e83551364 100644
>> --- a/OvmfPkg/PlatformPei/MemDetect.c
>> +++ b/OvmfPkg/PlatformPei/MemDetect.c
>> @@ -358,6 +358,8 @@ GetFirstNonAddress (
>>    if (!EFI_ERROR (Status) && FwCfgSize == sizeof HotPlugMemoryEnd) {
>>      QemuFwCfgSelectItem (FwCfgItem);
>>      QemuFwCfgReadBytes (FwCfgSize, &HotPlugMemoryEnd);
>> +    DEBUG ((DEBUG_VERBOSE, "%a: HotPlugMemoryEnd=0x%Lx\n", __FUNCTION__,
>> +      HotPlugMemoryEnd));
>>
>>      ASSERT (HotPlugMemoryEnd >= FirstNonAddress);
>>      FirstNonAddress = HotPlugMemoryEnd;
>> --
>> 2.14.1.3.gb7cf6e02401b
>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel