From nobody Fri May 3 10:33:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 152482907982924.641540885852805; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A9EC52283931E; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EA9692282E595 for ; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id d1-v6so1453736wrj.13 for ; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:53 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::243; helo=mail-wr0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zjiXFvL854AbJ8rE7Xe5Z8PdtahEfYirwEQnl6oQZ8Y=; b=Jbm+oKJhBBCYb7065yJAXy/RP25wNYuvgdI54WHhFEXlS6jPIj0ZDYwlYuZvr+Muje If6R0aZhWcXRsPenOozHRO96vlei2qnyj4QOGrlSaqWAlW9LgwzL+mwXaDf+7rBjN5Ld goiiWymHJHuxvASBEiDPi9QLqm9GfNzjPC+Og= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zjiXFvL854AbJ8rE7Xe5Z8PdtahEfYirwEQnl6oQZ8Y=; b=afQen1p3DNxA9GXB8bpF6Jp+LqH/c5hUEoQX/bYda8z6zRT4vlDIf/oZi9vAvSDFRh jxWVBmlMCKozs3Q45Xt9o2QKBWxmPXl4QT/K0cHEf4/voGlmkKeVAgOqg6oZbQOjENoi oNOBOvsEoSVqHQC8t1cvU5cpM5Sl+dJSZJHQfZaWMAV1jS+uJdatIl0OTUJMcBJw02wK UMG3YGp48aFrlYwSjXuXp4uMh8hX5m/jxe7JoGgnqsUnZXoV1WqwAMLv71J2+b0y0L2I /yWac18iOZDaWJLKuVVIijB3bMBNleS7WWd7MBn4Ef8vQz0B2QX3qzudTsmctw/sgdEX eh3A== X-Gm-Message-State: ALQs6tAGMi2oYfxUMVzC9+fT47xX58Ssa7xnt4b0g0vsAK4xDHsNblhl YuiVHO8P6LF0MMDfaUoafOST5O7eHNM= X-Google-Smtp-Source: AB8JxZpFnJaUlIxIuVt5HHXlt6tgJSk8Vo6uu63WhOgRDOoBOaSsIJs3J865seKFxIBhtCOSDfPCew== X-Received: by 2002:adf:d1cc:: with SMTP id m12-v6mr1650716wri.214.1524829074097; Fri, 27 Apr 2018 04:37:54 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:44 +0200 Message-Id: <20180427113748.21663-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 1/5] Silicon/SynQuacer/NetsecDxe: Add polling function to reinitialize GMAC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Masahisa KOJIMA GMAC is a Gigabit Ethernet MAC implemented in NETSEC. When the physical link is changed from DOWN to UP, GMAC should be reinitialized properly. We add polling function to check the physical link status and reinitialize GMAC: - when the GMAC is running and physical link is down, stop GMAC, - when the GMAC is stopped and physical link is up, start GMAC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Masahisa KOJIMA Reviewed-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c | 108 ++++++= ++++++++++++++ Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h | 4 + 2 files changed, 112 insertions(+) diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c = b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c index 764c44bb3c87..fa8ae79da28e 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.c @@ -161,6 +161,10 @@ SnpStop ( =20 gBS->CloseEvent (LanDriver->ExitBootEvent); =20 + gBS->SetTimer (LanDriver->PhyStatusEvent, TimerCancel, 0); + gBS->CloseEvent (LanDriver->PhyStatusEvent); + LanDriver->PhyStatusEvent =3D NULL; + // Change the state Snp->Mode->State =3D EfiSimpleNetworkStopped; Status =3D EFI_SUCCESS; @@ -406,6 +410,99 @@ NotifyExitBoot ( gBS->CloseEvent (Event); } =20 +/** + Polling function to check the physical link status with GMAC + + @param[in] Timer Event + @param[in] Context Pointer to the Snp structure + +**/ +STATIC +VOID +EFIAPI +NetsecPollPhyStatus ( + IN EFI_EVENT Timer, + IN VOID *Context + ) +{ + EFI_SIMPLE_NETWORK_PROTOCOL *Snp; + NETSEC_DRIVER *LanDriver; + ogma_phy_link_status_t phy_link_status; + ogma_gmac_mode_t ogma_gmac_mode; + ogma_err_t ogma_err; + BOOLEAN ValidFlag; + ogma_gmac_mode_t GmacMode; + BOOLEAN RxRunningFlag; + BOOLEAN TxRunningFlag; + + Snp =3D (EFI_SIMPLE_NETWORK_PROTOCOL *)Context; + if (Snp =3D=3D NULL) { + DEBUG((DEBUG_ERROR, "NETSEC: PollPhyStatus() invalid Snp\n")); + return; + } + + LanDriver =3D INSTANCE_FROM_SNP_THIS (Snp); + + // Update the media status + ogma_err =3D ogma_get_phy_link_status (LanDriver->Handle, LanDriver->Phy= Address, + &phy_link_status); + if (ogma_err !=3D OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_get_phy_link_status failed with error code: %d\n", + (INT32)ogma_err)); + return; + } + + // Update the GMAC status + ogma_err =3D ogma_get_gmac_status (LanDriver->Handle, &ValidFlag, &GmacM= ode, + &RxRunningFlag, &TxRunningFlag); + if (ogma_err !=3D OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_get_gmac_status failed with error code: %d\n", + (INT32)ogma_err)); + return; + } + + // Stop GMAC when GMAC is running and physical link is down + if (RxRunningFlag && TxRunningFlag && !phy_link_status.up_flag) { + ogma_err =3D ogma_stop_gmac (LanDriver->Handle, OGMA_TRUE, OGMA_TRUE); + if (ogma_err !=3D OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_stop_gmac() failed with error status %d\n", + ogma_err)); + return; + } + } + + // Start GMAC when GMAC is stopped and physical link is up + if (!RxRunningFlag && !TxRunningFlag && phy_link_status.up_flag) { + ZeroMem (&ogma_gmac_mode, sizeof (ogma_gmac_mode_t)); + ogma_gmac_mode.link_speed =3D phy_link_status.link_speed; + ogma_gmac_mode.half_duplex_flag =3D (ogma_bool)phy_link_status.half_du= plex_flag; + if (!phy_link_status.half_duplex_flag && FixedPcdGet8 (PcdFlowCtrl)) { + ogma_gmac_mode.flow_ctrl_enable_flag =3D FixedPcdGet8 (PcdFlowCt= rl); + ogma_gmac_mode.flow_ctrl_start_threshold =3D FixedPcdGet16 (PcdFlowC= trlStartThreshold); + ogma_gmac_mode.flow_ctrl_stop_threshold =3D FixedPcdGet16 (PcdFlowC= trlStopThreshold); + ogma_gmac_mode.pause_time =3D FixedPcdGet16 (PcdPause= Time); + } + + ogma_err =3D ogma_set_gmac_mode (LanDriver->Handle, &ogma_gmac_mode); + if (ogma_err !=3D OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_set_gmac() failed with error status %d\n", + (INT32)ogma_err)); + return; + } + + ogma_err =3D ogma_start_gmac (LanDriver->Handle, OGMA_TRUE, OGMA_TRUE); + if (ogma_err !=3D OGMA_ERR_OK) { + DEBUG ((DEBUG_ERROR, + "NETSEC: ogma_start_gmac() failed with error status %d\n", + (INT32)ogma_err)); + } + } +} + /* * UEFI Start() function */ @@ -450,6 +547,17 @@ SnpStart ( NotifyExitBoot, Snp, &LanDriver->ExitBootEvent); ASSERT_EFI_ERROR (Status); =20 + Status =3D gBS->CreateEvent (EVT_TIMER | EVT_NOTIFY_SIGNAL, TPL_CALLBACK, + NetsecPollPhyStatus, Snp, &LanDriver->PhyStatusEvent); + ASSERT_EFI_ERROR (Status); + + Status =3D gBS->SetTimer ( + LanDriver->PhyStatusEvent, + TimerPeriodic, + NETSEC_PHY_STATUS_POLL_INTERVAL + ); + ASSERT_EFI_ERROR (Status); + // Change state Mode->State =3D EfiSimpleNetworkStarted; Status =3D EFI_SUCCESS; diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h = b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h index 6aa7f1a1d107..f09fb609ba5a 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/NetsecDxe.h @@ -71,6 +71,8 @@ typedef struct { =20 EFI_EVENT ExitBootEvent; =20 + EFI_EVENT PhyStatusEvent; + NON_DISCOVERABLE_DEVICE *Dev; =20 NETSEC_DEVICE_PATH DevicePath; @@ -115,4 +117,6 @@ NetsecRelease ( #define RXINT_TMR_CNT_US 0 #define RXINT_PKTCNT 1 =20 +#define NETSEC_PHY_STATUS_POLL_INTERVAL (EFI_TIMER_PERIOD_MILLISECOND= S (1000)) + #endif --=20 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Fri May 3 10:33:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1524829082370818.1114392080553; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D35BC203B8C84; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B43A2035215E for ; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id c14-v6so1461832wrd.4 for ; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:55 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FcdjOQXCN/z4m7Oi5xH3wKBTkZRQCy2QGFufpWeSRBU=; b=d3/cZR+WWBNAIw7B673B2K7gdJECjcu97r7w6j0fvnjxelhhvocdTFI97tAY4GCV8/ OwEdo4z71Wbvq4/66kr9mu5G/hniKfnPEXpqCQwV/+zTVxAgKniJlYT35SGwbBkzIDzP 1aP8PIpnCLhq5uoCIZ98Wh/nLRBO2w/W+ZGEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FcdjOQXCN/z4m7Oi5xH3wKBTkZRQCy2QGFufpWeSRBU=; b=aA5hQCBMybcHiuAEvY1zv997bmnj7m2Uc1rIaOmAJI+yneUc/15vrQ4mWhBFC40Q12 +oiVoUtTkwbJX/9W+WpeLnrlnKlUZ3WCsSJk1BvkgDt6fht4Z7QVkwTQ+KVPm+DWF3lS JJLhUKeDs5h+NUSNfFnIife2/MnNySWDacEF0FplPyG3ZEW58asMX7YEFT2JXHWJH2si qB6WQBf+HrvMlJdlfCq4nHrg0+a7BFEMpXryrsOT8RXh8F/NcxbR5YaQ819c25vSY7wL 41/nek7eua30SLnN+rncUoUUREjWnVl9FT6ol4TS1Zhso4wITTJE3itkHROB6OsbJo4k WKaQ== X-Gm-Message-State: ALQs6tAOrH/96PretQJSHA4xjUzfKFP50Wz7A0SEMqYeNm2ZoP7iwoUD bCvDfgCKgML7OQvtmHFrdhhNSJGO2Rw= X-Google-Smtp-Source: AB8JxZq6LAw6Hr7AQTzTLpsMTvc8/Qd/7QWqUK0u0vixv+pXWigqHvwepCvEE8gwHB0U75NLDt4eNw== X-Received: by 2002:adf:e28c:: with SMTP id v12-v6mr1436110wri.188.1524829075832; Fri, 27 Apr 2018 04:37:55 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:45 +0200 Message-Id: <20180427113748.21663-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 2/5] Platform/Socionext/DeveloperBox: add SNP driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Even though the builtin NETSEC controller driver implements the Simple Network Protocol (SNP) directly, other network controllers connected via PCIe may be supported by a UNDI driver, which require the generic SnpDxe driver in order to be usable. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/So= cionext/DeveloperBox/DeveloperBox.dsc index cc36c2ed1772..430c3fb06df1 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -633,6 +633,7 @@ [Components.common] MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf + MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/So= cionext/DeveloperBox/DeveloperBox.fdf index 2da83850975b..1b8de4c3823a 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf @@ -203,6 +203,7 @@ [FV.FvMain] INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf + INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf --=20 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Fri May 3 10:33:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1524829085263935.8908026395605; Fri, 27 Apr 2018 04:38:05 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 04657203B8C8C; Fri, 27 Apr 2018 04:38:01 -0700 (PDT) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A593203B8C87 for ; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) Received: by mail-wr0-x244.google.com with SMTP id v5-v6so1461848wrf.9 for ; Fri, 27 Apr 2018 04:37:58 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:56 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::244; helo=mail-wr0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AIqHauGQS82n5xmEWThFcRYZCDGS62wh7eL8meWOuGc=; b=WoBxhHbML+AgWb9S+bfky9Uj4gJd5pnHJifCLtb2RHPE7/uwUkZfR3no8NxyS+VNaX opbM94wqU7KgewpkGighsEVW+YvNBO3C7G5lLeKFpRVDPE7G1SfbtzNorGSnL1soEE6S 5FsoYPYqurZQnEloOuPZJ7qxWzzlJE0Cf/8I0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AIqHauGQS82n5xmEWThFcRYZCDGS62wh7eL8meWOuGc=; b=n6HrUpDEbUNfQaRnyN45acD+12gbUv2BlQ0plYAbRGOp2l8J9zmscYtlmSw8PjvXpR r2RNZDAL9Iyp28Evl9opRJFD75sZk/wsiXqLyV7U8dC2D0XOnHaA0QP0Jod3CiaBYFBT NUdIWhHj48m1TPZHPX1ubrk0bJE3KdEuLHZ9VBNRB+hoIQvBE7+4hlGHoGeoFoZptlHv BnsmjndG7d5wu/84ej4mcT/cg1Fd2eo848rbgE+tBG0+XCJVpYyAAXQgvDucu8F7AmQ2 F+i81AEvOKh+OhqCPUJsQYMabIKEJhqKHO6coR+e9ETKI9zDS904UblgwZyqRRopLP9Z /TtA== X-Gm-Message-State: ALQs6tASb445t2qzqKedVpqV56BWwwAq7aa2nBTeCNmRSdwxLw7Snt5w D35b8SV78xnLnOfpTMLgAhnpal64ir0= X-Google-Smtp-Source: AB8JxZphqh003P7LZ29UbWbUqOItPcOQAvlBMrvFsatNp4LFpB1mmbG67bE0If7XkMCVFYqRezSGXw== X-Received: by 2002:adf:8df7:: with SMTP id o110-v6mr1616445wrb.251.1524829077400; Fri, 27 Apr 2018 04:37:57 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:46 +0200 Message-Id: <20180427113748.21663-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 3/5] Platform/SynQuacer: add 'acpiview' shell command to build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" To help diagnose ACPI related boot problems, include the 'acpiview' builtin shell command to our build of the UEFI Shell. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/So= cionext/DeveloperBox/DeveloperBox.dsc index 430c3fb06df1..cacb3d9e4852 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -533,6 +533,7 @@ [Components.common] ShellPkg/Application/Shell/Shell.inf { ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman= dLib.inf + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewC= ommandLib.inf NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comm= andsLib.inf NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comm= andsLib.inf NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comm= andsLib.inf diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b= /Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc index f2c6aa15fee4..2d68aed76ca2 100644 --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc @@ -505,6 +505,7 @@ [Components.common] ShellPkg/Application/Shell/Shell.inf { ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman= dLib.inf + NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewC= ommandLib.inf NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comm= andsLib.inf NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comm= andsLib.inf NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comm= andsLib.inf --=20 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Fri May 3 10:33:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 15248290885611003.7790361593344; Fri, 27 Apr 2018 04:38:08 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2C9F8203B8C8F; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C4186203B8C8A for ; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id t11so2135631wmt.0 for ; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:58 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cN4zl5bbvDI3gTfqRqjUGQwqEF2vbJcFHvYOv6XOus8=; b=BCDpHzB58UCFC2gR38nUt0EGUdoJNgT0xlP4ncJ6BInmdORUOSqxlmTX34eV9CqU0i gKaib6nXlvh0GAUcX3ohe3nbAXyhKhWNQDwhdsjzh4TzkQvPtoT49XFRlA8mNDY5o/Js L/M/fKafDI1ak/icBGwvheBHvld64r7jgK3nE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cN4zl5bbvDI3gTfqRqjUGQwqEF2vbJcFHvYOv6XOus8=; b=Cu5mIkgWdjKdoTyI14mMfxEaDa7Zi7ZN4bNTylZRRgHJorOmEPInWirjw6MgdwYloo gmWeBB/oCZ5rhYcAiWBsLY3BlL08xJYJBKMYeWDRh4jTCA8tUd2+dbJBEl3AlPX28u9y XK88Q6yUk3P8OYKPU8MsHbpUbAnCu137okPZBl8/GRdGU81RglAtQ9SkOB18Q5/UdMdh OThse+3Pd48XyOEoCVMQT/8XmAOf2WIQJKVp1430n0ilsjD2S2hFoDu7B/wgB5gXXZub 0gPWd3ZJ/BI4gS0OnNVkKoIAUEKorGvdhJ3mtO8qoALzFY0wgCR+LYDOlppZHo1558Kp K88w== X-Gm-Message-State: ALQs6tAvOyGosyz3NP2Cebr+Z8vKJ6lFFt6GYSlC8tXPbv2y+VT/X4XS LDQkcmNhUAhlO6y2N/1fF2OPT7PJovg= X-Google-Smtp-Source: AB8JxZoA9n9KOmOsE39tqLe/bWyo7Lctt229mP4417Wxh4sb8cRkPlmRKQ3B821Y5o1J2et2aEJPyw== X-Received: by 10.28.133.12 with SMTP id h12mr1311703wmd.136.1524829079060; Fri, 27 Apr 2018 04:37:59 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:47 +0200 Message-Id: <20180427113748.21663-5-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 4/5] Silicon/SynQuacer/PlatformDxe: depex on gEfiVariableArchProtocolGuid X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" SynQuacer's PlatformDxe uses HII style dynamic PCDs, and so it implicitly depends on the PI variable protocol. This dependency is not made explicit due to the fact that it is platform dependent whether a certain variable is backed by such a dynamic PCD. So add gEfiVariableArchProtocolGuid to PlatformDxe's DEPEX to ensure that it does not attempt to refer to HII style dynamic PCDs before the driver that produces them has been dispatched. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Please refer to this discussion for more details: https://lists.01.org/pipermail/edk2-devel/2018-April/023700.html Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.in= f b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf index 8df3073bf24b..5fa2b7f6071d 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.inf @@ -84,4 +84,4 @@ [Pcd] gSynQuacerTokenSpaceGuid.PcdPlatformSettings =20 [Depex] - TRUE + gEfiVariableArchProtocolGuid --=20 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Fri May 3 10:33:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 15248290921112.911653596971746; Fri, 27 Apr 2018 04:38:12 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5ACDF203B8C93; Fri, 27 Apr 2018 04:38:04 -0700 (PDT) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53BAB203B8C91 for ; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id j4so2120363wme.1 for ; Fri, 27 Apr 2018 04:38:02 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id k82sm869167wmf.17.2018.04.27.04.37.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 04:37:59 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::243; helo=mail-wm0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=amMmw+Aj2z4kl4vBKkdBIi6ln1xvtZa5t8g837/WOV0=; b=XjFbfg0afZVP/Co4xhzUkFRSnqj3gojjxQIJTU5X8C+mhlv4rzC74sh0tAPfgEgUdu xO3HJl1eafKe6AT60JtjVVdRvg1Kum+9zqFjUnpU0JxJbeeEbZcH3SFDm+RxX2Ecik8c z5C2loCHS0FmJSzHaOeBOH4merpIBD3QC6oiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=amMmw+Aj2z4kl4vBKkdBIi6ln1xvtZa5t8g837/WOV0=; b=kD1bNzvYuhyFrQMZx+NyDfIicvHwE5bKkiwrOdhDa7vrlhvAbu4OxEmT+VcOWoPxBJ 7YQ2MOuWWMB9Ef+DDG10UpFkgi3PXDJf668eScXxvauYfbe12ZWaScdJPzUrRCUNx64l Jn5H5wwUrkMSrcMHRRL/Klt//ZGgncWA69TS6u6/rki9eqWhJewZ2Plvtztda1+3o795 1cObtMwa6DDN1lb1wUj3jBYtiawQyGfYdOrcXxtbWj0rrQkHS6+JJpO6lAf3e42bLs7f UjqZkjzPLXyPAi2qOn0B2In+KPUcKXdP4U3rYpN2QVBbxh25wYnoIf8hdIHKyPu3231M TGig== X-Gm-Message-State: ALQs6tDcQAyDQiqNwWZ16E+uSmkrXd5uGWxVUVRH6py3PXqWGzlJFYQ+ aRhEM92ST878Pn9ZND4XTgsg0ay+78o= X-Google-Smtp-Source: AB8JxZpZQxZ3DPYsWu0ikkt0C+MlqlHAEa3hv4OVc8TRdIwsqwcKTST2+Goe0LLMFIxn363E3uJS+g== X-Received: by 10.28.186.136 with SMTP id k130mr1107055wmf.101.1524829080657; Fri, 27 Apr 2018 04:38:00 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 13:37:48 +0200 Message-Id: <20180427113748.21663-6-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180427113748.21663-1-ard.biesheuvel@linaro.org> References: <20180427113748.21663-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH edk2-platforms 5/5] Silicon/SynQuacer: drop BEFORE depex for varstore formatting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Laszlo kindly implemented support for correctly sequencing the load order of the various DXE drivers involved in persistent variable support so that we can ensure that an empty or corrupted varstore in NOR flash is reinitialized before the variable runtime driver attempts to access it. So incorporate this into the SynQuacar platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf | 6 ++---- Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c | 15 ++++++= +++++++++ 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/So= cionext/DeveloperBox/DeveloperBox.dsc index cacb3d9e4852..75816ad94ff3 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -521,6 +521,7 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedL= ib.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariabl= eLibNull.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeas= urementLibNull.inf diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b= /Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc index 2d68aed76ca2..aa34fb075d77 100644 --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc @@ -493,6 +493,7 @@ [Components.common] MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { + NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedL= ib.inf AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariabl= eLibNull.inf NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeas= urementLibNull.inf diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf b/= Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf index 62f81cfe33cd..bddb052c2dcc 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf @@ -53,6 +53,7 @@ [LibraryClasses] UefiRuntimeServicesTableLib =20 [Guids] + gEdkiiNvVarStoreFormattedGuid gEfiAuthenticatedVariableGuid gEfiEventVirtualAddressChangeGuid gEfiSystemNvDataFvGuid @@ -75,7 +76,4 @@ [FixedPcd] gFip006DxeTokenSpaceGuid.PcdFip006DxeMemBaseAddress =20 [Depex] - # - # NorFlashDxe must be loaded before VariableRuntimeDxe in case empty fla= sh needs populating with default values - # - BEFORE gVariableRuntimeDxeFileGuid + gEfiCpuArchProtocolGuid diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c= b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c index acc9490b9a5f..ca3b1b5c34f8 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c @@ -813,6 +813,21 @@ NorFlashFvbInitialize ( } } =20 + // + // The driver implementing the variable read service can now be dispatch= ed; + // the varstore headers are in place. + // + Status =3D gBS->InstallProtocolInterface (&gImageHandle, + &gEdkiiNvVarStoreFormattedGuid, + EFI_NATIVE_INTERFACE, + NULL); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, + "%a: Failed to install gEdkiiNvVarStoreFormattedGuid\n", + __FUNCTION__)); + return Status; + } + // // Declare the Non-Volatile storage as EFI_MEMORY_RUNTIME // --=20 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel