From nobody Tue May 7 07:48:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1524841111232590.8111692106216; Fri, 27 Apr 2018 07:58:31 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id AD2E8203B8CB2; Fri, 27 Apr 2018 07:58:28 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D72D5203B8CA0 for ; Fri, 27 Apr 2018 07:58:26 -0700 (PDT) Received: from E107187.Emea.Arm.com (e107187.emea.arm.com [10.1.211.22]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w3REwNRr028968; Fri, 27 Apr 2018 15:58:24 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 15:58:14 +0100 Message-Id: <20180427145816.118500-2-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180427145816.118500-1-sami.mujawar@arm.com> References: <20180427145816.118500-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 1/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for Juno X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The iASL compiler's -tc option has been updated to generate output that is suitable for including from a C file. The iASL compiler uniquely names the C array containing the processed table data as _aml_code. This update can be seen in the ACPICA git repository at https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0= b5f37 A corresponding change is required in the ConfigurationManager and this patch contains the necessary changes to adapt to the generated iASL compiler output. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd --- The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compi= ler_enhancement_v1 Notes: v1: - Update Configuration Manager to match iASL compiler output. [SAMI] Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Configur= ationManager.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManager= Dxe/ConfigurationManager.c b/Platform/ARM/JunoPkg/ConfigurationManager/Conf= igurationManagerDxe/ConfigurationManager.c index 0e67dfa1f47cc3004b775ec43d02e07754675e26..4c878f663ab247307a17582c07f= 303ddb11b7d41 100644 --- a/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c +++ b/Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/Con= figurationManager.c @@ -74,7 +74,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryInf= o =3D { { EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT), - (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode + (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code }, // DBG2 Table { @@ -86,13 +86,13 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryI= nfo =3D { { EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_AmlCode + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtjunousb_aml_code }, // SSDT table describing the PL011 UART { EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_AmlCode + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtuart_aml_code }, =20 /* PCI MCFG Table @@ -109,7 +109,7 @@ EFI_PLATFORM_REPOSITORY_INFO ArmJunoPlatformRepositoryI= nfo =3D { { EFI_ACPI_6_2_SECONDARY_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_SSDT), - (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_AmlCode + (EFI_ACPI_DESCRIPTION_HEADER*)ssdtpci_aml_code } }, =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Tue May 7 07:48:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1524841116587108.68434551563053; Fri, 27 Apr 2018 07:58:36 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 14DA9203B8CB9; Fri, 27 Apr 2018 07:58:29 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D9B70203B8CAC for ; Fri, 27 Apr 2018 07:58:26 -0700 (PDT) Received: from E107187.Emea.Arm.com (e107187.emea.arm.com [10.1.211.22]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w3REwNRs028968; Fri, 27 Apr 2018 15:58:24 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 15:58:15 +0100 Message-Id: <20180427145816.118500-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180427145816.118500-1-sami.mujawar@arm.com> References: <20180427145816.118500-1-sami.mujawar@arm.com> Subject: [edk2] [PATCH edk2-platforms v1 2/3][platforms/devel-dynamictables] Platform/ARM: Match asl compiler output for FVP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Stephanie.Hughes-Fitt@arm.com MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The iASL compiler's -tc option has been updated to generate output that is suitable for including from a C file. The iASL compiler uniquely names the C array containing the processed table data as _aml_code. This update can be seen in the ACPICA git repository at https://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0= b5f37 A corresponding change is required in the ConfigurationManager and this patch contains the necessary changes to adapt to the generated iASL compiler output. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd --- The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compi= ler_enhancement_v1 Notes: v1: - Update Configuration Manager to match iASL compiler output. [SAMI] Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/Conf= igurationManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationMan= agerDxe/ConfigurationManager.c b/Platform/ARM/VExpressPkg/ConfigurationMana= ger/ConfigurationManagerDxe/ConfigurationManager.c index d45528813e2db9f44e1745392dfd35ffe05f1dca..2e1be34acf49962fd1899d84dec= 96c8cb9155b2c 100644 --- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c +++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe= /ConfigurationManager.c @@ -71,7 +71,7 @@ EFI_PLATFORM_REPOSITORY_INFO VExpressPlatRepositoryInfo = =3D { { EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, CREATE_STD_ACPI_TABLE_GEN_ID (ESTD_ACPI_TABLE_ID_DSDT), - (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_AmlCode + (EFI_ACPI_DESCRIPTION_HEADER*)dsdt_aml_code }, // DBG2 Table { --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Tue May 7 07:48:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1524841109979828.5186337229075; Fri, 27 Apr 2018 07:58:29 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7F0B8203B8CAF; Fri, 27 Apr 2018 07:58:28 -0700 (PDT) Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D80BC203B8CAA for ; Fri, 27 Apr 2018 07:58:26 -0700 (PDT) Received: from E107187.Emea.Arm.com (e107187.emea.arm.com [10.1.211.22]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w3REwNRt028968; Fri, 27 Apr 2018 15:58:24 +0100 X-Original-To: edk2-devel@lists.01.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.96.140; helo=cam-smtp0.cambridge.arm.com; envelope-from=sami.mujawar@arm.com; receiver=edk2-devel@lists.01.org From: Sami Mujawar To: edk2-devel@lists.01.org Date: Fri, 27 Apr 2018 15:58:16 +0100 Message-Id: <20180427145816.118500-4-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20180427145816.118500-1-sami.mujawar@arm.com> References: <20180427145816.118500-1-sami.mujawar@arm.com> MIME-Version: 1.0 Subject: [edk2] [PATCH edk2-platforms v1 3/3][platforms/devel-dynamictables] Update Readme.md to reflect ACPICA compiler update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nd@arm.com, Arvind Chauhan , ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Stephanie.Hughes-Fitt@arm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 The ACPICA iASL compiler has been enhanced to support the generation of an AML hex file which is required by the Dynamic Tables Framework. The patch for this enhancement has been integrated in the ACPICA repository. Therefore the Prerequisites section in the Readme has been updated accordingly. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Sami Mujawar Reviewed-by: Evan Lloyd --- The changes can be seen at https://github.com/samimujawar/edk2-platforms/tree/258_reflect_acpica_compi= ler_enhancement_v1 Notes: v1: - Update ACPICA iAsl compiler usage guidelines. [SAMI] Readme.md | 21 +++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/Readme.md b/Readme.md index b72efca18e8ab5de17cab06f0a1a0725991256d4..2300fa6be9f83525e8c0ee21800= 751d9067b02e0 100644 --- a/Readme.md +++ b/Readme.md @@ -87,9 +87,9 @@ contains the Dynamic Tables Framework. ### ACPICA iASL compiler The RAW table generator, used to process the DSDT/SSDT files depends on the iASL compiler to convert the DSDT/SSDT ASL files to a C array containi= ng -the hex AML code. The current implementation of the iASL compiler does not -support generation of a C header file suitable for including from a C sour= ce -file. +the hex AML code. The "-tc" option of the iASL compiler has been enhanced = to +support generation of an AML hex file (C header) with a unique symbol name +so that it is suitable for inclusion from a C source file. =20 Related Links -------------- @@ -135,16 +135,19 @@ or =20 Prerequisites ------------- -ACPICA iASL compiler with support for generating a C header file. +ACPICA iASL compiler with the enhanced "-tc" option to support generation = of +AML hex (C header) files with unique symbol names. =20 -A patch ***'Modify hex AML C header file generation'***, to enable -this support has been submitted to the ACPICA source repository. - +A patch ***'[iASL: Enhance the -tc option (create AML hex file in C)](http= s://github.com/acpica/acpica/commit/f9a88a4c1cd020b6a5475d63b29626852a0b5f3= 7)'***, +to enable this support has been integrated to the ACPICA source repository. + + +Ensure that the iASL compiler used for building *Dynamic Tables Framework* +has this feature enabled. =20 Documentation ------------- -A description document is in preparation, and should be available in the -near future. +[Dynamic Tables Framework: A Step Towards Automatic Generation of Advanced= Configuration and Power Interface (ACPI) & System Management BIOS (SMBIOS)= Tables =E2=80=93 Sami Mujawar (Arm).](http://www.uefi.org/sites/default/fi= les/resources/Arm_Dynamic%20Tables%20Framework%20A%20Step%20Towards%20Autom= atic%20Generation%20of%20Advanced%20Configuration%20and%20Power%20Interface= %20%28ACPI%29%20%26%20System%20Management%20BIOS%20%28SMBIOS%29%20Tables%20= _0.pdf) =20 Miscellaneous ------------- --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel