ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again

[edk2] [PATCH 0/2] ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again

Posted by Laszlo Ersek 5 years, 11 months ago

Repo:   https://github.com/lersek/edk2.git
Branch: connect_vrng_bz1579518

This is a fix for another regression from the March 2018 series

  [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy
                     for connecting devices

Turns out EfiBootManagerConnectAll() used to connect devices one doesn't
really think about every day. I stumbled upon this when an aarch64 guest
kernel printed

> EFI stub: EFI_RNG_PROTOCOL unavailable, no randomness supplied

whereas I had just looked at the domain XML and seen the virtio-rng
device model in it.

Tested extensively as described in
<https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c0> and
<https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c2>.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>

Thanks,
Laszlo

Laszlo Ersek (2):
  ArmVirtPkg/PlatformBootManagerLib: connect Virtio RNG devices again
  OvmfPkg/PlatformBootManagerLib: connect Virtio RNG devices again

 ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c               | 129 ++++++++++++++++++++
 ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |   1 +
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c                 | 105 ++++++++++++++++
 OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h                 |   1 +
 4 files changed, 236 insertions(+)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again

Posted by Ard Biesheuvel 5 years, 11 months ago

On 18 May 2018 at 08:20, Laszlo Ersek <lersek@redhat.com> wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: connect_vrng_bz1579518
>
> This is a fix for another regression from the March 2018 series
>
>   [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy
>                      for connecting devices
>
> Turns out EfiBootManagerConnectAll() used to connect devices one doesn't
> really think about every day. I stumbled upon this when an aarch64 guest
> kernel printed
>
>> EFI stub: EFI_RNG_PROTOCOL unavailable, no randomness supplied
>
> whereas I had just looked at the domain XML and seen the virtio-rng
> device model in it.
>
> Tested extensively as described in
> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c0> and
> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c2>.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (2):
>   ArmVirtPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>   OvmfPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>

Thanks for spotting that

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH 0/2] ArmVirtPkg, OvmfPkg: connect Virtio RNG devices again

Posted by Laszlo Ersek 5 years, 11 months ago

On 05/18/18 11:09, Ard Biesheuvel wrote:
> On 18 May 2018 at 08:20, Laszlo Ersek <lersek@redhat.com> wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: connect_vrng_bz1579518
>>
>> This is a fix for another regression from the March 2018 series
>>
>>   [edk2] [PATCH 0/6] OvmfPkg, ArmVirtQemu: leaner platform BDS policy
>>                      for connecting devices
>>
>> Turns out EfiBootManagerConnectAll() used to connect devices one doesn't
>> really think about every day. I stumbled upon this when an aarch64 guest
>> kernel printed
>>
>>> EFI stub: EFI_RNG_PROTOCOL unavailable, no randomness supplied
>>
>> whereas I had just looked at the domain XML and seen the virtio-rng
>> device model in it.
>>
>> Tested extensively as described in
>> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c0> and
>> <https://bugzilla.redhat.com/show_bug.cgi?id=1579518#c2>.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   ArmVirtPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>>   OvmfPkg/PlatformBootManagerLib: connect Virtio RNG devices again
>>
> 
> Thanks for spotting that
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thank you! Commit range 333f32ec23dd..7ebad830d6ab.

Cheers
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel