[edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

Supreeth Venkatesh posted 17 patches 5 years, 10 months ago
Only 2 patches received!
ArmPkg/ArmPkg.dec                             |    3 +
.../MmCommunicationDxe/MmCommunication.c      |  408 +++++++
.../MmCommunicationDxe/MmCommunication.inf    |   50 +
ArmPkg/Include/IndustryStandard/ArmMmSvc.h    |    9 +-
.../AArch64/ArmMmuStandaloneMmCoreLib.c       |  195 +++
.../ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf   |   37 +
.../DebugPeCoffExtraActionLib.c               |  185 ++-
.../DebugPeCoffExtraActionLib.inf             |    7 +
BaseTools/Source/Python/AutoGen/GenC.py       |   16 +-
StandaloneMmPkg                               |    0
StandaloneMmPkg/Core/Dependency.c             |  389 ++++++
StandaloneMmPkg/Core/Dispatcher.c             | 1071 +++++++++++++++++
StandaloneMmPkg/Core/FwVol.c                  |  104 ++
StandaloneMmPkg/Core/Handle.c                 |  533 ++++++++
.../Core/InstallConfigurationTable.c          |  178 +++
StandaloneMmPkg/Core/Locate.c                 |  496 ++++++++
StandaloneMmPkg/Core/Mmi.c                    |  337 ++++++
StandaloneMmPkg/Core/Notify.c                 |  203 ++++
StandaloneMmPkg/Core/Page.c                   |  384 ++++++
StandaloneMmPkg/Core/Pool.c                   |  287 +++++
StandaloneMmPkg/Core/StandaloneMmCore.c       |  708 +++++++++++
StandaloneMmPkg/Core/StandaloneMmCore.h       |  903 ++++++++++++++
StandaloneMmPkg/Core/StandaloneMmCore.inf     |   80 ++
.../Core/StandaloneMmCorePrivateData.h        |   66 +
.../StandaloneMmCpu/AArch64/EventHandle.c     |  208 ++++
.../StandaloneMmCpu/AArch64/StandaloneMmCpu.c |  219 ++++
.../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |   64 +
.../AArch64/StandaloneMmCpu.inf               |   59 +
StandaloneMmPkg/Include/Guid/MmCoreData.h     |  133 ++
StandaloneMmPkg/Include/Guid/MmFvDispatch.h   |   38 +
.../Include/Guid/MmramMemoryReserve.h         |   62 +
StandaloneMmPkg/Include/Guid/MpInformation.h  |   41 +
.../AArch64/StandaloneMmCoreEntryPoint.h      |  214 ++++
StandaloneMmPkg/Include/Library/FvLib.h       |  109 ++
.../Library/StandaloneMmCoreEntryPoint.h      |  101 ++
.../Library/StandaloneMmDriverEntryPoint.h    |  148 +++
.../Include/Library/StandaloneMmMemLib.h      |  140 +++
StandaloneMmPkg/Include/StandaloneMm.h        |   36 +
StandaloneMmPkg/Library/FvLib/FvLib.c         |  386 ++++++
StandaloneMmPkg/Library/FvLib/FvLib.inf       |   57 +
.../AArch64/CreateHobList.c                   |  200 +++
.../AArch64/SetPermissions.c                  |  275 +++++
.../AArch64/StandaloneMmCoreEntryPoint.c      |  287 +++++
.../StandaloneMmCoreEntryPoint.inf            |   55 +
.../AArch64/StandaloneMmCoreHobLibInternal.c  |   64 +
.../StandaloneMmCoreHobLib.c                  |  608 ++++++++++
.../StandaloneMmCoreHobLib.inf                |   47 +
.../StandaloneMmCoreMemoryAllocationLib.c     |  907 ++++++++++++++
.../StandaloneMmCoreMemoryAllocationLib.inf   |   49 +
...StandaloneMmCoreMemoryAllocationServices.h |   38 +
.../StandaloneMmDriverEntryPoint.c            |   99 ++
.../StandaloneMmDriverEntryPoint.inf          |   41 +
.../AArch64/StandaloneMmMemLibInternal.c      |   49 +
.../StandaloneMmMemLib/StandaloneMmMemLib.c   |  265 ++++
.../StandaloneMmMemLib/StandaloneMmMemLib.inf |   50 +
StandaloneMmPkg/StandaloneMmPkg.dec           |   47 +
StandaloneMmPkg/StandaloneMmPkg.dsc           |  130 ++
57 files changed, 11855 insertions(+), 20 deletions(-)
create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
create mode 100644 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c
create mode 100644 ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf
delete mode 100644 StandaloneMmPkg
create mode 100644 StandaloneMmPkg/Core/Dependency.c
create mode 100644 StandaloneMmPkg/Core/Dispatcher.c
create mode 100644 StandaloneMmPkg/Core/FwVol.c
create mode 100644 StandaloneMmPkg/Core/Handle.c
create mode 100644 StandaloneMmPkg/Core/InstallConfigurationTable.c
create mode 100644 StandaloneMmPkg/Core/Locate.c
create mode 100644 StandaloneMmPkg/Core/Mmi.c
create mode 100644 StandaloneMmPkg/Core/Notify.c
create mode 100644 StandaloneMmPkg/Core/Page.c
create mode 100644 StandaloneMmPkg/Core/Pool.c
create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.c
create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.h
create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.inf
create mode 100644 StandaloneMmPkg/Core/StandaloneMmCorePrivateData.h
create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
create mode 100644 StandaloneMmPkg/Include/Guid/MmCoreData.h
create mode 100644 StandaloneMmPkg/Include/Guid/MmFvDispatch.h
create mode 100644 StandaloneMmPkg/Include/Guid/MmramMemoryReserve.h
create mode 100644 StandaloneMmPkg/Include/Guid/MpInformation.h
create mode 100644 StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h
create mode 100644 StandaloneMmPkg/Include/Library/FvLib.h
create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmCoreEntryPoint.h
create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h
create mode 100644 StandaloneMmPkg/Include/StandaloneMm.h
create mode 100644 StandaloneMmPkg/Library/FvLib/FvLib.c
create mode 100644 StandaloneMmPkg/Library/FvLib/FvLib.inf
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/AArch64/StandaloneMmCoreHobLibInternal.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationServices.h
create mode 100644 StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/AArch64/StandaloneMmMemLibInternal.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c
create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
create mode 100644 StandaloneMmPkg/StandaloneMmPkg.dec
create mode 100644 StandaloneMmPkg/StandaloneMmPkg.dsc
[edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Supreeth Venkatesh 5 years, 10 months ago
***
This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2.
The patches are 
[PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
[PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library.
[PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.

Changes Since v2:
(*) Address feedback provided for the commit "BaseTools/AutoGen: Update header file for MM modules."
(*) Edit parameters for the StandaloneMmCpu Driver in the commit "StandaloneMmPkg: Add an AArch64 specific entry point library."

Changes Since v1:
(*) Reorder and Reword commits.
(*) Reorganize structure of StandaloneMmPkg and rename libraries.
(*) Address Review Comments from Achin, Jiewen and Daniil.
***
Supreeth Venkatesh (17):
  ArmPkg: Add PCDs needed for MM communication driver.
  ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
  ArmPkg/Include: Add MM interface SVC return codes.
  ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
  ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
  StandaloneMmPkg: Delete StandaloneMmPkg file.
  StandaloneMmPkg/FvLib: Add a common FV Library for management mode.
  StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check
    library.
  StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.
  StandaloneMmPkg/HobLib: Add HOB Library for management mode.
  StandaloneMmPkg: MM driver entry point library.
  StandaloneMmPkg/Core: Implementation of Standalone MM Core Module.
  StandaloneMmPkg: Add an AArch64 specific entry point library.
  StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
  StandaloneMmPkg: Describe the declaration and definition files.
  ArmPkg: Extra action to update permissions for S-ELO MM Image.
  BaseTools/AutoGen: Update header file for MM modules.

 ArmPkg/ArmPkg.dec                             |    3 +
 .../MmCommunicationDxe/MmCommunication.c      |  408 +++++++
 .../MmCommunicationDxe/MmCommunication.inf    |   50 +
 ArmPkg/Include/IndustryStandard/ArmMmSvc.h    |    9 +-
 .../AArch64/ArmMmuStandaloneMmCoreLib.c       |  195 +++
 .../ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf   |   37 +
 .../DebugPeCoffExtraActionLib.c               |  185 ++-
 .../DebugPeCoffExtraActionLib.inf             |    7 +
 BaseTools/Source/Python/AutoGen/GenC.py       |   16 +-
 StandaloneMmPkg                               |    0
 StandaloneMmPkg/Core/Dependency.c             |  389 ++++++
 StandaloneMmPkg/Core/Dispatcher.c             | 1071 +++++++++++++++++
 StandaloneMmPkg/Core/FwVol.c                  |  104 ++
 StandaloneMmPkg/Core/Handle.c                 |  533 ++++++++
 .../Core/InstallConfigurationTable.c          |  178 +++
 StandaloneMmPkg/Core/Locate.c                 |  496 ++++++++
 StandaloneMmPkg/Core/Mmi.c                    |  337 ++++++
 StandaloneMmPkg/Core/Notify.c                 |  203 ++++
 StandaloneMmPkg/Core/Page.c                   |  384 ++++++
 StandaloneMmPkg/Core/Pool.c                   |  287 +++++
 StandaloneMmPkg/Core/StandaloneMmCore.c       |  708 +++++++++++
 StandaloneMmPkg/Core/StandaloneMmCore.h       |  903 ++++++++++++++
 StandaloneMmPkg/Core/StandaloneMmCore.inf     |   80 ++
 .../Core/StandaloneMmCorePrivateData.h        |   66 +
 .../StandaloneMmCpu/AArch64/EventHandle.c     |  208 ++++
 .../StandaloneMmCpu/AArch64/StandaloneMmCpu.c |  219 ++++
 .../StandaloneMmCpu/AArch64/StandaloneMmCpu.h |   64 +
 .../AArch64/StandaloneMmCpu.inf               |   59 +
 StandaloneMmPkg/Include/Guid/MmCoreData.h     |  133 ++
 StandaloneMmPkg/Include/Guid/MmFvDispatch.h   |   38 +
 .../Include/Guid/MmramMemoryReserve.h         |   62 +
 StandaloneMmPkg/Include/Guid/MpInformation.h  |   41 +
 .../AArch64/StandaloneMmCoreEntryPoint.h      |  214 ++++
 StandaloneMmPkg/Include/Library/FvLib.h       |  109 ++
 .../Library/StandaloneMmCoreEntryPoint.h      |  101 ++
 .../Library/StandaloneMmDriverEntryPoint.h    |  148 +++
 .../Include/Library/StandaloneMmMemLib.h      |  140 +++
 StandaloneMmPkg/Include/StandaloneMm.h        |   36 +
 StandaloneMmPkg/Library/FvLib/FvLib.c         |  386 ++++++
 StandaloneMmPkg/Library/FvLib/FvLib.inf       |   57 +
 .../AArch64/CreateHobList.c                   |  200 +++
 .../AArch64/SetPermissions.c                  |  275 +++++
 .../AArch64/StandaloneMmCoreEntryPoint.c      |  287 +++++
 .../StandaloneMmCoreEntryPoint.inf            |   55 +
 .../AArch64/StandaloneMmCoreHobLibInternal.c  |   64 +
 .../StandaloneMmCoreHobLib.c                  |  608 ++++++++++
 .../StandaloneMmCoreHobLib.inf                |   47 +
 .../StandaloneMmCoreMemoryAllocationLib.c     |  907 ++++++++++++++
 .../StandaloneMmCoreMemoryAllocationLib.inf   |   49 +
 ...StandaloneMmCoreMemoryAllocationServices.h |   38 +
 .../StandaloneMmDriverEntryPoint.c            |   99 ++
 .../StandaloneMmDriverEntryPoint.inf          |   41 +
 .../AArch64/StandaloneMmMemLibInternal.c      |   49 +
 .../StandaloneMmMemLib/StandaloneMmMemLib.c   |  265 ++++
 .../StandaloneMmMemLib/StandaloneMmMemLib.inf |   50 +
 StandaloneMmPkg/StandaloneMmPkg.dec           |   47 +
 StandaloneMmPkg/StandaloneMmPkg.dsc           |  130 ++
 57 files changed, 11855 insertions(+), 20 deletions(-)
 create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
 create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
 create mode 100644 ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuStandaloneMmCoreLib.c
 create mode 100644 ArmPkg/Library/ArmMmuLib/ArmMmuStandaloneMmCoreLib.inf
 delete mode 100644 StandaloneMmPkg
 create mode 100644 StandaloneMmPkg/Core/Dependency.c
 create mode 100644 StandaloneMmPkg/Core/Dispatcher.c
 create mode 100644 StandaloneMmPkg/Core/FwVol.c
 create mode 100644 StandaloneMmPkg/Core/Handle.c
 create mode 100644 StandaloneMmPkg/Core/InstallConfigurationTable.c
 create mode 100644 StandaloneMmPkg/Core/Locate.c
 create mode 100644 StandaloneMmPkg/Core/Mmi.c
 create mode 100644 StandaloneMmPkg/Core/Notify.c
 create mode 100644 StandaloneMmPkg/Core/Page.c
 create mode 100644 StandaloneMmPkg/Core/Pool.c
 create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.c
 create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.h
 create mode 100644 StandaloneMmPkg/Core/StandaloneMmCore.inf
 create mode 100644 StandaloneMmPkg/Core/StandaloneMmCorePrivateData.h
 create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c
 create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
 create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h
 create mode 100644 StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
 create mode 100644 StandaloneMmPkg/Include/Guid/MmCoreData.h
 create mode 100644 StandaloneMmPkg/Include/Guid/MmFvDispatch.h
 create mode 100644 StandaloneMmPkg/Include/Guid/MmramMemoryReserve.h
 create mode 100644 StandaloneMmPkg/Include/Guid/MpInformation.h
 create mode 100644 StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h
 create mode 100644 StandaloneMmPkg/Include/Library/FvLib.h
 create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmCoreEntryPoint.h
 create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
 create mode 100644 StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h
 create mode 100644 StandaloneMmPkg/Include/StandaloneMm.h
 create mode 100644 StandaloneMmPkg/Library/FvLib/FvLib.c
 create mode 100644 StandaloneMmPkg/Library/FvLib/FvLib.inf
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/AArch64/StandaloneMmCoreHobLibInternal.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationServices.h
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/AArch64/StandaloneMmMemLibInternal.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c
 create mode 100644 StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
 create mode 100644 StandaloneMmPkg/StandaloneMmPkg.dec
 create mode 100644 StandaloneMmPkg/StandaloneMmPkg.dsc

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Sughosh Ganu 5 years, 10 months ago
On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
<supreeth.venkatesh@arm.com> wrote:
> ***
> This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2.
> The patches are
> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library.
> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
>
> Changes Since v2:
> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update header file for MM modules."
> (*) Edit parameters for the StandaloneMmCpu Driver in the commit "StandaloneMmPkg: Add an AArch64 specific entry point library."
>
> Changes Since v1:
> (*) Reorder and Reword commits.
> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> (*) Address Review Comments from Achin, Jiewen and Daniil.
> ***
> Supreeth Venkatesh (17):
>   ArmPkg: Add PCDs needed for MM communication driver.
>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
>   ArmPkg/Include: Add MM interface SVC return codes.
>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
>   StandaloneMmPkg: Delete StandaloneMmPkg file.
>   StandaloneMmPkg/FvLib: Add a common FV Library for management mode.
>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check
>     library.
>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.
>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
>   StandaloneMmPkg: MM driver entry point library.
>   StandaloneMmPkg/Core: Implementation of Standalone MM Core Module.
>   StandaloneMmPkg: Add an AArch64 specific entry point library.
>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
>   StandaloneMmPkg: Describe the declaration and definition files.
>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
>   BaseTools/AutoGen: Update header file for MM modules.

Tested all changes for RAS error injection and error handling on
SGI575 platform.

Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>

-sughosh
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Supreeth Venkatesh 5 years, 10 months ago
Thanks for Testing.
Appreciate it.

Supreeth

-----Original Message-----
From: Sughosh Ganu <sng.lists@gmail.com>
Sent: Wednesday, June 6, 2018 6:20 AM
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Cc: edk2-devel@lists.01.org; jiewen.yao@intel.com; liming.gao@intel.com
Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***

On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh <supreeth.venkatesh@arm.com> wrote:
> ***
> This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2.
> The patches are
> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library.
> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
>
> Changes Since v2:
> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update header file for MM modules."
> (*) Edit parameters for the StandaloneMmCpu Driver in the commit "StandaloneMmPkg: Add an AArch64 specific entry point library."
>
> Changes Since v1:
> (*) Reorder and Reword commits.
> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> (*) Address Review Comments from Achin, Jiewen and Daniil.
> ***
> Supreeth Venkatesh (17):
>   ArmPkg: Add PCDs needed for MM communication driver.
>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
>   ArmPkg/Include: Add MM interface SVC return codes.
>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
>   StandaloneMmPkg: Delete StandaloneMmPkg file.
>   StandaloneMmPkg/FvLib: Add a common FV Library for management mode.
>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check
>     library.
>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.
>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
>   StandaloneMmPkg: MM driver entry point library.
>   StandaloneMmPkg/Core: Implementation of Standalone MM Core Module.
>   StandaloneMmPkg: Add an AArch64 specific entry point library.
>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
>   StandaloneMmPkg: Describe the declaration and definition files.
>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
>   BaseTools/AutoGen: Update header file for MM modules.

Tested all changes for RAS error injection and error handling on
SGI575 platform.

Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>

-sughosh
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Thomas Abraham 5 years, 10 months ago
On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu <sng.lists@gmail.com> wrote:
> On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
> <supreeth.venkatesh@arm.com> wrote:
>> ***
>> This patchset v3 contains only the patches that got feedback/comments frome the previous revision v2.
>> The patches are
>> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
>> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library.
>> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
>>
>> Changes Since v2:
>> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update header file for MM modules."
>> (*) Edit parameters for the StandaloneMmCpu Driver in the commit "StandaloneMmPkg: Add an AArch64 specific entry point library."
>>
>> Changes Since v1:
>> (*) Reorder and Reword commits.
>> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
>> (*) Address Review Comments from Achin, Jiewen and Daniil.
>> ***
>> Supreeth Venkatesh (17):
>>   ArmPkg: Add PCDs needed for MM communication driver.
>>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
>>   ArmPkg/Include: Add MM interface SVC return codes.
>>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
>>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
>>   StandaloneMmPkg: Delete StandaloneMmPkg file.
>>   StandaloneMmPkg/FvLib: Add a common FV Library for management mode.
>>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check
>>     library.
>>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library.
>>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
>>   StandaloneMmPkg: MM driver entry point library.
>>   StandaloneMmPkg/Core: Implementation of Standalone MM Core Module.
>>   StandaloneMmPkg: Add an AArch64 specific entry point library.
>>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
>>   StandaloneMmPkg: Describe the declaration and definition files.
>>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
>>   BaseTools/AutoGen: Update header file for MM modules.
>
> Tested all changes for RAS error injection and error handling on
> SGI575 platform.
>
> Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>
>
> -sughosh

There have been no further comments on this series. Can this patch
series be merged?

Thanks,
Thomas.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Yao, Jiewen 5 years, 10 months ago
Yes. I think so.

However, I found the V3 just contains partial of the patch. It is hard to find some V2 and some V3.
Also this series includes multiple package. We need different package maintainer to push different patches.

I recommend we do in this way:
Please split this big one into 3 - BaseTool patch, ArmPkg patch, and StandaloneMmPkg patch.

Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can push ArmPkg patch, and I can help push StandaloneMmPkg patch.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Thomas Abraham [mailto:thomas.abraham@arm.com]
> Sent: Monday, June 18, 2018 6:07 AM
> To: Sughosh Ganu <sng.lists@gmail.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> edk2-devel@lists.01.org; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core
> Interface for AARCH64 Platforms ***
> 
> On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu <sng.lists@gmail.com> wrote:
> > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
> > <supreeth.venkatesh@arm.com> wrote:
> >> ***
> >> This patchset v3 contains only the patches that got feedback/comments
> frome the previous revision v2.
> >> The patches are
> >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point
> library.
> >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
> >>
> >> Changes Since v2:
> >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update
> header file for MM modules."
> >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit
> "StandaloneMmPkg: Add an AArch64 specific entry point library."
> >>
> >> Changes Since v1:
> >> (*) Reorder and Reword commits.
> >> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> >> (*) Address Review Comments from Achin, Jiewen and Daniil.
> >> ***
> >> Supreeth Venkatesh (17):
> >>   ArmPkg: Add PCDs needed for MM communication driver.
> >>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> >>   ArmPkg/Include: Add MM interface SVC return codes.
> >>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> >>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
> >>   StandaloneMmPkg: Delete StandaloneMmPkg file.
> >>   StandaloneMmPkg/FvLib: Add a common FV Library for management
> mode.
> >>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory
> check
> >>     library.
> >>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation
> library.
> >>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
> >>   StandaloneMmPkg: MM driver entry point library.
> >>   StandaloneMmPkg/Core: Implementation of Standalone MM Core
> Module.
> >>   StandaloneMmPkg: Add an AArch64 specific entry point library.
> >>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
> >>   StandaloneMmPkg: Describe the declaration and definition files.
> >>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
> >>   BaseTools/AutoGen: Update header file for MM modules.
> >
> > Tested all changes for RAS error injection and error handling on
> > SGI575 platform.
> >
> > Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>
> >
> > -sughosh
> 
> There have been no further comments on this series. Can this patch
> series be merged?
> 
> Thanks,
> Thomas.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Achin Gupta 5 years, 10 months ago
Hi Jiewen,

On Mon, Jun 18, 2018 at 03:12:46PM +0000, Yao, Jiewen wrote:
> Yes. I think so.
>
> However, I found the V3 just contains partial of the patch. It is hard to find some V2 and some V3.
> Also this series includes multiple package. We need different package maintainer to push different patches.
>
> I recommend we do in this way:
> Please split this big one into 3 - BaseTool patch, ArmPkg patch, and StandaloneMmPkg patch.
>
> Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can push ArmPkg patch, and I can help push StandaloneMmPkg patch.

Thomas and Sugosh will refactor the patches and repost since Supreeth is on
holiday. I started late but would like to finish reviewing the Arm specific bits
in the StandaloneMmPkg before they are merged. Will not take more than 2
days. Could you please merge after I ack. Hope that is fine?

cheers,
Achin

>
> Thank you
> Yao Jiewen
>
> > -----Original Message-----
> > From: Thomas Abraham [mailto:thomas.abraham@arm.com]
> > Sent: Monday, June 18, 2018 6:07 AM
> > To: Sughosh Ganu <sng.lists@gmail.com>
> > Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> > edk2-devel@lists.01.org; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core
> > Interface for AARCH64 Platforms ***
> >
> > On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu <sng.lists@gmail.com> wrote:
> > > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
> > > <supreeth.venkatesh@arm.com> wrote:
> > >> ***
> > >> This patchset v3 contains only the patches that got feedback/comments
> > frome the previous revision v2.
> > >> The patches are
> > >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> > >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry point
> > library.
> > >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM modules.
> > >>
> > >> Changes Since v2:
> > >> (*) Address feedback provided for the commit "BaseTools/AutoGen: Update
> > header file for MM modules."
> > >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit
> > "StandaloneMmPkg: Add an AArch64 specific entry point library."
> > >>
> > >> Changes Since v1:
> > >> (*) Reorder and Reword commits.
> > >> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> > >> (*) Address Review Comments from Achin, Jiewen and Daniil.
> > >> ***
> > >> Supreeth Venkatesh (17):
> > >>   ArmPkg: Add PCDs needed for MM communication driver.
> > >>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> > >>   ArmPkg/Include: Add MM interface SVC return codes.
> > >>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> > >>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in S-EL0.
> > >>   StandaloneMmPkg: Delete StandaloneMmPkg file.
> > >>   StandaloneMmPkg/FvLib: Add a common FV Library for management
> > mode.
> > >>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory
> > check
> > >>     library.
> > >>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation
> > library.
> > >>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
> > >>   StandaloneMmPkg: MM driver entry point library.
> > >>   StandaloneMmPkg/Core: Implementation of Standalone MM Core
> > Module.
> > >>   StandaloneMmPkg: Add an AArch64 specific entry point library.
> > >>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
> > >>   StandaloneMmPkg: Describe the declaration and definition files.
> > >>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
> > >>   BaseTools/AutoGen: Update header file for MM modules.
> > >
> > > Tested all changes for RAS error injection and error handling on
> > > SGI575 platform.
> > >
> > > Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > >
> > > -sughosh
> >
> > There have been no further comments on this series. Can this patch
> > series be merged?
> >
> > Thanks,
> > Thomas.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms ***
Posted by Yao, Jiewen 5 years, 10 months ago
Sure. Fine. :-)

The key is to split package, as such different package owner to check in its own package.

Thank you
Yao Jiewen


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Achin
> Gupta
> Sent: Tuesday, June 19, 2018 1:24 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>
> Cc: nd@arm.com; edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode Core
> Interface for AARCH64 Platforms ***
> 
> Hi Jiewen,
> 
> On Mon, Jun 18, 2018 at 03:12:46PM +0000, Yao, Jiewen wrote:
> > Yes. I think so.
> >
> > However, I found the V3 just contains partial of the patch. It is hard to find
> some V2 and some V3.
> > Also this series includes multiple package. We need different package
> maintainer to push different patches.
> >
> > I recommend we do in this way:
> > Please split this big one into 3 - BaseTool patch, ArmPkg patch, and
> StandaloneMmPkg patch.
> >
> > Then BaseTool maintainer can push BaseTool patch, ArmPkg maintainer can
> push ArmPkg patch, and I can help push StandaloneMmPkg patch.
> 
> Thomas and Sugosh will refactor the patches and repost since Supreeth is on
> holiday. I started late but would like to finish reviewing the Arm specific bits
> in the StandaloneMmPkg before they are merged. Will not take more than 2
> days. Could you please merge after I ack. Hope that is fine?
> 
> cheers,
> Achin
> 
> >
> > Thank you
> > Yao Jiewen
> >
> > > -----Original Message-----
> > > From: Thomas Abraham [mailto:thomas.abraham@arm.com]
> > > Sent: Monday, June 18, 2018 6:07 AM
> > > To: Sughosh Ganu <sng.lists@gmail.com>
> > > Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> > > edk2-devel@lists.01.org; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming
> > > <liming.gao@intel.com>
> > > Subject: Re: [edk2] [PATCH v3 00/17] *** Standalone Management Mode
> Core
> > > Interface for AARCH64 Platforms ***
> > >
> > > On Wed, Jun 6, 2018 at 4:50 PM, Sughosh Ganu <sng.lists@gmail.com>
> wrote:
> > > > On Tue, Jun 5, 2018 at 3:43 AM, Supreeth Venkatesh
> > > > <supreeth.venkatesh@arm.com> wrote:
> > > >> ***
> > > >> This patchset v3 contains only the patches that got feedback/comments
> > > frome the previous revision v2.
> > > >> The patches are
> > > >> [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
> > > >> [PATCH v3 13/17] StandaloneMmPkg: Add an AArch64 specific entry
> point
> > > library.
> > > >> [PATCH v3 17/17] BaseTools/AutoGen: Update header file for MM
> modules.
> > > >>
> > > >> Changes Since v2:
> > > >> (*) Address feedback provided for the commit "BaseTools/AutoGen:
> Update
> > > header file for MM modules."
> > > >> (*) Edit parameters for the StandaloneMmCpu Driver in the commit
> > > "StandaloneMmPkg: Add an AArch64 specific entry point library."
> > > >>
> > > >> Changes Since v1:
> > > >> (*) Reorder and Reword commits.
> > > >> (*) Reorganize structure of StandaloneMmPkg and rename libraries.
> > > >> (*) Address Review Comments from Achin, Jiewen and Daniil.
> > > >> ***
> > > >> Supreeth Venkatesh (17):
> > > >>   ArmPkg: Add PCDs needed for MM communication driver.
> > > >>   ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE
> driver.
> > > >>   ArmPkg/Include: Add MM interface SVC return codes.
> > > >>   ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> > > >>   ArmPkg/ArmMmuLib: Add MMU library inf file suitable for use in
> S-EL0.
> > > >>   StandaloneMmPkg: Delete StandaloneMmPkg file.
> > > >>   StandaloneMmPkg/FvLib: Add a common FV Library for management
> > > mode.
> > > >>   StandaloneMmPkg/MemLib: Add Standalone MM instance of memory
> > > check
> > > >>     library.
> > > >>   StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation
> > > library.
> > > >>   StandaloneMmPkg/HobLib: Add HOB Library for management mode.
> > > >>   StandaloneMmPkg: MM driver entry point library.
> > > >>   StandaloneMmPkg/Core: Implementation of Standalone MM Core
> > > Module.
> > > >>   StandaloneMmPkg: Add an AArch64 specific entry point library.
> > > >>   StandaloneMmPkg: Add CPU driver suitable for ARM Platforms.
> > > >>   StandaloneMmPkg: Describe the declaration and definition files.
> > > >>   ArmPkg: Extra action to update permissions for S-ELO MM Image.
> > > >>   BaseTools/AutoGen: Update header file for MM modules.
> > > >
> > > > Tested all changes for RAS error injection and error handling on
> > > > SGI575 platform.
> > > >
> > > > Tested-by: Sughosh Ganu <sughosh.ganu@arm.com>
> > > >
> > > > -sughosh
> > >
> > > There have been no further comments on this series. Can this patch
> > > series be merged?
> > >
> > > Thanks,
> > > Thomas.
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
[edk2] [PATCH v3 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file.
Posted by Supreeth Venkatesh 5 years, 10 months ago
This patch deletes "StandaloneMmPkg" which was created as a file
intially. This patch enables creation of "StandaloneMmPkg" as a folder.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Reviewed-by: Achin Gupta <achin.gupta@arm.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
---
 StandaloneMmPkg | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 delete mode 100644 StandaloneMmPkg

diff --git a/StandaloneMmPkg b/StandaloneMmPkg
deleted file mode 100644
index e69de29bb2..0000000000
-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel